ash: Select omnibox text on mouse up instead of down.

Defer selection of the text in an unfocused omnibox until
the release event.  Otherwise, all of the text starting from
the left side is selected when the user is trying to
highlight just a portion of the URL.

BUG=128126
TEST=added, also did manual testing


Review URL: https://chromiumcodereview.appspot.com/10386173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137711 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 11 insertions, 7 deletions

diff --git a/ui/views/controls/textfield/native_textfield_views.cc b/ui/views/controls/textfield/native_textfield_views.cc
index 03565d7..35fe3e2 100644
--- a/ui/views/controls/textfield/native_textfield_views.cc
+++ b/ui/views/controls/textfield/native_textfield_views.cc
@@ -105,13 +105,10 @@ NativeTextfieldViews::~NativeTextfieldViews() {
 bool NativeTextfieldViews::OnMousePressed(const MouseEvent& event) {
   OnBeforeUserAction();
   TrackMouseClicks(event);
-
-  // Allow the textfield/omnibox to optionally handle the mouse pressed event.
-  // This should be removed once native textfield implementations are
-  // consolidated to textfield.
+  // TODO: Remove once NativeTextfield implementations are consolidated to
+  // Textfield.
   if (!textfield_->OnMousePressed(event))
     HandleMousePressEvent(event);
-
   OnAfterUserAction();
   return true;
 }
@@ -129,14 +126,21 @@ bool NativeTextfieldViews::OnMouseDragged(const MouseEvent& event) {
     return true;
 
   OnBeforeUserAction();
-  if (MoveCursorTo(event.location(), true))
-    SchedulePaint();
+  // TODO: Remove once NativeTextfield implementations are consolidated to
+  // Textfield.
+  if (!textfield_->OnMouseDragged(event)) {
+    if (MoveCursorTo(event.location(), true))
+      SchedulePaint();
+  }
   OnAfterUserAction();
   return true;
 }
 
 void NativeTextfieldViews::OnMouseReleased(const MouseEvent& event) {
   OnBeforeUserAction();
+  // TODO: Remove once NativeTextfield implementations are consolidated to
+  // Textfield.
+  textfield_->OnMouseReleased(event);
   // Cancel suspected drag initiations, the user was clicking in the selection.
   if (initiating_drag_ && MoveCursorTo(event.location(), false))
     SchedulePaint();