diff options
author | grt <grt@chromium.org> | 2015-06-29 06:56:55 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-06-29 13:57:38 +0000 |
commit | 518e46bc703661e7152312a9028c6a1ca13a3fa6 (patch) | |
tree | ef0362df7114798641a927869597025c792f10da /ui | |
parent | 69ae62dcab791aac1230c44821ebd0fa3b3480e3 (diff) | |
download | chromium_src-518e46bc703661e7152312a9028c6a1ca13a3fa6.zip chromium_src-518e46bc703661e7152312a9028c6a1ca13a3fa6.tar.gz chromium_src-518e46bc703661e7152312a9028c6a1ca13a3fa6.tar.bz2 |
Revert of Pretty print AlternativeService in test macros. (patchset #1 id:1 of https://codereview.chromium.org/1212813006/)
Reason for revert:
Introduced new static initializers:
# http_server_properties.cc _GLOBAL__sub_I_http_server_properties.cc+0x10
# http_server_properties.cc std::ios_base::Init::Init()@plt
# http_server_properties.cc __cxa_atexit@plt [registers a dtor to run at exit]
Original issue's description:
> Pretty print AlternativeService in test macros.
>
> Implement operator<<(std::ostream&, const AlternativeService&) so that when
> EXPECT_EQ or ASSERT_EQ fails between two AlternativeService structs, the test
> output contains protocol names and hostnames pretty printed, instead of a binary
> blob including useless things like the memory address of where std::string
> stores the hostname.
>
> Currently used in AlternateProtocolServerPropertiesTest.BrokenShadowsCanonical
> only, but more tests involving EXPECT_EQ between AlternativeService structs are
> coming.
>
> BUG=392575
>
> Committed: https://crrev.com/a3542c2eb9d3760800d718c51eb9f573a42c6b42
> Cr-Commit-Position: refs/heads/master@{#336551}
TBR=rch@chromium.org,bnc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=392575
Review URL: https://codereview.chromium.org/1218813005
Cr-Commit-Position: refs/heads/master@{#336556}
Diffstat (limited to 'ui')
0 files changed, 0 insertions, 0 deletions