diff options
| author | mtomasz <mtomasz@chromium.org> | 2015-03-26 02:47:02 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-26 09:47:53 +0000 |
| commit | c5d0b60cdf33ce7330d6b9ef352b8119e65ec9de (patch) | |
| tree | 814043fdb93dfdf1b11f69027823c7c0fc25b3e3 /ui | |
| parent | d1ab781261460eae053723d8e3524999b00a52f4 (diff) | |
| download | chromium_src-c5d0b60cdf33ce7330d6b9ef352b8119e65ec9de.zip chromium_src-c5d0b60cdf33ce7330d6b9ef352b8119e65ec9de.tar.gz chromium_src-c5d0b60cdf33ce7330d6b9ef352b8119e65ec9de.tar.bz2 | |
Move the check for fileBrowserHandler permission to FileBrowserHandler.
The previous check location was forcing all apps and extensions which call
the chrome.fileSystem.requestFileSystem API, to have "fileBrowserHandler"
permission as well.
That however doesn't make much sense, as those apps are not always handlers.
This CL moves the check to FileBrowserHandler::GetHandler() so simply the
permission has to be used only if the app wants to be a handler.
TEST=unit_test: FileBrowserHandlerManifestTest.GetHandlersRequiresPermission
BUG=470494
Review URL: https://codereview.chromium.org/1030133002
Cr-Commit-Position: refs/heads/master@{#322343}
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/file_manager/audio_player/manifest.json | 1 | ||||
| -rw-r--r-- | ui/file_manager/gallery/manifest.json | 1 | ||||
| -rw-r--r-- | ui/file_manager/image_loader/manifest.json | 1 | ||||
| -rw-r--r-- | ui/file_manager/video_player/manifest.json | 1 |
4 files changed, 0 insertions, 4 deletions
diff --git a/ui/file_manager/audio_player/manifest.json b/ui/file_manager/audio_player/manifest.json index 7a15cf2..2ef7522 100644 --- a/ui/file_manager/audio_player/manifest.json +++ b/ui/file_manager/audio_player/manifest.json @@ -19,7 +19,6 @@ "permissions": [ "commandLinePrivate", "fileSystem", - "fileBrowserHandler", "fileManagerPrivate", { "fileSystem": ["requestFileSystem", "write"] diff --git a/ui/file_manager/gallery/manifest.json b/ui/file_manager/gallery/manifest.json index 09c3c84..24ef8f7 100644 --- a/ui/file_manager/gallery/manifest.json +++ b/ui/file_manager/gallery/manifest.json @@ -21,7 +21,6 @@ "chrome://extension-icon/", "chrome://resources/", "chrome://theme/", - "fileBrowserHandler", "fileManagerPrivate", { "fileSystem": ["requestFileSystem", "write"] diff --git a/ui/file_manager/image_loader/manifest.json b/ui/file_manager/image_loader/manifest.json index 3d2daf0..1262046 100644 --- a/ui/file_manager/image_loader/manifest.json +++ b/ui/file_manager/image_loader/manifest.json @@ -7,7 +7,6 @@ "incognito" : "split", "manifest_version": 2, "permissions": [ - "fileBrowserHandler", { "fileSystem": ["requestFileSystem"] }, diff --git a/ui/file_manager/video_player/manifest.json b/ui/file_manager/video_player/manifest.json index 77f8e55..9c5c4a0 100644 --- a/ui/file_manager/video_player/manifest.json +++ b/ui/file_manager/video_player/manifest.json @@ -19,7 +19,6 @@ "permissions": [ "commandLinePrivate", "fileSystem", - "fileBrowserHandler", "fileManagerPrivate", { "fileSystem": ["requestFileSystem", "write"] |