summaryrefslogtreecommitdiffstats
path: root/url/url.gyp
diff options
context:
space:
mode:
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-30 00:32:32 +0000
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-30 00:32:32 +0000
commitfb3cd66523f8c0314aaeda05209c9af1158faf41 (patch)
treed9f75661a925ad71661fd6c4fd4abadeccac6c1d /url/url.gyp
parent5bc7d2edb91c87f640e254f30f534c1d43423bd4 (diff)
downloadchromium_src-fb3cd66523f8c0314aaeda05209c9af1158faf41.zip
chromium_src-fb3cd66523f8c0314aaeda05209c9af1158faf41.tar.gz
chromium_src-fb3cd66523f8c0314aaeda05209c9af1158faf41.tar.bz2
ContentSettingImageView cleanup, phase 3.
Swapping between BoxLayouts when the background toggles is confusing, and requires us to also add and remove children in order to get the padding right. Instead, just manually Layout(), which isn't hard, and allows us to create the text label in the constructor and just toggle its visibility instead of actually adding and removing it. This CL contains a few minor changes: * The label now obeys not only the passed-in font but also the color and y-position. * The label is now ALIGN_LEFT, which probably doesn't matter with NO_ELIDE but is more logical in principle (since we think of the label as being pinned to the icon on its left side). * The size calculations now cause the animation to smoothly grow from the size of the icon all the way out (and vice versa), rather than having the starting state of the animation be a jump (compared to the non-animating state) to immediately showing the background already expanded out to the margins around the icon. This is almost imperceptible at full speed but makes the animation slightly smoother. BUG=none TEST=none R=sky@chromium.org Review URL: https://codereview.chromium.org/16115010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203023 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'url/url.gyp')
0 files changed, 0 insertions, 0 deletions