diff options
author | dpranke <dpranke@chromium.org> | 2016-02-03 08:57:44 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-03 16:59:37 +0000 |
commit | 002f2226477126a477d38086b119073911fa231d (patch) | |
tree | af82ceffc1a92388390867d474e90f4c0073771d /url | |
parent | 761098fba97c6ec094e241b61ecf879134ab7922 (diff) | |
download | chromium_src-002f2226477126a477d38086b119073911fa231d.zip chromium_src-002f2226477126a477d38086b119073911fa231d.tar.gz chromium_src-002f2226477126a477d38086b119073911fa231d.tar.bz2 |
Revert of Move gn _run target generation into test(). (patchset #1 id:1 of https://codereview.chromium.org/1653003006/ )
Reason for revert:
Broke angle_unittests_run, which doesn't follow the template:
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/53646/steps/compile/logs/stdio
Original issue's description:
> Move gn _run target generation into test().
>
> TBR=brettw@chromium.org
> BUG=
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a
> Cr-Commit-Position: refs/heads/master@{#373232}
TBR=phosek@chromium.org,brettw@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1664653003
Cr-Commit-Position: refs/heads/master@{#373257}
Diffstat (limited to 'url')
-rw-r--r-- | url/BUILD.gn | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/url/BUILD.gn b/url/BUILD.gn index 6924784..d403efb 100644 --- a/url/BUILD.gn +++ b/url/BUILD.gn @@ -115,6 +115,15 @@ if (is_android) { # TODO(dpranke): crbug.com/360936. Get this to build and run on Android. if (!is_android) { + # TODO(GYP): Delete this after we've converted everything to GN. + # The _run targets exist only for compatibility w/ GYP. + group("url_unittests_run") { + testonly = true + deps = [ + ":url_unittests", + ] + } + test("url_unittests") { sources = [ "gurl_unittest.cc", |