diff options
author | palmer <palmer@chromium.org> | 2015-04-21 23:33:49 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-04-22 06:34:15 +0000 |
commit | 12b415ba1a82e3c284a073637ae5221a2a948ede (patch) | |
tree | 954cf9ecf4eea0ca7abfb8e0b93bfcd12add5bde /url | |
parent | 1562114438ab99e82b61c9819c153e7b7e932504 (diff) | |
download | chromium_src-12b415ba1a82e3c284a073637ae5221a2a948ede.zip chromium_src-12b415ba1a82e3c284a073637ae5221a2a948ede.tar.gz chromium_src-12b415ba1a82e3c284a073637ae5221a2a948ede.tar.bz2 |
Rename GURL::SchemeUsesTLS to SchemeIsCryptographic.
Since there will increasingly be things like QUIC that offer similar guarantees
but which are not precisely TLS.
Per discussion in https://codereview.chromium.org/1049533002/.
BUG=362214
TBR=brettw,thestig@chromium.org,isherman@chromium.org,mmenke@chromium.org,abarth@chromium.org
Review URL: https://codereview.chromium.org/1049953003
Cr-Commit-Position: refs/heads/master@{#326236}
Diffstat (limited to 'url')
-rw-r--r-- | url/gurl.h | 17 |
1 files changed, 9 insertions, 8 deletions
@@ -225,12 +225,13 @@ class URL_EXPORT GURL { // Returns true if the scheme indicates a secure connection. // - // NOTE: This function is deprecated. You probably want |SchemeUsesTLS| (if - // you just want to know if a scheme uses TLS for network transport) or - // Chromium's |IsOriginSecure| for a higher-level test about an origin's - // security. See those functions' documentation for more detail. + // NOTE: This function is deprecated. You probably want + // |SchemeIsCryptographic| (if you just want to know if a scheme uses TLS for + // network transport) or Chromium's |IsOriginSecure| for a higher-level test + // about an origin's security. See those functions' documentation for more + // detail. // - // TODO(palmer): Audit callers and change them to |SchemeUsesTLS| or + // TODO(palmer): Audit callers and change them to |SchemeIsCryptographic| or // |IsOriginSecure|, as appropriate. Then remove |SchemeIsSecure|. // crbug.com/362214 bool SchemeIsSecure() const { @@ -239,14 +240,14 @@ class URL_EXPORT GURL { inner_url()->SchemeIsSecure()); } - // Returns true if the scheme indicates a network connection that uses TLS for - // security. + // Returns true if the scheme indicates a network connection that uses TLS or + // some other cryptographic protocol (e.g. QUIC) for security. // // This function is a not a complete test of whether or not an origin's code // is minimally trustworthy. For that, see Chromium's |IsOriginSecure| for a // higher-level and more complete semantics. See that function's documentation // for more detail. - bool SchemeUsesTLS() const { + bool SchemeIsCryptographic() const { return SchemeIs(url::kHttpsScheme) || SchemeIs(url::kWssScheme); } |