Change store group and newest cache API so that storage failure does not require storage clients to revert changes to group and so it's not racey.TEST=existing tests updatedBUG=none

Review URL: http://codereview.chromium.org/384029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31730 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 3 deletions

diff --git a/webkit/appcache/appcache_storage.h b/webkit/appcache/appcache_storage.h
index 67717a5..02b6884 100644
--- a/webkit/appcache/appcache_storage.h
+++ b/webkit/appcache/appcache_storage.h
@@ -88,12 +88,14 @@ class AppCacheStorage {
   // Schedules a group and its newest complete cache to be initially stored or
   // incrementally updated with new changes. Upon completion the delegate
   // will be called back. A group without a newest cache cannot be stored.
-  // It's a programming error to call this method with such a group. A
+  // It's a programming error to call this method without a newest cache. A
   // side effect of storing a new newest cache is the removal of the group's
   // old caches and responses from persistent storage (although they may still
-  // linger in the in-memory working set until no longer needed).
+  // linger in the in-memory working set until no longer needed). The new
+  // cache will be added as the group's newest complete cache only if storage
+  // succeeds.
   virtual void StoreGroupAndNewestCache(
-      AppCacheGroup* group, Delegate* delegate) = 0;
+      AppCacheGroup* group, AppCache* newest_cache, Delegate* delegate) = 0;
 
   // Schedules a query to identify a response for a main request. Upon
   // completion the delegate will be called back.