diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-11 16:46:36 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-11 16:46:36 +0000 |
| commit | cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622 (patch) | |
| tree | 7b95f103fce509de887c8c5e643604855b57c0ba /webkit/browser/blob | |
| parent | 9f6e673c7f43f6ee414f72a74585dad8ebaceec3 (diff) | |
| download | chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.zip chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.tar.gz chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.tar.bz2 | |
Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"
This upates calls to bound temporary objects to also use get().
While it has the same semantic equivalence to the existing code, this generally
represents a dangerous pattern - indeed, part of the whole motivation for this
change is to make this anti-pattern very visible to authors.
This change simply updates all of the call sites, to allow the "operator T*"
to be removed and preventing new instances. The existing instances will then be
reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T>
rather than T*, as appropriate.
BUG=110610
TBR=darin
Review URL: https://codereview.chromium.org/15984016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/browser/blob')
| -rw-r--r-- | webkit/browser/blob/blob_storage_context.cc | 2 | ||||
| -rw-r--r-- | webkit/browser/blob/blob_url_request_job_unittest.cc | 2 | ||||
| -rw-r--r-- | webkit/browser/blob/mock_blob_url_request_context.cc | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/webkit/browser/blob/blob_storage_context.cc b/webkit/browser/blob/blob_storage_context.cc index 89f75af..123f398 100644 --- a/webkit/browser/blob/blob_storage_context.cc +++ b/webkit/browser/blob/blob_storage_context.cc @@ -67,7 +67,7 @@ scoped_ptr<BlobDataHandle> BlobStorageContext::GetBlobDataFromUUID( return result.Pass(); DCHECK(!(found->second.flags & BEING_BUILT)); result.reset(new BlobDataHandle( - found->second.data.get(), this, base::MessageLoopProxy::current())); + found->second.data.get(), this, base::MessageLoopProxy::current().get())); return result.Pass(); } diff --git a/webkit/browser/blob/blob_url_request_job_unittest.cc b/webkit/browser/blob/blob_url_request_job_unittest.cc index 90bd261..2a204ba 100644 --- a/webkit/browser/blob/blob_url_request_job_unittest.cc +++ b/webkit/browser/blob/blob_url_request_job_unittest.cc @@ -125,7 +125,7 @@ class BlobURLRequestJobTest : public testing::Test { network_delegate, test_->blob_data_.get(), test_->file_system_context_.get(), - base::MessageLoopProxy::current()); + base::MessageLoopProxy::current().get()); } private: diff --git a/webkit/browser/blob/mock_blob_url_request_context.cc b/webkit/browser/blob/mock_blob_url_request_context.cc index 98f12de..45c6134 100644 --- a/webkit/browser/blob/mock_blob_url_request_context.cc +++ b/webkit/browser/blob/mock_blob_url_request_context.cc @@ -31,7 +31,7 @@ class MockBlobProtocolHandler network_delegate, blob_storage_controller_->GetBlobDataFromUrl(request->url()), file_system_context_, - base::MessageLoopProxy::current()); + base::MessageLoopProxy::current().get()); } private: |