diff options
| author | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-10 17:52:43 +0000 |
|---|---|---|
| committer | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-10 17:52:43 +0000 |
| commit | 2c02c8d3eb2827b2d2c9b5e300a7cf49f5c2624a (patch) | |
| tree | 3b74668cbd3f3d7e3f8725a949f92cf85c318e04 /webkit/browser/fileapi/file_system_operation.h | |
| parent | 312d44ffbf5671224e50754d690dfdc98aad0fc2 (diff) | |
| download | chromium_src-2c02c8d3eb2827b2d2c9b5e300a7cf49f5c2624a.zip chromium_src-2c02c8d3eb2827b2d2c9b5e300a7cf49f5c2624a.tar.gz chromium_src-2c02c8d3eb2827b2d2c9b5e300a7cf49f5c2624a.tar.bz2 | |
Make FileSystemOperation NOT self-destruct
This architecture was found to bring lots of undesirable
complexity in the codebase. This should become much simpler.
BUG=176444
TEST=unit_tests:*File*, content_unittests:*File*, browser_tests:*File*
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/16413007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205243 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/browser/fileapi/file_system_operation.h')
| -rw-r--r-- | webkit/browser/fileapi/file_system_operation.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/webkit/browser/fileapi/file_system_operation.h b/webkit/browser/fileapi/file_system_operation.h index b901f1e..8cc015e 100644 --- a/webkit/browser/fileapi/file_system_operation.h +++ b/webkit/browser/fileapi/file_system_operation.h @@ -47,12 +47,12 @@ class LocalFileSystemOperation; // GetMetadata, ReadDirectory and Remove) may be called during the // lifetime of this object and it should be called no more than once. // -// 2) Be self-destructed, or get deleted via base::Owned() after the -// operation finishes and completion callback is called. -// -// 3) Deliver the results of operations to the client via the callback function +// 2) Deliver the results of operations to the client via the callback function // passed as the last parameter of the method. // +// Note that it is valid to delete an operation while it is running. +// The callback will NOT be fired if the operation is deleted before +// it gets called. class FileSystemOperation { public: virtual ~FileSystemOperation() {} |