diff options
| author | pneubeck@chromium.org <pneubeck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-20 08:42:18 +0000 |
|---|---|---|
| committer | pneubeck@chromium.org <pneubeck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-20 08:42:18 +0000 |
| commit | 464d2e72df3488361b550354cbf8cc98d4cae614 (patch) | |
| tree | ae8769886516451dd081ffd667ea862c6a38c35d /webkit/browser/fileapi/local_file_stream_writer_unittest.cc | |
| parent | 69a6676006e7aa61002aefd01f335dc0dc03c419 (diff) | |
| download | chromium_src-464d2e72df3488361b550354cbf8cc98d4cae614.zip chromium_src-464d2e72df3488361b550354cbf8cc98d4cae614.tar.gz chromium_src-464d2e72df3488361b550354cbf8cc98d4cae614.tar.bz2 | |
Revert of Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new (https://codereview.chromium.org/197233008/)
Reason for revert:
Best guess that this broke
SyncFileSystemApiTest.WriteFileThenGetUsage
on XP Tests(1).
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/30601/steps/browser_tests/logs/WriteFileThenGetUsage
If not, we can just re-revert or reland it after a few cycles.
Original issue's description:
> Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new files as well as writing to existing files.
> See https://codereview.chromium.org/18023022/ for context; this is needed by upcoming IDB Blob support.
>
> Tzik, please do primary review for filesystem; Kinaba, please review as ChromeOS owner.
>
> BUG=108012
> R=kinaba,tzik
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258120
TBR=kinaba@chromium.org,tzik@chromium.org,ericu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=108012
Review URL: https://codereview.chromium.org/206073006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258256 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/browser/fileapi/local_file_stream_writer_unittest.cc')
| -rw-r--r-- | webkit/browser/fileapi/local_file_stream_writer_unittest.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/webkit/browser/fileapi/local_file_stream_writer_unittest.cc b/webkit/browser/fileapi/local_file_stream_writer_unittest.cc index a414044..53c559a 100644 --- a/webkit/browser/fileapi/local_file_stream_writer_unittest.cc +++ b/webkit/browser/fileapi/local_file_stream_writer_unittest.cc @@ -80,8 +80,7 @@ class LocalFileStreamWriterTest : public testing::Test { LocalFileStreamWriter* CreateWriter(const base::FilePath& path, int64 offset) { - return new LocalFileStreamWriter(file_task_runner(), path, offset, - FileStreamWriter::OPEN_EXISTING_FILE); + return new LocalFileStreamWriter(file_task_runner(), path, offset); } private: |