diff options
| author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-23 20:14:41 +0000 |
|---|---|---|
| committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-23 20:14:41 +0000 |
| commit | d44d23502415ba7ce37fd93895194792f85ada97 (patch) | |
| tree | 0426acfa1ecb9e6b6ef8522440128b45522cc485 /webkit/build | |
| parent | 6889104090b299e1e22e7639e0f923177e5fb988 (diff) | |
| download | chromium_src-d44d23502415ba7ce37fd93895194792f85ada97.zip chromium_src-d44d23502415ba7ce37fd93895194792f85ada97.tar.gz chromium_src-d44d23502415ba7ce37fd93895194792f85ada97.tar.bz2 | |
I'm expanding this to fix a couple of bugs in determining the file name for
dragging images:
. It's possible for the extension to be empty, resulting in a bad file
name, for example, 'foo.' or just '.'.
. We weren't restricting the size of the file to MAX_PATH.
. We weren't removing characters that are invalid for file system names.
It's possible to put this code up in OSExchangeData rather than
here, but it feels best to centralize it here so that we don't have to
worry about bad file names leaking into other code.
I tried hard to write a layout test for this, but it seems we don't
really use the file name in test shell so that I couldn't get
coverage.
BUG=7023
TEST=none
Review URL: http://codereview.chromium.org/20504
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10206 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/build')
| -rw-r--r-- | webkit/build/WebCore/SConscript | 1 | ||||
| -rw-r--r-- | webkit/build/WebCore/WebCore.vcproj | 4 |
2 files changed, 5 insertions, 0 deletions
diff --git a/webkit/build/WebCore/SConscript b/webkit/build/WebCore/SConscript index 0db8ffd..2335c69 100644 --- a/webkit/build/WebCore/SConscript +++ b/webkit/build/WebCore/SConscript @@ -937,6 +937,7 @@ if env.Bit('windows'): if env.Bit('linux'): # Linux specific implementations. input_files.extend([ + '$WEBCORE_DIR/platform/chromium/ClipboardChromiumLinux.cpp', '$WEBCORE_DIR/platform/chromium/FileSystemChromiumLinux.cpp', '$WEBCORE_DIR/platform/chromium/gtk2drawing.c', '$WEBCORE_DIR/platform/chromium/KeyCodeConversionGtk.cpp', diff --git a/webkit/build/WebCore/WebCore.vcproj b/webkit/build/WebCore/WebCore.vcproj index 859401f..f199e5a 100644 --- a/webkit/build/WebCore/WebCore.vcproj +++ b/webkit/build/WebCore/WebCore.vcproj @@ -2236,6 +2236,10 @@ > </File> <File + RelativePath="..\..\..\third_party\WebKit\WebCore\platform\chromium\ClipboardChromiumWin.cpp" + > + </File> + <File RelativePath="..\..\..\third_party\WebKit\WebCore\platform\chromium\ClipboardChromium.h" > </File> |