diff options
author | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-27 01:53:09 +0000 |
---|---|---|
committer | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-27 01:53:09 +0000 |
commit | 949f25a052e09392ef70b75bcda422dc13eeef45 (patch) | |
tree | 135512e13da7e59d8171d41f2f1ca48bb58611a8 /webkit/fileapi/file_system_mount_point_provider.h | |
parent | 967dcfe12bf6fb2939407e9d883efb687ac5c031 (diff) | |
download | chromium_src-949f25a052e09392ef70b75bcda422dc13eeef45.zip chromium_src-949f25a052e09392ef70b75bcda422dc13eeef45.tar.gz chromium_src-949f25a052e09392ef70b75bcda422dc13eeef45.tar.bz2 |
Reduce the number of CrackFileSystemURL
- crack the filesystem URL as soon as we get it in FileAPIMessageFilter
- introduce a new class FileSystemURL for cracked URL information and use it everywhere
- deprecate FileSystemPath (this used to serve the similar role for *FileUtil classes)
Mechanical changes only except for fileapi_message_filter.cc and file_system_operation.cc.
This change reduces the # of CrackFileSystemURL roughly from 3~4 to 1 for each FileSystem operation.
BUG=none
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10566002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144368 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/fileapi/file_system_mount_point_provider.h')
-rw-r--r-- | webkit/fileapi/file_system_mount_point_provider.h | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/webkit/fileapi/file_system_mount_point_provider.h b/webkit/fileapi/file_system_mount_point_provider.h index b641da8..6fb59c2 100644 --- a/webkit/fileapi/file_system_mount_point_provider.h +++ b/webkit/fileapi/file_system_mount_point_provider.h @@ -14,14 +14,13 @@ #include "webkit/fileapi/fileapi_export.h" #include "webkit/fileapi/file_system_types.h" -class GURL; - namespace webkit_blob { class FileStreamReader; } namespace fileapi { +class FileSystemURL; class FileStreamWriter; class FileSystemContext; class FileSystemFileUtil; @@ -82,9 +81,7 @@ class FILEAPI_EXPORT FileSystemMountPointProvider { // This method is usually dispatched by // FileSystemContext::CreateFileSystemOperation. virtual FileSystemOperationInterface* CreateFileSystemOperation( - const GURL& origin_url, - FileSystemType file_system_type, - const FilePath& virtual_path, + const FileSystemURL& url, FileSystemContext* context) const = 0; // Creates a new file stream reader for a given filesystem URL |url| with an @@ -93,7 +90,7 @@ class FILEAPI_EXPORT FileSystemMountPointProvider { // This method itself does *not* check if the given path exists and is a // regular file. virtual webkit_blob::FileStreamReader* CreateFileStreamReader( - const GURL& url, + const FileSystemURL& url, int64 offset, FileSystemContext* context) const = 0; @@ -103,7 +100,7 @@ class FILEAPI_EXPORT FileSystemMountPointProvider { // This method itself does *not* check if the given path exists and is a // regular file. virtual FileStreamWriter* CreateFileStreamWriter( - const GURL& url, + const FileSystemURL& url, int64 offset, FileSystemContext* context) const = 0; |