Retry: Make Isolated file system writable only if it is configured so

- CreateFileStreamWriter wiring in FSO
- Add yet another write-protection at IsolatedContext (in addition to ChildProcessSecurityPolicy, so that we can make each fs read-only or writable in DRT/testing)

BUG=none
TEST=existing tests should pass

Original review URL: https://chromiumcodereview.appspot.com/10540070

Review URL: https://chromiumcodereview.appspot.com/10532085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141650 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 24 insertions, 0 deletions

diff --git a/webkit/fileapi/isolated_context_unittest.cc b/webkit/fileapi/isolated_context_unittest.cc
index 5a828f5..a1b138b 100644
--- a/webkit/fileapi/isolated_context_unittest.cc
+++ b/webkit/fileapi/isolated_context_unittest.cc
@@ -165,4 +165,28 @@ TEST_F(IsolatedContextTest, TestWithVirtualRoot) {
       virtual_path, &cracked_id, &root_path, &cracked_path));
 }
 
+TEST_F(IsolatedContextTest, Writable) {
+  // By default the file system must be read-only.
+  ASSERT_FALSE(isolated_context()->IsWritable(id_));
+
+  // Set writable.
+  ASSERT_TRUE(isolated_context()->SetWritable(id_, true));
+  ASSERT_TRUE(isolated_context()->IsWritable(id_));
+
+  // Set non-writable.
+  ASSERT_TRUE(isolated_context()->SetWritable(id_, false));
+  ASSERT_FALSE(isolated_context()->IsWritable(id_));
+
+  // Set writable again, and revoke the filesystem.
+  ASSERT_TRUE(isolated_context()->SetWritable(id_, true));
+  isolated_context()->RevokeIsolatedFileSystem(id_);
+
+  // IsWritable should return false for non-registered file system.
+  ASSERT_FALSE(isolated_context()->IsWritable(id_));
+  // SetWritable should also return false for non-registered file system
+  // (no matter what value we give).
+  ASSERT_FALSE(isolated_context()->SetWritable(id_, true));
+  ASSERT_FALSE(isolated_context()->SetWritable(id_, false));
+}
+
 }  // namespace fileapi