diff options
| author | tedv@chromium.org <tedv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-19 02:53:29 +0000 |
|---|---|---|
| committer | tedv@chromium.org <tedv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-19 02:53:29 +0000 |
| commit | dd8b8d1cc7478cf07070b1a3e20e67e6bf9bc27c (patch) | |
| tree | ff98e7100e6a5d9c700247ffec04ae7f0ede6218 /webkit/fileapi | |
| parent | ca8d150cf93e15f8a1bf621ddc16cf9982e73767 (diff) | |
| download | chromium_src-dd8b8d1cc7478cf07070b1a3e20e67e6bf9bc27c.zip chromium_src-dd8b8d1cc7478cf07070b1a3e20e67e6bf9bc27c.tar.gz chromium_src-dd8b8d1cc7478cf07070b1a3e20e67e6bf9bc27c.tar.bz2 | |
Update TestURLRequest constructor interface in unit tests.
The webkit and android_webview unit tests that create TestURLRequest objects
are updated in this patch to explicitly specify which network delegate they
use, rather than extracting it from the context. This is usually but not
always NULL.
This change is motivated by a desire to remove external accesses to a request
context's delegate. (If a block of code needs to use a NetworkDelegate, it
should not query the URLRequestContext for it, but instead should already have
access to whatever delegate the context uses.)
BUG=146587
Review URL: https://chromiumcodereview.appspot.com/12321106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188920 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/fileapi')
| -rw-r--r-- | webkit/fileapi/file_system_dir_url_request_job_unittest.cc | 4 | ||||
| -rw-r--r-- | webkit/fileapi/file_system_url_request_job_unittest.cc | 4 |
2 files changed, 2 insertions, 6 deletions
diff --git a/webkit/fileapi/file_system_dir_url_request_job_unittest.cc b/webkit/fileapi/file_system_dir_url_request_job_unittest.cc index 19aa253..cacb8ca 100644 --- a/webkit/fileapi/file_system_dir_url_request_job_unittest.cc +++ b/webkit/fileapi/file_system_dir_url_request_job_unittest.cc @@ -88,9 +88,7 @@ class FileSystemDirURLRequestJobTest : public testing::Test { delegate_->set_quit_on_redirect(true); request_.reset(empty_context_.CreateRequest(url, delegate_.get())); job_ = new FileSystemDirURLRequestJob( - request_.get(), - empty_context_.network_delegate(), - file_system_context_.get()); + request_.get(), NULL, file_system_context_.get()); request_->Start(); ASSERT_TRUE(request_->is_pending()); // verify that we're starting async diff --git a/webkit/fileapi/file_system_url_request_job_unittest.cc b/webkit/fileapi/file_system_url_request_job_unittest.cc index 8d8bd7e..47dc311 100644 --- a/webkit/fileapi/file_system_url_request_job_unittest.cc +++ b/webkit/fileapi/file_system_url_request_job_unittest.cc @@ -108,9 +108,7 @@ class FileSystemURLRequestJobTest : public testing::Test { request_->SetExtraRequestHeaders(*headers); ASSERT_TRUE(!job_); job_ = new FileSystemURLRequestJob( - request_.get(), - empty_context_.network_delegate(), - file_system_context_.get()); + request_.get(), NULL, file_system_context_.get()); pending_job_ = job_; request_->Start(); |