summaryrefslogtreecommitdiffstats
path: root/webkit/glue/cpp_bound_class.cc
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-03 11:38:10 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-03 11:38:10 +0000
commitc4c01f7ef5c32e52abd09e6b826f82746282411f (patch)
tree3c34f4f13644d7831800b15a8206c2f50b711a7a /webkit/glue/cpp_bound_class.cc
parentab0eb293ec91e528e6f6e64474687ef07127a718 (diff)
downloadchromium_src-c4c01f7ef5c32e52abd09e6b826f82746282411f.zip
chromium_src-c4c01f7ef5c32e52abd09e6b826f82746282411f.tar.gz
chromium_src-c4c01f7ef5c32e52abd09e6b826f82746282411f.tar.bz2
Cleanup in webkit/glue/
- make more methods const - remove unneeded #includes BUG=7210 Review URL: http://codereview.chromium.org/19535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9080 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/cpp_bound_class.cc')
-rw-r--r--webkit/glue/cpp_bound_class.cc44
1 files changed, 22 insertions, 22 deletions
diff --git a/webkit/glue/cpp_bound_class.cc b/webkit/glue/cpp_bound_class.cc
index 3abb406..23ef80a 100644
--- a/webkit/glue/cpp_bound_class.cc
+++ b/webkit/glue/cpp_bound_class.cc
@@ -44,7 +44,7 @@ struct CppNPObject {
//
// An NPClass associates static functions of CppNPObject with the
- // function pointers used by the JS runtime.
+ // function pointers used by the JS runtime.
static NPClass np_class_;
// Allocate a new NPObject with the specified class.
@@ -64,21 +64,21 @@ struct CppNPObject {
// If the given method is exposed by the C++ class associated with this
// NPObject, invokes it with the given args and returns a result. Otherwise,
// returns "undefined" (in the JavaScript sense). Called by the JS runtime.
- static bool invoke(NPObject *obj, NPIdentifier ident,
- const NPVariant *args, uint32_t arg_count,
+ static bool invoke(NPObject *obj, NPIdentifier ident,
+ const NPVariant *args, uint32_t arg_count,
NPVariant *result);
// If the given property is exposed by the C++ class associated with this
// NPObject, returns its value. Otherwise, returns "undefined" (in the
// JavaScript sense). Called by the JS runtime.
- static bool getProperty(NPObject *obj, NPIdentifier ident,
+ static bool getProperty(NPObject *obj, NPIdentifier ident,
NPVariant *result);
// If the given property is exposed by the C++ class associated with this
- // NPObject, sets its value. Otherwise, does nothing. Called by the JS
+ // NPObject, sets its value. Otherwise, does nothing. Called by the JS
// runtime.
- static bool setProperty(NPObject *obj, NPIdentifier ident,
- const NPVariant *value);
+ static bool setProperty(NPObject *obj, NPIdentifier ident,
+ const NPVariant *value);
};
// Build CppNPObject's static function pointers into an NPClass, for use
@@ -109,33 +109,33 @@ NPClass CppNPObject::np_class_ = {
delete obj;
}
-/* static */ bool CppNPObject::hasMethod(NPObject* np_obj,
+/* static */ bool CppNPObject::hasMethod(NPObject* np_obj,
NPIdentifier ident) {
CppNPObject* obj = reinterpret_cast<CppNPObject*>(np_obj);
return obj->bound_class->HasMethod(ident);
}
-/* static */ bool CppNPObject::hasProperty(NPObject* np_obj,
+/* static */ bool CppNPObject::hasProperty(NPObject* np_obj,
NPIdentifier ident) {
CppNPObject* obj = reinterpret_cast<CppNPObject*>(np_obj);
return obj->bound_class->HasProperty(ident);
}
-/* static */ bool CppNPObject::invoke(NPObject* np_obj, NPIdentifier ident,
- const NPVariant* args, uint32_t arg_count,
+/* static */ bool CppNPObject::invoke(NPObject* np_obj, NPIdentifier ident,
+ const NPVariant* args, uint32_t arg_count,
NPVariant* result) {
CppNPObject* obj = reinterpret_cast<CppNPObject*>(np_obj);
return obj->bound_class->Invoke(ident, args, arg_count, result);
}
-/* static */ bool CppNPObject::getProperty(NPObject* np_obj,
- NPIdentifier ident,
+/* static */ bool CppNPObject::getProperty(NPObject* np_obj,
+ NPIdentifier ident,
NPVariant* result) {
CppNPObject* obj = reinterpret_cast<CppNPObject*>(np_obj);
return obj->bound_class->GetProperty(ident, result);
}
-/* static */ bool CppNPObject::setProperty(NPObject* np_obj,
+/* static */ bool CppNPObject::setProperty(NPObject* np_obj,
NPIdentifier ident,
const NPVariant* value) {
CppNPObject* obj = reinterpret_cast<CppNPObject*>(np_obj);
@@ -147,7 +147,7 @@ CppBoundClass::~CppBoundClass() {
delete i->second;
// Unregister objects we created and bound to a frame.
- for (BoundObjectList::iterator i = bound_objects_.begin();
+ for (BoundObjectList::iterator i = bound_objects_.begin();
i != bound_objects_.end(); ++i) {
#if USE(V8)
_NPN_UnregisterObject(*i);
@@ -156,17 +156,17 @@ CppBoundClass::~CppBoundClass() {
}
}
-bool CppBoundClass::HasMethod(NPIdentifier ident) {
+bool CppBoundClass::HasMethod(NPIdentifier ident) const {
return (methods_.find(ident) != methods_.end());
}
-bool CppBoundClass::HasProperty(NPIdentifier ident) {
+bool CppBoundClass::HasProperty(NPIdentifier ident) const {
return (properties_.find(ident) != properties_.end());
}
-bool CppBoundClass::Invoke(NPIdentifier ident,
+bool CppBoundClass::Invoke(NPIdentifier ident,
const NPVariant* args,
- size_t arg_count,
+ size_t arg_count,
NPVariant* result) {
MethodList::const_iterator method = methods_.find(ident);
Callback* callback;
@@ -193,7 +193,7 @@ bool CppBoundClass::Invoke(NPIdentifier ident,
return true;
}
-bool CppBoundClass::GetProperty(NPIdentifier ident, NPVariant* result) {
+bool CppBoundClass::GetProperty(NPIdentifier ident, NPVariant* result) const {
PropertyList::const_iterator prop = properties_.find(ident);
if (prop == properties_.end()) {
VOID_TO_NPVARIANT(*result);
@@ -230,10 +230,10 @@ void CppBoundClass::BindProperty(std::string name, CppVariant* prop) {
properties_[ident] = prop;
}
-bool CppBoundClass::IsMethodRegistered(std::string name) {
+bool CppBoundClass::IsMethodRegistered(std::string name) const {
// NPUTF8 is a typedef for char, so this cast is safe.
NPIdentifier ident = NPN_GetStringIdentifier((const NPUTF8*)name.c_str());
- MethodList::iterator callback = methods_.find(ident);
+ MethodList::const_iterator callback = methods_.find(ident);
return (callback != methods_.end());
}