diff options
| author | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-12 14:31:04 +0000 |
|---|---|---|
| committer | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-12 14:31:04 +0000 |
| commit | 822cfc93fe52974b904b7f184c5448dee5d281c5 (patch) | |
| tree | 40110b04644a38de5663673110262f45c711e3b4 /webkit/glue/plugins/webplugin_delegate_impl_gtk.cc | |
| parent | b23d4d836691b1d5d4df0797ed703ea21328542f (diff) | |
| download | chromium_src-822cfc93fe52974b904b7f184c5448dee5d281c5.zip chromium_src-822cfc93fe52974b904b7f184c5448dee5d281c5.tar.gz chromium_src-822cfc93fe52974b904b7f184c5448dee5d281c5.tar.bz2 | |
Match Firefox by not calling SetWindow(NULL) on plugin destruction.
This matches the behavior of Firefox on Windows and Linux. This change is especially important for plugin compatability on Linux. This also nicely removes a quirk mode.
Review URL: http://codereview.chromium.org/21290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9653 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/plugins/webplugin_delegate_impl_gtk.cc')
| -rw-r--r-- | webkit/glue/plugins/webplugin_delegate_impl_gtk.cc | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc index 58207c6..58d853e 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc +++ b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc @@ -132,15 +132,6 @@ void WebPluginDelegateImpl::DestroyInstance() { // instance uses the helper to do the download. instance_->CloseStreams(); - // TODO(evanm): I played with this for quite a while but couldn't - // figure out a way to make Flash not crash unless I didn't call - // NPP_SetWindow. Perhaps it just should be marked with the quirk - // that wraps the NPP_SetWindow call. - // window_.window = NULL; - // if (!(quirks_ & PLUGIN_QUIRK_DONT_SET_NULL_WINDOW_HANDLE_ON_DESTROY)) { - // instance_->NPP_SetWindow(&window_); - // } - instance_->NPP_Destroy(); instance_->set_web_plugin(NULL); |