diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-27 20:33:02 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-27 20:33:02 +0000 |
| commit | 1647ac8f2c5de0809eb4e78f1902fba19dbb7c53 (patch) | |
| tree | b2e3654f0c51b82f83c2b52ff0b020d1339a4615 /webkit/plugins/ppapi/plugin_delegate.h | |
| parent | fd42ac30f127624def51d949e21f9776b0e6d257 (diff) | |
| download | chromium_src-1647ac8f2c5de0809eb4e78f1902fba19dbb7c53.zip chromium_src-1647ac8f2c5de0809eb4e78f1902fba19dbb7c53.tar.gz chromium_src-1647ac8f2c5de0809eb4e78f1902fba19dbb7c53.tar.bz2 | |
Don't use crashed plugins when instantiating new ones. Before, when a plugin
crashed and was still referenced by a plugin in the same renderer, it would try
to re-use the crashed one, which obviously doesn't work very well. This change
removes crashed plugins from the renderer's list.
TEST=Manual: instantiate two tabs sharing the same renderer using a plugin,
kill the plugin, then reload one of the tabs.
BUG=none
Review URL: http://codereview.chromium.org/6594036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76194 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/plugins/ppapi/plugin_delegate.h')
| -rw-r--r-- | webkit/plugins/ppapi/plugin_delegate.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/webkit/plugins/ppapi/plugin_delegate.h b/webkit/plugins/ppapi/plugin_delegate.h index 72d5c9b..3aead21 100644 --- a/webkit/plugins/ppapi/plugin_delegate.h +++ b/webkit/plugins/ppapi/plugin_delegate.h @@ -85,10 +85,12 @@ class PluginDelegate { // have PluginDelegates). class ModuleLifetime { public: - // Notification that the given plugin object has been deleted. This is - // called from the module's destructor, so you should not dereference the - // given pointer. - virtual void PluginModuleDestroyed(PluginModule* destroyed_module) = 0; + // Notification that the given plugin object is no longer usable. It either + // indicates the module was deleted, or that it has crashed. + // + // This can be called from the module's destructor, so you should not + // dereference the given pointer. + virtual void PluginModuleDead(PluginModule* dead_module) = 0; }; // This class is implemented by the PluginDelegate implementation and is |