summaryrefslogtreecommitdiffstats
path: root/webkit/plugins/ppapi/ppb_var_impl.cc
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-22 22:15:58 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-22 22:15:58 +0000
commit28cfaed056451113a72ce00603848f4a6dd616bb (patch)
treec5de865eb7de9ea487b9af79dac9c9d363ba2876 /webkit/plugins/ppapi/ppb_var_impl.cc
parentbacf470d2cd46c0d3b145675e471ab9c6976cee8 (diff)
downloadchromium_src-28cfaed056451113a72ce00603848f4a6dd616bb.zip
chromium_src-28cfaed056451113a72ce00603848f4a6dd616bb.tar.gz
chromium_src-28cfaed056451113a72ce00603848f4a6dd616bb.tar.bz2
Don't use a scoped_refptr for StringVar::FromPPVar
This was leftover from a previous design where I thought it would be necessary. It turns out it just made the code ugly and did unnecessary refcounting. Review URL: http://codereview.chromium.org/7621054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97751 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/plugins/ppapi/ppb_var_impl.cc')
-rw-r--r--webkit/plugins/ppapi/ppb_var_impl.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/webkit/plugins/ppapi/ppb_var_impl.cc b/webkit/plugins/ppapi/ppb_var_impl.cc
index 160b972..384d449 100644
--- a/webkit/plugins/ppapi/ppb_var_impl.cc
+++ b/webkit/plugins/ppapi/ppb_var_impl.cc
@@ -68,7 +68,7 @@ bool PPVarToNPVariantNoCopy(PP_Var var, NPVariant* result) {
DOUBLE_TO_NPVARIANT(var.value.as_double, *result);
break;
case PP_VARTYPE_STRING: {
- scoped_refptr<StringVar> string(StringVar::FromPPVar(var));
+ StringVar* string = StringVar::FromPPVar(var);
if (!string) {
VOID_TO_NPVARIANT(*result);
return false;
@@ -182,7 +182,7 @@ PP_Var VarFromUtf8(PP_Module module, const char* data, uint32_t len) {
}
const char* VarToUtf8(PP_Var var, uint32_t* len) {
- scoped_refptr<StringVar> str(StringVar::FromPPVar(var));
+ StringVar* str = StringVar::FromPPVar(var);
if (!str) {
*len = 0;
return NULL;