Clean-up inline members of nested classes (webkit/)

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10829258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150912 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 20 insertions, 11 deletions

diff --git a/webkit/quota/quota_manager.cc b/webkit/quota/quota_manager.cc
index 730ec8d..0028cd3 100644
--- a/webkit/quota/quota_manager.cc
+++ b/webkit/quota/quota_manager.cc
@@ -1341,6 +1341,13 @@ QuotaManager::~QuotaManager() {
     db_thread_->DeleteSoon(FROM_HERE, database_.release());
 }
 
+QuotaManager::EvictionContext::EvictionContext()
+    : evicted_type(kStorageTypeUnknown) {
+}
+
+QuotaManager::EvictionContext::~EvictionContext() {
+}
+
 void QuotaManager::LazyInitialize() {
   DCHECK(io_thread_->BelongsToCurrentThread());
   if (database_.get()) {
diff --git a/webkit/quota/quota_manager.h b/webkit/quota/quota_manager.h
index 86e7381..6390b73 100644
--- a/webkit/quota/quota_manager.h
+++ b/webkit/quota/quota_manager.h
@@ -253,8 +253,8 @@ class QuotaManager : public QuotaTaskObserver,
       DumpOriginInfoTableCallback;
 
   struct EvictionContext {
-    EvictionContext() : evicted_type(kStorageTypeUnknown) {}
-    virtual ~EvictionContext() {}
+    EvictionContext();
+    virtual ~EvictionContext();
     GURL evicted_origin;
     StorageType evicted_type;
 
diff --git a/webkit/quota/quota_temporary_storage_evictor.cc b/webkit/quota/quota_temporary_storage_evictor.cc
index 689db4d..452bb4f 100644
--- a/webkit/quota/quota_temporary_storage_evictor.cc
+++ b/webkit/quota/quota_temporary_storage_evictor.cc
@@ -34,6 +34,16 @@ namespace quota {
 const int QuotaTemporaryStorageEvictor::
     kMinAvailableDiskSpaceToStartEvictionNotSpecified = -1;
 
+QuotaTemporaryStorageEvictor::EvictionRoundStatistics::EvictionRoundStatistics()
+    : in_round(false),
+      is_initialized(false),
+      usage_overage_at_round(-1),
+      diskspace_shortage_at_round(-1),
+      usage_on_beginning_of_round(-1),
+      usage_on_end_of_round(-1),
+      num_evicted_origins_in_round(0) {
+}
+
 QuotaTemporaryStorageEvictor::QuotaTemporaryStorageEvictor(
     QuotaEvictionHandler* quota_eviction_handler,
     int64 interval_ms)
diff --git a/webkit/quota/quota_temporary_storage_evictor.h b/webkit/quota/quota_temporary_storage_evictor.h
index 2205f66..d526a70 100644
--- a/webkit/quota/quota_temporary_storage_evictor.h
+++ b/webkit/quota/quota_temporary_storage_evictor.h
@@ -46,15 +46,7 @@ class QuotaTemporaryStorageEvictor : public base::NonThreadSafe {
   };
 
   struct EvictionRoundStatistics {
-    EvictionRoundStatistics()
-        : in_round(false),
-          is_initialized(false),
-          usage_overage_at_round(-1),
-          diskspace_shortage_at_round(-1),
-          usage_on_beginning_of_round(-1),
-          usage_on_end_of_round(-1),
-          num_evicted_origins_in_round(0) {
-    }
+    EvictionRoundStatistics();
 
     bool in_round;
     bool is_initialized;