diff options
| author | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-15 23:10:08 +0000 |
|---|---|---|
| committer | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-15 23:10:08 +0000 |
| commit | 5c84b70992f1510c1fb5b15932c7e21e43e95574 (patch) | |
| tree | 2b5de293b7c0e1c1a0a0f0ab62989ddfab1a0012 /webkit/tools/layout_tests/layout_package | |
| parent | 8cfc21f751e337584e2b60f2401e90a127fcc24e (diff) | |
| download | chromium_src-5c84b70992f1510c1fb5b15932c7e21e43e95574.zip chromium_src-5c84b70992f1510c1fb5b15932c7e21e43e95574.tar.gz chromium_src-5c84b70992f1510c1fb5b15932c7e21e43e95574.tar.bz2 | |
Fix removing of entries in the JSON that pass all runs and have
a max (floored) run time below MIN_TIME (1 second). In the last patch
I tested that tests with all passes and run time above MIN_TIME didn't
get stripped.
Now I've confirmed both directions work.
The problem is that the "key" argument to max is a python 2.5 feature
that was failing silently because it considered it as an optional
second argument.
Review URL: http://codereview.chromium.org/271110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29205 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools/layout_tests/layout_package')
| -rw-r--r-- | webkit/tools/layout_tests/layout_package/json_results_generator.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/webkit/tools/layout_tests/layout_package/json_results_generator.py b/webkit/tools/layout_tests/layout_package/json_results_generator.py index 5cd0c95..e88957f 100644 --- a/webkit/tools/layout_tests/layout_package/json_results_generator.py +++ b/webkit/tools/layout_tests/layout_package/json_results_generator.py @@ -414,7 +414,7 @@ class JSONResultsGenerator: is_all_pass = self._IsResultsAllOfType(test[self.RESULTS], self.PASS_RESULT) is_all_no_data = self._IsResultsAllOfType(test[self.RESULTS], self.NO_DATA_RESULT) - max_time = max(test[self.TIMES], lambda x, y : cmp(x[1], y[1])) + max_time = max([time[1] for time in test[self.TIMES]]) # Remove all passes/no-data from the results to reduce noise and filesize. # If a test passes every run, but takes > MIN_TIME to run, don't throw away |