diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
| commit | bd635c097dfc689674d6b21c006850a7b07f23f4 (patch) | |
| tree | b9c8bdf9edc379e288c14f64e063e29efe7635c8 /webkit | |
| parent | 19dc5d7922dc07b61c037ebbcc86f20dad27eab2 (diff) | |
| download | chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.zip chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.gz chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.bz2 | |
Enable warning 4389 as an error on windows builds. This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/default_plugin/plugin_database_handler.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/webkit/default_plugin/plugin_database_handler.cc b/webkit/default_plugin/plugin_database_handler.cc index d35fdb1..3aeff63 100644 --- a/webkit/default_plugin/plugin_database_handler.cc +++ b/webkit/default_plugin/plugin_database_handler.cc @@ -144,13 +144,13 @@ int32 PluginDatabaseHandler::Write(NPStream* stream, int32 offset, } } - unsigned long bytes_written = 0; + DWORD bytes_written = 0; if (0 == lstrcmpiA(stream->url, plugin_finder_url_.c_str())) { DCHECK(plugin_downloads_file_ != INVALID_HANDLE_VALUE); WriteFile(plugin_downloads_file_, buffer, buffer_length, &bytes_written, NULL); - DCHECK(buffer_length == bytes_written); + DCHECK_EQ(buffer_length, static_cast<int32>(bytes_written)); } return bytes_written; } |