diff options
author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-06 03:14:30 +0000 |
---|---|---|
committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-06 03:14:30 +0000 |
commit | f2ebbf06167ad4ff8cb23109b3652c8c4b7ff5f7 (patch) | |
tree | 313e8a638cf92f3106aac2abce46841897012d41 /webkit | |
parent | c6cc03e309be697cfa1d5ca77960ae71caac538c (diff) | |
download | chromium_src-f2ebbf06167ad4ff8cb23109b3652c8c4b7ff5f7.zip chromium_src-f2ebbf06167ad4ff8cb23109b3652c8c4b7ff5f7.tar.gz chromium_src-f2ebbf06167ad4ff8cb23109b3652c8c4b7ff5f7.tar.bz2 |
Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/9997007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131088 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r-- | webkit/dom_storage/dom_storage_task_runner.h | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/webkit/dom_storage/dom_storage_task_runner.h b/webkit/dom_storage/dom_storage_task_runner.h index c7b5fd5..8cb0e79 100644 --- a/webkit/dom_storage/dom_storage_task_runner.h +++ b/webkit/dom_storage/dom_storage_task_runner.h @@ -55,6 +55,9 @@ class DomStorageTaskRunner : public base::TaskRunner { const tracked_objects::Location& from_here, const base::Closure& task, int64 delay_ms) OVERRIDE; + + protected: + virtual ~DomStorageTaskRunner() {} }; // A derived class used in chromium that utilizes a SequenceWorkerPool @@ -78,8 +81,10 @@ class DomStorageWorkerPoolTaskRunner : public DomStorageTaskRunner { SequenceID sequence_id, const base::Closure& task) OVERRIDE; - private: + protected: virtual ~DomStorageWorkerPoolTaskRunner(); + + private: const scoped_refptr<base::MessageLoopProxy> message_loop_; const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_; base::SequencedWorkerPool::SequenceToken primary_sequence_token_; @@ -105,8 +110,10 @@ class MockDomStorageTaskRunner : public DomStorageTaskRunner { SequenceID sequence_id, const base::Closure& task) OVERRIDE; - private: + protected: virtual ~MockDomStorageTaskRunner(); + + private: const scoped_refptr<base::MessageLoopProxy> message_loop_; }; |