diff options
author | thakis <thakis@chromium.org> | 2015-12-09 16:36:25 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-10 00:37:07 +0000 |
commit | 9230c1d2dc9af55c573c54b64780a75cf418d896 (patch) | |
tree | 42d7eaf8c2d6952b6fce4222988d99a382f92f58 /win8 | |
parent | defcc73ab06beb476b98403f8d5d4a4b065fd97b (diff) | |
download | chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.zip chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.tar.gz chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.tar.bz2 |
clang/win: Let some chromium_code targets build with -Wextra.
To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled. This fixes
-Wextra warnings in about 14k of 31k build steps.
Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.
(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)
BUG=567877
TBR=content/common/sandbox
Review URL: https://codereview.chromium.org/1507413003
Cr-Commit-Position: refs/heads/master@{#364232}
Diffstat (limited to 'win8')
-rw-r--r-- | win8/delegate_execute/delegate_execute_util_unittest.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/win8/delegate_execute/delegate_execute_util_unittest.cc b/win8/delegate_execute/delegate_execute_util_unittest.cc index 63a5075..47916fd 100644 --- a/win8/delegate_execute/delegate_execute_util_unittest.cc +++ b/win8/delegate_execute/delegate_execute_util_unittest.cc @@ -47,16 +47,16 @@ TEST(DelegateExecuteUtil, MakeChromeCommandLineTest) { this_exe, delegate_execute::CommandLineFromParameters(NULL), base::string16()); - EXPECT_EQ(1, cl.argv().size()); + EXPECT_EQ(1u, cl.argv().size()); EXPECT_EQ(this_exe.value(), cl.GetProgram().value()); // Empty params with arg contains the arg. cl = delegate_execute::MakeChromeCommandLine( this_exe, delegate_execute::CommandLineFromParameters(NULL), base::string16(kSomeArgument)); - EXPECT_EQ(2, cl.argv().size()); + EXPECT_EQ(2u, cl.argv().size()); EXPECT_EQ(this_exe.value(), cl.GetProgram().value()); - EXPECT_EQ(1, cl.GetArgs().size()); + EXPECT_EQ(1u, cl.GetArgs().size()); EXPECT_EQ(base::string16(kSomeArgument), cl.GetArgs()[0]); // Params with switchs and args plus arg contains the arg. @@ -66,11 +66,11 @@ TEST(DelegateExecuteUtil, MakeChromeCommandLineTest) { base::ASCIIToUTF16(kSomeSwitch).c_str(), kOtherArgument).c_str()), base::string16(kSomeArgument)); - EXPECT_EQ(5, cl.argv().size()); + EXPECT_EQ(5u, cl.argv().size()); EXPECT_EQ(this_exe.value(), cl.GetProgram().value()); EXPECT_TRUE(cl.HasSwitch(kSomeSwitch)); base::CommandLine::StringVector args(cl.GetArgs()); - EXPECT_EQ(2, args.size()); + EXPECT_EQ(2u, args.size()); EXPECT_NE( args.end(), std::find(args.begin(), args.end(), base::string16(kOtherArgument))); |