diff options
| author | brettw <brettw@chromium.org> | 2015-12-22 10:16:02 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-22 18:17:13 +0000 |
| commit | d1ceb87cd865e2777059c5afe031dae57c8e7914 (patch) | |
| tree | d1ddd4fe2162055875166429fbb493b572f77345 /win8 | |
| parent | 22437c690d92b7440913d190bf5474785ccd73ec (diff) | |
| download | chromium_src-d1ceb87cd865e2777059c5afe031dae57c8e7914.zip chromium_src-d1ceb87cd865e2777059c5afe031dae57c8e7914.tar.gz chromium_src-d1ceb87cd865e2777059c5afe031dae57c8e7914.tar.bz2 | |
Split GN installer_util into one that has no strings.
After a lot of study, the GYP build of chrome.exe is smaller partially because it doesn't include all of these generated strings. The strings are not needed by chrome.exe, but there is no sub-part of chrome/installer/util that can be factored such that the part that chrome.exe uses does not depend on the strings.
This patch makes two targets, one for if you want the strings, and one for if you don't. This is rather precarious so I named the non-string-including target in a very detailed way. The result is the final link matches GYP in this respect, and saves about 200KB on chrome.exe
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1534903002
Cr-Commit-Position: refs/heads/master@{#366618}
Diffstat (limited to 'win8')
| -rw-r--r-- | win8/delegate_execute/BUILD.gn | 2 | ||||
| -rw-r--r-- | win8/metro_driver/BUILD.gn | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/win8/delegate_execute/BUILD.gn b/win8/delegate_execute/BUILD.gn index 3f40982..d21d73c 100644 --- a/win8/delegate_execute/BUILD.gn +++ b/win8/delegate_execute/BUILD.gn @@ -44,7 +44,7 @@ source_set("lib") { "//base", "//breakpad:breakpad_handler", "//chrome/common:constants", - "//chrome/installer/util", + "//chrome/installer/util:with_no_strings_some_things_wont_work", "//ui/base", "//ui/gfx", "//ui/gfx/geometry", diff --git a/win8/metro_driver/BUILD.gn b/win8/metro_driver/BUILD.gn index 519259e..2cf2dd9 100644 --- a/win8/metro_driver/BUILD.gn +++ b/win8/metro_driver/BUILD.gn @@ -23,7 +23,7 @@ shared_library("metro_driver") { ":version_resources", "//base", "//chrome/common:constants", - "//chrome/installer/util", + "//chrome/installer/util:with_no_strings_some_things_wont_work", "//crypto", "//ipc", "//sandbox", |