diff options
| -rw-r--r-- | base/base.gypi | 2 | ||||
| -rw-r--r-- | base/metrics/nacl_histogram.cc | 23 | ||||
| -rw-r--r-- | base/metrics/nacl_histogram.h | 31 | ||||
| -rw-r--r-- | chrome/browser/nacl_host/nacl_process_host.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/tabs/default_tab_handler.cc | 3 |
5 files changed, 0 insertions, 61 deletions
diff --git a/base/base.gypi b/base/base.gypi index 5a87c66..49e931a 100644 --- a/base/base.gypi +++ b/base/base.gypi @@ -163,8 +163,6 @@ 'message_pump_win.h', 'metrics/histogram.cc', 'metrics/histogram.h', - 'metrics/nacl_histogram.cc', - 'metrics/nacl_histogram.h', 'metrics/stats_counters.cc', 'metrics/stats_counters.h', 'metrics/stats_table.cc', diff --git a/base/metrics/nacl_histogram.cc b/base/metrics/nacl_histogram.cc deleted file mode 100644 index c89e646..0000000 --- a/base/metrics/nacl_histogram.cc +++ /dev/null @@ -1,23 +0,0 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -// nacl_histogram provides an enum and defines a macro that uses definitions -// from histogram.h. Note that a histogram is an object that aggregates -// statistics, and can summarize them in various forms, including ASCII -// graphical, HTML, and numerically. -// nacl_histogram information is used to compare how many times a native -// client module has been loaded, compared to the number of chrome starts -// and number of new tabs created. - - -#include "base/metrics/histogram.h" -#include "base/metrics/nacl_histogram.h" - -// To log histogram data about NaCl.Startups, call this function with -// a NaClHistogramValue passed in as |hvalue| -void UmaNaclHistogramEnumeration(NaClHistogramValue histogram_value) { - UMA_HISTOGRAM_ENUMERATION("NaCl.Startups", histogram_value, - NACL_MAX_HISTOGRAM); -} - diff --git a/base/metrics/nacl_histogram.h b/base/metrics/nacl_histogram.h deleted file mode 100644 index 6147047..0000000 --- a/base/metrics/nacl_histogram.h +++ /dev/null @@ -1,31 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -// nacl_histogram provides an enum and defines a macro that uses definitions -// from histogram.h. Note that a histogram is an object that aggregates -// statistics, and can summarize them in various forms, including ASCII -// graphical, HTML, and numerically. -// nacl_histogram information is used to compare how many times a native -// client module has been loaded, compared to the number of chrome starts -// and number of new tabs created. - -#ifndef BASE_METRICS_NACL_HISTOGRAM_H_ -#define BASE_METRICS_NACL_HISTOGRAM_H_ -#pragma once - -#include "base/base_api.h" - -enum NaClHistogramValue { - FIRST_TAB_NACL_BASELINE, // First tab created - a baseline for NaCl starts. - NEW_TAB_NACL_BASELINE, // New tab created -- a baseline for NaCl starts. - NACL_STARTED, // NaCl process started - NACL_MAX_HISTOGRAM // DO NOT USE -- used by histogram for max bound. -}; - -// To log histogram data about NaCl.Startups, call this macro with -// a NaClHistogramValue passed in as |histogram_value| -BASE_API void UmaNaclHistogramEnumeration(NaClHistogramValue histogram_value); - -#endif // BASE_METRICS_NACL_HISTOGRAM_H_ - diff --git a/chrome/browser/nacl_host/nacl_process_host.cc b/chrome/browser/nacl_host/nacl_process_host.cc index 70891ec..0733051 100644 --- a/chrome/browser/nacl_host/nacl_process_host.cc +++ b/chrome/browser/nacl_host/nacl_process_host.cc @@ -11,7 +11,6 @@ #endif #include "base/command_line.h" -#include "base/metrics/nacl_histogram.h" #include "base/path_service.h" #include "base/utf_string_conversions.h" #include "base/win/windows_version.h" @@ -128,7 +127,6 @@ bool NaClProcessHost::Launch( if (!LaunchSelLdr()) { return false; } - UmaNaclHistogramEnumeration(NACL_STARTED); chrome_render_message_filter_ = chrome_render_message_filter; reply_msg_ = reply_msg; diff --git a/chrome/browser/tabs/default_tab_handler.cc b/chrome/browser/tabs/default_tab_handler.cc index 57eec12..296b298 100644 --- a/chrome/browser/tabs/default_tab_handler.cc +++ b/chrome/browser/tabs/default_tab_handler.cc @@ -2,7 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "base/metrics/nacl_histogram.h" #include "chrome/browser/tabs/default_tab_handler.h" #include "chrome/browser/tabs/tab_strip_model.h" #include "chrome/browser/ui/browser.h" @@ -14,7 +13,6 @@ DefaultTabHandler::DefaultTabHandler(TabHandlerDelegate* delegate) : delegate_(delegate), ALLOW_THIS_IN_INITIALIZER_LIST( model_(new TabStripModel(this, delegate->GetProfile()))) { - UmaNaclHistogramEnumeration(FIRST_TAB_NACL_BASELINE); model_->AddObserver(this); } @@ -35,7 +33,6 @@ TabStripModel* DefaultTabHandler::GetTabStripModel() const { // DefaultTabHandler, TabStripModelDelegate implementation: TabContentsWrapper* DefaultTabHandler::AddBlankTab(bool foreground) { - UmaNaclHistogramEnumeration(NEW_TAB_NACL_BASELINE); return delegate_->AsBrowser()->AddBlankTab(foreground); } |