summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--chrome/browser/ui/app_list/extension_app_item.cc1
-rw-r--r--chrome/browser/ui/app_list/search/app_result.cc1
-rw-r--r--chrome/browser/ui/ash/volume_controller_chromeos.h1
-rw-r--r--chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm1
-rw-r--r--extensions/browser/app_window/app_window.cc1
-rw-r--r--extensions/browser/guest_view/web_view/web_view_guest.cc1
-rw-r--r--extensions/common/extension.cc3
-rw-r--r--extensions/common/extension.h12
-rw-r--r--extensions/common/permissions/permissions_data.cc1
9 files changed, 10 insertions, 12 deletions
diff --git a/chrome/browser/ui/app_list/extension_app_item.cc b/chrome/browser/ui/app_list/extension_app_item.cc
index fa49b8c..e5ed3ec 100644
--- a/chrome/browser/ui/app_list/extension_app_item.cc
+++ b/chrome/browser/ui/app_list/extension_app_item.cc
@@ -28,6 +28,7 @@
#include "grit/theme_resources.h"
#include "sync/api/string_ordinal.h"
#include "ui/base/resource/resource_bundle.h"
+#include "ui/events/event_constants.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/image/canvas_image_source.h"
diff --git a/chrome/browser/ui/app_list/search/app_result.cc b/chrome/browser/ui/app_list/search/app_result.cc
index 5073e21..7b4853c 100644
--- a/chrome/browser/ui/app_list/search/app_result.cc
+++ b/chrome/browser/ui/app_list/search/app_result.cc
@@ -21,6 +21,7 @@
#include "extensions/common/extension_icon_set.h"
#include "extensions/common/manifest_handlers/icons_handler.h"
#include "ui/app_list/app_list_switches.h"
+#include "ui/events/event_constants.h"
#include "ui/gfx/color_utils.h"
#include "ui/gfx/image/image_skia_operations.h"
diff --git a/chrome/browser/ui/ash/volume_controller_chromeos.h b/chrome/browser/ui/ash/volume_controller_chromeos.h
index f51540c..9740690 100644
--- a/chrome/browser/ui/ash/volume_controller_chromeos.h
+++ b/chrome/browser/ui/ash/volume_controller_chromeos.h
@@ -11,6 +11,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "chromeos/audio/cras_audio_handler.h"
+#include "ui/base/accelerators/accelerator.h"
// A class which controls volume when F8-10 or a multimedia key for volume is
// pressed.
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index 8249646..8554957 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -71,6 +71,7 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/l10n/l10n_util_mac.h"
#include "ui/base/resource/resource_bundle.h"
+#include "ui/events/keycodes/keyboard_codes.h"
#include "ui/gfx/image/image.h"
#include "ui/gfx/text_elider.h"
#include "ui/native_theme/common_theme.h"
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index 5881f30..11a3dc7 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -53,6 +53,7 @@
#include "extensions/grit/extensions_browser_resources.h"
#include "third_party/skia/include/core/SkRegion.h"
#include "ui/base/resource/resource_bundle.h"
+#include "ui/events/keycodes/keyboard_codes.h"
#include "ui/gfx/screen.h"
#if !defined(OS_MACOSX)
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index d692e02..db585b3 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -60,6 +60,7 @@
#include "net/base/escape.h"
#include "net/base/net_errors.h"
#include "ui/base/models/simple_menu_model.h"
+#include "ui/events/keycodes/keyboard_codes.h"
#include "url/url_constants.h"
using base::UserMetricsAction;
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc
index 3f7e43b..227cb7e 100644
--- a/extensions/common/extension.cc
+++ b/extensions/common/extension.cc
@@ -6,6 +6,7 @@
#include <stddef.h>
+#include <algorithm>
#include <utility>
#include "base/base64.h"
@@ -383,7 +384,7 @@ Extension::ManifestData* Extension::GetManifestData(const std::string& key)
void Extension::SetManifestData(const std::string& key,
Extension::ManifestData* data) {
DCHECK(!finished_parsing_manifest_ && thread_checker_.CalledOnValidThread());
- manifest_data_[key] = linked_ptr<ManifestData>(data);
+ manifest_data_[key] = scoped_ptr<ManifestData>(data);
}
Manifest::Location Extension::location() const {
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index df06d0f..13a86b7 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -5,27 +5,21 @@
#ifndef EXTENSIONS_COMMON_EXTENSION_H_
#define EXTENSIONS_COMMON_EXTENSION_H_
-#include <algorithm>
-#include <iosfwd>
#include <map>
#include <set>
#include <string>
-#include <utility>
#include <vector>
-#include "base/containers/hash_tables.h"
#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/memory/linked_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
-#include "base/synchronization/lock.h"
#include "base/threading/thread_checker.h"
#include "extensions/common/extension_resource.h"
#include "extensions/common/install_warning.h"
#include "extensions/common/manifest.h"
#include "extensions/common/url_pattern_set.h"
-#include "ui/base/accelerators/accelerator.h"
#include "url/gurl.h"
#if !defined(ENABLE_EXTENSIONS)
@@ -55,11 +49,6 @@ typedef std::string ExtensionId;
// RuntimeData is protected by a lock.
class Extension : public base::RefCountedThreadSafe<Extension> {
public:
- struct ManifestData;
-
- typedef std::map<const std::string, linked_ptr<ManifestData> >
- ManifestDataMap;
-
enum State {
DISABLED = 0,
ENABLED,
@@ -466,6 +455,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
scoped_ptr<Manifest> manifest_;
// Stored parsed manifest data.
+ using ManifestDataMap = std::map<std::string, scoped_ptr<ManifestData>>;
ManifestDataMap manifest_data_;
// Set to true at the end of InitValue when initialization is finished.
diff --git a/extensions/common/permissions/permissions_data.cc b/extensions/common/permissions/permissions_data.cc
index d3634d35..c77c4ee 100644
--- a/extensions/common/permissions/permissions_data.cc
+++ b/extensions/common/permissions/permissions_data.cc
@@ -4,6 +4,7 @@
#include "extensions/common/permissions/permissions_data.h"
+#include <algorithm>
#include <utility>
#include "base/command_line.h"