diff options
-rw-r--r-- | cc/output/gl_renderer.cc | 4 | ||||
-rw-r--r-- | cc/resources/resource_provider.cc | 4 | ||||
-rw-r--r-- | content/common/gpu/client/gl_helper.cc | 4 | ||||
-rw-r--r-- | gpu/GLES2/gl2extchromium.h | 8 | ||||
-rwxr-xr-x | gpu/command_buffer/build_gles2_cmd_buffer.py | 4 | ||||
-rw-r--r-- | gpu/command_buffer/client/query_tracker.cc | 8 | ||||
-rw-r--r-- | gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h | 12 | ||||
-rw-r--r-- | gpu/command_buffer/service/gles2_cmd_decoder.cc | 4 | ||||
-rw-r--r-- | gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h | 4 | ||||
-rw-r--r-- | gpu/command_buffer/service/query_manager.cc | 5 | ||||
-rw-r--r-- | gpu/command_buffer/tests/gl_readback_unittests.cc | 4 | ||||
-rw-r--r-- | ui/gl/gl_bindings.h | 4 |
12 files changed, 33 insertions, 32 deletions
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc index 63d8ea8..368ae77 100644 --- a/cc/output/gl_renderer.cc +++ b/cc/output/gl_renderer.cc @@ -2348,7 +2348,7 @@ void GLRenderer::DoGetFramebufferPixels( if (is_async) { query = context_->createQueryEXT(); GLC(context_, context_->beginQueryEXT( - GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM, + GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM, query)); } @@ -2389,7 +2389,7 @@ void GLRenderer::DoGetFramebufferPixels( if (is_async) { GLC(context_, context_->endQueryEXT( - GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM)); + GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM)); SyncPointHelper::SignalQuery( context_, query, diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc index 1911d86..57a1806 100644 --- a/cc/resources/resource_provider.cc +++ b/cc/resources/resource_provider.cc @@ -1167,7 +1167,7 @@ void ResourceProvider::BeginSetPixels(ResourceId id) { if (!resource->gl_upload_query_id) resource->gl_upload_query_id = context3d->createQueryEXT(); context3d->beginQueryEXT( - GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM, + GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM, resource->gl_upload_query_id); if (allocate) { context3d->asyncTexImage2DCHROMIUM(GL_TEXTURE_2D, @@ -1190,7 +1190,7 @@ void ResourceProvider::BeginSetPixels(ResourceId id) { GL_UNSIGNED_BYTE, NULL); } - context3d->endQueryEXT(GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM); + context3d->endQueryEXT(GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM); context3d->bindBuffer(GL_PIXEL_UNPACK_TRANSFER_BUFFER_CHROMIUM, 0); } diff --git a/content/common/gpu/client/gl_helper.cc b/content/common/gpu/client/gl_helper.cc index 0a10d4a..bd5ad49 100644 --- a/content/common/gpu/client/gl_helper.cc +++ b/content/common/gpu/client/gl_helper.cc @@ -394,11 +394,11 @@ void GLHelper::CopyTextureToImpl::ReadbackAsync( GL_STREAM_READ); request->query = context_->createQueryEXT(); - context_->beginQueryEXT(GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM, + context_->beginQueryEXT(GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM, request->query); context_->readPixels(0, 0, dst_size.width(), dst_size.height(), GL_RGBA, GL_UNSIGNED_BYTE, NULL); - context_->endQueryEXT(GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM); + context_->endQueryEXT(GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM); context_->bindBuffer(GL_PIXEL_PACK_TRANSFER_BUFFER_CHROMIUM, 0); cc::SyncPointHelper::SignalQuery( context_, diff --git a/gpu/GLES2/gl2extchromium.h b/gpu/GLES2/gl2extchromium.h index 433242c..bd4d432 100644 --- a/gpu/GLES2/gl2extchromium.h +++ b/gpu/GLES2/gl2extchromium.h @@ -336,11 +336,11 @@ typedef void (GL_APIENTRYP PFNGLBINDUNIFORMLOCATIONCHROMIUMPROC) ( #ifndef GL_CHROMIUM_async_pixel_transfers #define GL_CHROMIUM_async_pixel_transfers 1 -#ifndef GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM -#define GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM 0x84F5 +#ifndef GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM +#define GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM 0x84F5 #endif -#ifndef GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM -#define GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM 0x84F6 +#ifndef GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM +#define GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM 0x84F6 #endif #endif /* GL_CHROMIUM_async_pixel_transfers */ diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py index a6f13c1..f4c7e5b 100755 --- a/gpu/command_buffer/build_gles2_cmd_buffer.py +++ b/gpu/command_buffer/build_gles2_cmd_buffer.py @@ -827,8 +827,8 @@ _ENUM_LISTS = { 'GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT', 'GL_COMMANDS_ISSUED_CHROMIUM', 'GL_LATENCY_QUERY_CHROMIUM', - 'GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM', - 'GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM', + 'GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM', + 'GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM', ], }, 'RenderBufferParameter': { diff --git a/gpu/command_buffer/client/query_tracker.cc b/gpu/command_buffer/client/query_tracker.cc index 35732bf..307b615 100644 --- a/gpu/command_buffer/client/query_tracker.cc +++ b/gpu/command_buffer/client/query_tracker.cc @@ -112,8 +112,8 @@ void QueryTracker::Query::Begin(GLES2Implementation* gl) { // tell service about id, shared memory and count gl->helper()->BeginQueryEXT(target(), id(), shm_id(), shm_offset()); break; - case GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM: - case GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM: + case GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM: + case GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM: default: // tell service about id, shared memory and count gl->helper()->BeginQueryEXT(target(), id(), shm_id(), shm_offset()); @@ -162,8 +162,8 @@ bool QueryTracker::Query::CheckResultsAvailable( result_ = std::min(info_.sync->result - client_begin_time_us_, static_cast<uint64>(0xFFFFFFFFL)); break; - case GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM: - case GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM: + case GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM: + case GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM: default: result_ = info_.sync->result; break; diff --git a/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h b/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h index 573aee9..aa24ccd 100644 --- a/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h +++ b/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h @@ -225,10 +225,10 @@ static const GLES2Util::EnumToString enum_to_string_table[] = { { 0x90F1, "GL_MULTIVIEW_EXT", }, { 0x90F0, "GL_COLOR_ATTACHMENT_EXT", }, { 0x803C, "GL_ALPHA8_OES", }, - { 0x84F5, "GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM", }, + { 0x84F5, "GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM", }, { 0x882A, "GL_DRAW_BUFFER5_NV", }, { 0x80AA, "GL_SAMPLE_COVERAGE_VALUE", }, - { 0x84F6, "GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM", }, + { 0x84F6, "GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM", }, { 0x80AB, "GL_SAMPLE_COVERAGE_INVERT", }, { 0x8FC4, "GL_SHADER_BINARY_VIV", }, { 0x882B, "GL_DRAW_BUFFER6_NV", }, @@ -1078,10 +1078,10 @@ std::string GLES2Util::GetStringQueryTarget(uint32 value) { "GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT" }, { GL_COMMANDS_ISSUED_CHROMIUM, "GL_COMMANDS_ISSUED_CHROMIUM" }, { GL_LATENCY_QUERY_CHROMIUM, "GL_LATENCY_QUERY_CHROMIUM" }, - { GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM, - "GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM" }, - { GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM, - "GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM" }, + { GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM, + "GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM" }, + { GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM, + "GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM" }, }; return GLES2Util::GetQualifiedEnumString( string_table, arraysize(string_table), value); diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc index 1cca696..aa0d7a9 100644 --- a/gpu/command_buffer/service/gles2_cmd_decoder.cc +++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc @@ -9016,8 +9016,8 @@ error::Error GLES2DecoderImpl::HandleBeginQueryEXT( switch (target) { case GL_COMMANDS_ISSUED_CHROMIUM: case GL_LATENCY_QUERY_CHROMIUM: - case GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM: - case GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM: + case GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM: + case GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM: case GL_GET_ERROR_QUERY_CHROMIUM: break; default: diff --git a/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h b/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h index b8194d9..8975d20 100644 --- a/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h +++ b/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h @@ -299,8 +299,8 @@ static const GLenum valid_query_target_table[] = { GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, GL_COMMANDS_ISSUED_CHROMIUM, GL_LATENCY_QUERY_CHROMIUM, - GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM, - GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM, + GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM, + GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM, }; static const GLenum valid_read_pixel_format_table[] = { diff --git a/gpu/command_buffer/service/query_manager.cc b/gpu/command_buffer/service/query_manager.cc index 7566099..85e273c 100644 --- a/gpu/command_buffer/service/query_manager.cc +++ b/gpu/command_buffer/service/query_manager.cc @@ -431,11 +431,12 @@ QueryManager::Query* QueryManager::CreateQuery( case GL_LATENCY_QUERY_CHROMIUM: query = new CommandLatencyQuery(this, target, shm_id, shm_offset); break; - case GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM: + case GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM: + // Currently async pixel transfer delegates only support uploads. query = new AsyncPixelTransfersCompletedQuery( this, target, shm_id, shm_offset); break; - case GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM: + case GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM: query = new AsyncReadPixelsCompletedQuery( this, target, shm_id, shm_offset); break; diff --git a/gpu/command_buffer/tests/gl_readback_unittests.cc b/gpu/command_buffer/tests/gl_readback_unittests.cc index 4ebb09a..d4b5d3d 100644 --- a/gpu/command_buffer/tests/gl_readback_unittests.cc +++ b/gpu/command_buffer/tests/gl_readback_unittests.cc @@ -64,9 +64,9 @@ TEST_F(GLReadbackTest, ReadPixelsWithPBOAndQuery) { kWidth * kHeight * kBytesPerPixel, NULL, GL_STREAM_READ); - glBeginQueryEXT(GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM, q); + glBeginQueryEXT(GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM, q); glReadPixels(0, 0, kWidth, kHeight, GL_RGBA, GL_UNSIGNED_BYTE, 0); - glEndQueryEXT(GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM); + glEndQueryEXT(GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM); glFlush(); WaitForQuery(q); diff --git a/ui/gl/gl_bindings.h b/ui/gl/gl_bindings.h index 987ec20..debb074 100644 --- a/ui/gl/gl_bindings.h +++ b/ui/gl/gl_bindings.h @@ -124,8 +124,8 @@ #define GL_LATENCY_QUERY_CHROMIUM 0x84F4 /* GL_CHROMIUM_async_pixel_transfers */ -#define GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM 0x84F5 -#define GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM 0x84F6 +#define GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM 0x84F5 +#define GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM 0x84F6 // GL_OES_texure_3D #define GL_SAMPLER_3D_OES 0x8B5F |