diff options
| -rw-r--r-- | tools/telemetry/telemetry/page/page_measurement_results.py | 1 | ||||
| -rw-r--r-- | tools/telemetry/telemetry/page/page_measurement_results_unittest.py | 8 |
2 files changed, 9 insertions, 0 deletions
diff --git a/tools/telemetry/telemetry/page/page_measurement_results.py b/tools/telemetry/telemetry/page/page_measurement_results.py index e97210a..c00c8d0 100644 --- a/tools/telemetry/telemetry/page/page_measurement_results.py +++ b/tools/telemetry/telemetry/page/page_measurement_results.py @@ -60,6 +60,7 @@ class PageMeasurementResults(page_test_results.PageTestResults): self._all_page_specific_values.append(value) def AddSummaryValue(self, value): + assert value.page is None self._ValidateValue(value) self._all_summary_values.append(value) diff --git a/tools/telemetry/telemetry/page/page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/page_measurement_results_unittest.py index 43b958f..3817880 100644 --- a/tools/telemetry/telemetry/page/page_measurement_results_unittest.py +++ b/tools/telemetry/telemetry/page/page_measurement_results_unittest.py @@ -87,6 +87,14 @@ class PageMeasurementResultsTest(unittest.TestCase): self.assertEquals('b_units', results.GetUnitsForValueName('b')) self.assertEquals('c_units', results.GetUnitsForValueName('c')) + def test_add_summary_value_with_page_specified(self): + results = NonPrintingPageMeasurementResults() + results.WillMeasurePage(self.pages[0]) + self.assertRaises( + AssertionError, + lambda: results.AddSummaryValue(scalar.ScalarValue(self.pages[0], + 'a', 'units', 3))) + def test_unit_change(self): results = NonPrintingPageMeasurementResults() results.WillMeasurePage(self.pages[0]) |