summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--chrome/installer/test/alternate_version_generator.cc4
-rw-r--r--chrome/installer/upgrade_test.gyp1
2 files changed, 3 insertions, 2 deletions
diff --git a/chrome/installer/test/alternate_version_generator.cc b/chrome/installer/test/alternate_version_generator.cc
index c0ec333..211b1e5 100644
--- a/chrome/installer/test/alternate_version_generator.cc
+++ b/chrome/installer/test/alternate_version_generator.cc
@@ -425,8 +425,8 @@ bool UpdateManifestVersion(const base::FilePath& manifest,
return false;
}
DCHECK(modified);
- return base::WriteFile(manifest, &contents[0], contents.size()) ==
- contents.size();
+ int written = base::WriteFile(manifest, &contents[0], contents.size());
+ return written != -1 && static_cast<size_t>(written) == contents.size();
}
bool IncrementNewVersion(upgrade_test::Direction direction,
diff --git a/chrome/installer/upgrade_test.gyp b/chrome/installer/upgrade_test.gyp
index 07b283e..1a05535 100644
--- a/chrome/installer/upgrade_test.gyp
+++ b/chrome/installer/upgrade_test.gyp
@@ -4,6 +4,7 @@
{
'variables': {
+ 'chromium_code': 1,
'branding_dir': '../app/theme/<(branding_path_component)',
'version_py': '<(DEPTH)/build/util/version.py',
'version_path': '../../chrome/VERSION',