diff options
| -rw-r--r-- | base/tools_sanity_unittest.cc | 8 | ||||
| -rw-r--r-- | tools/valgrind/drmemory/suppressions.txt | 10 |
2 files changed, 10 insertions, 8 deletions
diff --git a/base/tools_sanity_unittest.cc b/base/tools_sanity_unittest.cc index 779c236..e1e41a6 100644 --- a/base/tools_sanity_unittest.cc +++ b/base/tools_sanity_unittest.cc @@ -61,16 +61,8 @@ void MakeSomeErrors(char *ptr, size_t size) { ReadUninitializedValue(ptr); ReadValueOutOfArrayBoundsLeft(ptr); ReadValueOutOfArrayBoundsRight(ptr, size); - - // We execute this function only under memory checking tools - - // Valgrind on Linux and Mac, Dr. Memory on Windows. - // Currently writing values out-of-bounds makes Dr. Memory a bit crazy when - // this code is linked with /MTd, so skip these writes on Windows. - // See http://code.google.com/p/drmemory/issues/detail?id=51 -#if !defined(OS_WIN) WriteValueOutOfArrayBoundsLeft(ptr); WriteValueOutOfArrayBoundsRight(ptr, size); -#endif } } // namespace diff --git a/tools/valgrind/drmemory/suppressions.txt b/tools/valgrind/drmemory/suppressions.txt index 394bd5c..c5ac944 100644 --- a/tools/valgrind/drmemory/suppressions.txt +++ b/tools/valgrind/drmemory/suppressions.txt @@ -426,6 +426,16 @@ base_unittests.exe!*ReadValueOutOfArrayBoundsRight base_unittests.exe!*MakeSomeErrors base_unittests.exe!base::ToolsSanityTest_AccessesToNewMemory_Test::TestBody +UNADDRESSABLE ACCESS +base_unittests.exe!*WriteValueOutOfArrayBoundsLeft +base_unittests.exe!*MakeSomeErrors +base_unittests.exe!base::ToolsSanityTest_AccessesToNewMemory_Test::TestBody + +UNADDRESSABLE ACCESS +base_unittests.exe!*WriteValueOutOfArrayBoundsRight +base_unittests.exe!*MakeSomeErrors +base_unittests.exe!base::ToolsSanityTest_AccessesToNewMemory_Test::TestBody + UNINITIALIZED READ base_unittests.exe!*ReadUninitializedValue base_unittests.exe!*MakeSomeErrors |