diff options
Diffstat (limited to 'PRESUBMIT_test.py')
| -rwxr-xr-x | PRESUBMIT_test.py | 29 |
1 files changed, 28 insertions, 1 deletions
diff --git a/PRESUBMIT_test.py b/PRESUBMIT_test.py index 00997b4..872545e 100755 --- a/PRESUBMIT_test.py +++ b/PRESUBMIT_test.py @@ -12,7 +12,7 @@ import sys import unittest import PRESUBMIT -from PRESUBMIT_test_mocks import MockChange, MockFile +from PRESUBMIT_test_mocks import MockChange, MockFile, MockAffectedFile from PRESUBMIT_test_mocks import MockInputApi, MockOutputApi _TEST_DATA_DIR = 'base/test/data/presubmit' @@ -384,6 +384,33 @@ class BadExtensionsTest(unittest.TestCase): self.assertEqual({}, results) +class CheckSingletonInHeadersTest(unittest.TestCase): + def testSingletonInArbitraryHeader(self): + diff_singleton_h = ['base::subtle::AtomicWord ' + 'Singleton<Type, Traits, DifferentiatingType>::'] + diff_foo_h = ['// Singleton<Foo> in comment.', + 'friend class Singleton<Foo>'] + diff_bad_h = ['Foo* foo = Singleton<Foo>::get();'] + mock_input_api = MockInputApi() + mock_input_api.files = [MockAffectedFile('base/memory/singleton.h', + diff_singleton_h), + MockAffectedFile('foo.h', diff_foo_h), + MockAffectedFile('bad.h', diff_bad_h)] + warnings = PRESUBMIT._CheckSingletonInHeaders(mock_input_api, + MockOutputApi()) + self.assertEqual(1, len(warnings)) + self.assertEqual('error', warnings[0].type) + self.assertTrue('Found Singleton<T>' in warnings[0].message) + + def testSingletonInCC(self): + diff_cc = ['Foo* foo = Singleton<Foo>::get();'] + mock_input_api = MockInputApi() + mock_input_api.files = [MockAffectedFile('some/path/foo.cc', diff_cc)] + warnings = PRESUBMIT._CheckSingletonInHeaders(mock_input_api, + MockOutputApi()) + self.assertEqual(0, len(warnings)) + + class InvalidOSMacroNamesTest(unittest.TestCase): def testInvalidOSMacroNames(self): lines = ['#if defined(OS_WINDOWS)', |