diff options
Diffstat (limited to 'base')
| -rw-r--r-- | base/bind_helpers.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/base/bind_helpers.h b/base/bind_helpers.h index 27434e0..73fd81e 100644 --- a/base/bind_helpers.h +++ b/base/bind_helpers.h @@ -123,6 +123,9 @@ namespace internal { // // TODO(ajwong): Move to ref_counted.h or template_util.h when we've vetted // this works well. +// +// TODO(ajwong): Make this check for Release() as well. +// See http://crbug.com/82038. template <typename T> class SupportsAddRefAndRelease { typedef char Yes[1]; @@ -130,7 +133,6 @@ class SupportsAddRefAndRelease { struct BaseMixin { void AddRef(); - void Release(); }; // MSVC warns when you try to use Base if T has a private destructor, the @@ -148,13 +150,13 @@ class SupportsAddRefAndRelease { template <void(BaseMixin::*)(void)> struct Helper {}; template <typename C> - static No& Check(Helper<&C::AddRef>*, Helper<&C::Release>*); + static No& Check(Helper<&C::AddRef>*); template <typename > static Yes& Check(...); public: - static const bool value = sizeof(Check<Base>(0,0)) == sizeof(Yes); + static const bool value = sizeof(Check<Base>(0)) == sizeof(Yes); }; |