diff options
Diffstat (limited to 'cc/PRESUBMIT.py')
-rw-r--r-- | cc/PRESUBMIT.py | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py index c876419..1c3613a 100644 --- a/cc/PRESUBMIT.py +++ b/cc/PRESUBMIT.py @@ -38,9 +38,28 @@ def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=N items=notreached_files)] return [] +def CheckSpamLogging(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=None): + black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST) + source_file_filter = lambda x: input_api.FilterSourceFile(x, white_list, black_list) + + bad_files = [] + + for f in input_api.AffectedSourceFiles(source_file_filter): + contents = input_api.ReadFile(f, 'rb') + if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents): + bad_files.append(f.LocalPath()) + + if bad_files: + return [output_api.PresubmitError( + 'These files spam the console log with LOG(INFO):', + items=bad_files)] + return [] + + def CheckChangeOnUpload(input_api, output_api): results = [] results += CheckAsserts(input_api, output_api) + results += CheckSpamLogging(input_api, output_api) return results def GetPreferredTrySlaves(project, change): |