summaryrefslogtreecommitdiffstats
path: root/chrome/browser/devtools/port_forwarding_controller.cc
diff options
context:
space:
mode:
Diffstat (limited to 'chrome/browser/devtools/port_forwarding_controller.cc')
-rw-r--r--chrome/browser/devtools/port_forwarding_controller.cc19
1 files changed, 3 insertions, 16 deletions
diff --git a/chrome/browser/devtools/port_forwarding_controller.cc b/chrome/browser/devtools/port_forwarding_controller.cc
index 9513474..a733851 100644
--- a/chrome/browser/devtools/port_forwarding_controller.cc
+++ b/chrome/browser/devtools/port_forwarding_controller.cc
@@ -49,7 +49,6 @@ static const char kTetheringAccepted[] = "Tethering.accepted";
static const char kTetheringBind[] = "Tethering.bind";
static const char kTetheringUnbind[] = "Tethering.unbind";
-static const char kChromeProductName[] = "Chrome";
static const char kDevToolsRemoteBrowserTarget[] = "/devtools/browser";
const int kMinVersionPortForwarding = 28;
@@ -221,19 +220,7 @@ class SocketTunnel {
bool about_to_destroy_;
};
-typedef std::vector<int> ParsedVersion;
-
-static ParsedVersion ParseVersion(const std::string& version) {
- ParsedVersion result;
- std::vector<std::string> parts;
- Tokenize(version, ".", &parts);
- for (size_t i = 0; i != parts.size(); ++i) {
- int value = 0;
- base::StringToInt(parts[i], &value);
- result.push_back(value);
- }
- return result;
-}
+typedef DevToolsAdbBridge::RemoteBrowser::ParsedVersion ParsedVersion;
static bool IsVersionLower(const ParsedVersion& left,
const ParsedVersion& right) {
@@ -252,8 +239,8 @@ static std::string FindBestSocketForTethering(
for (DevToolsAdbBridge::RemoteBrowsers::const_iterator it = browsers.begin();
it != browsers.end(); ++it) {
scoped_refptr<DevToolsAdbBridge::RemoteBrowser> browser = *it;
- ParsedVersion current_version = ParseVersion(browser->version());
- if (browser->product() == kChromeProductName &&
+ ParsedVersion current_version = browser->GetParsedVersion();
+ if (browser->IsChrome() &&
IsPortForwardingSupported(current_version) &&
IsVersionLower(newest_version, current_version)) {
socket = browser->socket();