summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
diff options
context:
space:
mode:
Diffstat (limited to 'chrome/browser/extensions')
-rw-r--r--chrome/browser/extensions/extension_bookmarks_module.cc9
-rw-r--r--chrome/browser/extensions/extension_bookmarks_module.h2
-rw-r--r--chrome/browser/extensions/extension_function.h2
3 files changed, 3 insertions, 10 deletions
diff --git a/chrome/browser/extensions/extension_bookmarks_module.cc b/chrome/browser/extensions/extension_bookmarks_module.cc
index ee5257c..73cb032 100644
--- a/chrome/browser/extensions/extension_bookmarks_module.cc
+++ b/chrome/browser/extensions/extension_bookmarks_module.cc
@@ -114,14 +114,7 @@ void BookmarksFunction::Run() {
ExtensionBookmarkEventRouter* event_router =
ExtensionBookmarkEventRouter::GetSingleton();
event_router->Observe(model);
- bool success = RunImpl();
- if (success) {
- NotificationService::current()->Notify(
- NotificationType::EXTENSION_BOOKMARKS_API_INVOKED,
- Source<const Extension>(GetExtension()),
- Details<const BookmarksFunction>(this));
- }
- SendResponse(success);
+ SendResponse(RunImpl());
}
bool BookmarksFunction::GetBookmarkIdAsInt64(
diff --git a/chrome/browser/extensions/extension_bookmarks_module.h b/chrome/browser/extensions/extension_bookmarks_module.h
index acaf91d..6d86bc8 100644
--- a/chrome/browser/extensions/extension_bookmarks_module.h
+++ b/chrome/browser/extensions/extension_bookmarks_module.h
@@ -69,7 +69,7 @@ class BookmarksFunction : public AsyncExtensionFunction,
protected:
// Helper to get the bookmark id as int64 from the given string id.
- // Sets error_ to an error string if the given id string can't be parsed
+ // Sets error_ to an errro string if the given id string can't be parsed
// as an int64. In case of error, doesn't change id and returns false.
bool GetBookmarkIdAsInt64(const std::string& id_string, int64* id);
diff --git a/chrome/browser/extensions/extension_function.h b/chrome/browser/extensions/extension_function.h
index e8a77dd..6090f8a 100644
--- a/chrome/browser/extensions/extension_function.h
+++ b/chrome/browser/extensions/extension_function.h
@@ -37,7 +37,7 @@ class ExtensionFunction : public base::RefCounted<ExtensionFunction> {
// Specifies the name of the function.
void set_name(const std::string& name) { name_ = name; }
- const std::string name() const { return name_; }
+ const std::string name() { return name_; }
// Specifies the raw arguments to the function, as a JSON value.
virtual void SetArgs(const Value* args) = 0;