summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
diff options
context:
space:
mode:
Diffstat (limited to 'chrome/browser/extensions')
-rw-r--r--chrome/browser/extensions/browser_action_apitest.cc3
-rw-r--r--chrome/browser/extensions/extension_management_browsertest.cc14
-rw-r--r--chrome/browser/extensions/notifications_apitest.cc16
3 files changed, 16 insertions, 17 deletions
diff --git a/chrome/browser/extensions/browser_action_apitest.cc b/chrome/browser/extensions/browser_action_apitest.cc
index cb1007e..4f0043b 100644
--- a/chrome/browser/extensions/browser_action_apitest.cc
+++ b/chrome/browser/extensions/browser_action_apitest.cc
@@ -341,8 +341,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoDragging) {
BrowserActionTestUtil incognito_bar(incognito_browser);
// Navigate just to have a tab in this window, otherwise wonky things happen.
- ui_test_utils::OpenURLOffTheRecord(browser()->profile(),
- GURL(chrome::kChromeUIExtensionsURL));
+ ui_test_utils::OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));
ASSERT_EQ(2, incognito_bar.NumberOfBrowserActions());
diff --git a/chrome/browser/extensions/extension_management_browsertest.cc b/chrome/browser/extensions/extension_management_browsertest.cc
index dd5357b..3119ab0 100644
--- a/chrome/browser/extensions/extension_management_browsertest.cc
+++ b/chrome/browser/extensions/extension_management_browsertest.cc
@@ -145,20 +145,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, InstallRequiresConfirm) {
UninstallExtension("ldnnhddmnhbkjipkidpdiheffobcpfmf");
}
-// Tests that installing and uninstalling extensions don't crash with an
-// incognito window open.
-IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, Incognito) {
- // Open an incognito window to the extensions management page. We just
- // want to make sure that we don't crash while playing with extensions when
- // this guy is around.
- ui_test_utils::OpenURLOffTheRecord(browser()->profile(),
- GURL(chrome::kChromeUIExtensionsURL));
-
- ASSERT_TRUE(InstallExtensionWithUIAutoConfirm(
- test_data_dir_.AppendASCII("good.crx"), 1, browser()->profile()));
- UninstallExtension("ldnnhddmnhbkjipkidpdiheffobcpfmf");
-}
-
// Tests the process of updating an extension to one that requires higher
// permissions.
IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, UpdatePermissions) {
diff --git a/chrome/browser/extensions/notifications_apitest.cc b/chrome/browser/extensions/notifications_apitest.cc
index 61b4be9..da134b12 100644
--- a/chrome/browser/extensions/notifications_apitest.cc
+++ b/chrome/browser/extensions/notifications_apitest.cc
@@ -9,13 +9,27 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Notifications) {
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, NotificationsNoPermission) {
#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
// Notifications not supported on linux/views yet.
#else
ASSERT_TRUE(RunExtensionTest("notifications/has_not_permission")) << message_;
+#endif
+}
+
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, NotificationsHasPermissionManifest) {
+#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
+ // Notifications not supported on linux/views yet.
+#else
ASSERT_TRUE(RunExtensionTest("notifications/has_permission_manifest"))
<< message_;
+#endif
+}
+
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, NotificationsHasPermission) {
+#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
+ // Notifications not supported on linux/views yet.
+#else
DesktopNotificationServiceFactory::GetForProfile(browser()->profile())
->GrantPermission(GURL(
"chrome-extension://peoadpeiejnhkmpaakpnompolbglelel"));