diff options
Diffstat (limited to 'chrome/browser/google_apis/operation_registry_unittest.cc')
| -rw-r--r-- | chrome/browser/google_apis/operation_registry_unittest.cc | 184 |
1 files changed, 12 insertions, 172 deletions
diff --git a/chrome/browser/google_apis/operation_registry_unittest.cc b/chrome/browser/google_apis/operation_registry_unittest.cc index 716d2ed..183d7ac 100644 --- a/chrome/browser/google_apis/operation_registry_unittest.cc +++ b/chrome/browser/google_apis/operation_registry_unittest.cc @@ -12,8 +12,6 @@ #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" -using testing::ElementsAre; - namespace google_apis { namespace { @@ -21,102 +19,23 @@ namespace { class MockOperation : public OperationRegistry::Operation, public base::SupportsWeakPtr<MockOperation> { public: - MockOperation(OperationRegistry* registry, - OperationType type, - const base::FilePath& path) - : OperationRegistry::Operation(registry, type, path) {} + explicit MockOperation(OperationRegistry* registry) + : OperationRegistry::Operation( + registry, + base::FilePath(FILE_PATH_LITERAL("/dummy/download"))) { + } MOCK_METHOD0(DoCancel, void()); // Make them public so that they can be called from test cases. using OperationRegistry::Operation::NotifyStart; - using OperationRegistry::Operation::NotifyProgress; using OperationRegistry::Operation::NotifyFinish; using OperationRegistry::Operation::NotifySuspend; using OperationRegistry::Operation::NotifyResume; }; -class MockUploadOperation : public MockOperation { - public: - explicit MockUploadOperation(OperationRegistry* registry) - : MockOperation(registry, - OPERATION_UPLOAD, - base::FilePath(FILE_PATH_LITERAL("/dummy/upload"))) {} -}; - -class MockDownloadOperation : public MockOperation { - public: - explicit MockDownloadOperation(OperationRegistry* registry) - : MockOperation(registry, - OPERATION_DOWNLOAD, - base::FilePath(FILE_PATH_LITERAL("/dummy/download"))) {} -}; - -class MockOtherOperation : public MockOperation { - public: - explicit MockOtherOperation(OperationRegistry* registry) - : MockOperation(registry, - OPERATION_OTHER, - base::FilePath(FILE_PATH_LITERAL("/dummy/other"))) {} -}; - -class TestObserver : public OperationRegistryObserver { - public: - virtual void OnProgressUpdate( - const OperationProgressStatusList& list) OVERRIDE { - status_ = list; - } - - const OperationProgressStatusList& status() const { - return status_; - } - - private: - OperationProgressStatusList status_; -}; - -class ProgressMatcher - : public ::testing::MatcherInterface<const OperationProgressStatus&> { - public: - ProgressMatcher(int64 expected_current, int64 expected_total) - : expected_current_(expected_current), - expected_total_(expected_total) {} - - virtual bool MatchAndExplain( - const OperationProgressStatus& status, - testing::MatchResultListener* /* listener */) const OVERRIDE { - return status.progress_current == expected_current_ && - status.progress_total == expected_total_; - } - - virtual void DescribeTo(::std::ostream* os) const OVERRIDE { - *os << "current / total equals " << expected_current_ << " / " << - expected_total_; - } - - virtual void DescribeNegationTo(::std::ostream* os) const OVERRIDE { - *os << "current / total does not equal " << expected_current_ << " / " << - expected_total_; - } - - private: - const int64 expected_current_; - const int64 expected_total_; -}; - -testing::Matcher<const OperationProgressStatus&> Progress( - int64 current, int64 total) { - return testing::MakeMatcher(new ProgressMatcher(current, total)); -} - } // namespace -// Pretty-prints OperationProgressStatus for testing purpose. -std::ostream& operator<<(std::ostream& os, - const OperationProgressStatus& status) { - return os << status.DebugString(); -} - class OperationRegistryTest : public testing::Test { protected: OperationRegistryTest() @@ -127,141 +46,62 @@ class OperationRegistryTest : public testing::Test { }; TEST_F(OperationRegistryTest, OneSuccess) { - TestObserver observer; OperationRegistry registry; - registry.DisableNotificationFrequencyControlForTest(); - registry.AddObserver(&observer); base::WeakPtr<MockOperation> op1 = - (new MockUploadOperation(®istry))->AsWeakPtr(); + (new MockOperation(®istry))->AsWeakPtr(); EXPECT_CALL(*op1, DoCancel()).Times(0); - EXPECT_EQ(0U, observer.status().size()); op1->NotifyStart(); - EXPECT_THAT(observer.status(), ElementsAre(Progress(0, -1))); - op1->NotifyProgress(0, 100); - EXPECT_THAT(observer.status(), ElementsAre(Progress(0, 100))); - op1->NotifyProgress(100, 100); - EXPECT_THAT(observer.status(), ElementsAre(Progress(100, 100))); op1->NotifyFinish(OPERATION_COMPLETED); - // Contains one "COMPLETED" notification. - EXPECT_THAT(observer.status(), ElementsAre(Progress(100, 100))); - // Then it is removed. - EXPECT_EQ(0U, registry.GetProgressStatusList().size()); EXPECT_EQ(NULL, op1.get()); // deleted } TEST_F(OperationRegistryTest, OneCancel) { - TestObserver observer; OperationRegistry registry; - registry.DisableNotificationFrequencyControlForTest(); - registry.AddObserver(&observer); base::WeakPtr<MockOperation> op1 = - (new MockUploadOperation(®istry))->AsWeakPtr(); + (new MockOperation(®istry))->AsWeakPtr(); EXPECT_CALL(*op1, DoCancel()); - EXPECT_EQ(0U, observer.status().size()); op1->NotifyStart(); - EXPECT_THAT(observer.status(), ElementsAre(Progress(0, -1))); - op1->NotifyProgress(0, 100); - EXPECT_THAT(observer.status(), ElementsAre(Progress(0, 100))); registry.CancelAll(); - EXPECT_THAT(observer.status(), ElementsAre(Progress(0, 100))); - EXPECT_EQ(0U, registry.GetProgressStatusList().size()); EXPECT_EQ(NULL, op1.get()); // deleted } TEST_F(OperationRegistryTest, TwoSuccess) { - TestObserver observer; OperationRegistry registry; - registry.DisableNotificationFrequencyControlForTest(); - registry.AddObserver(&observer); base::WeakPtr<MockOperation> op1 = - (new MockUploadOperation(®istry))->AsWeakPtr(); + (new MockOperation(®istry))->AsWeakPtr(); base::WeakPtr<MockOperation> op2 = - (new MockDownloadOperation(®istry))->AsWeakPtr(); + (new MockOperation(®istry))->AsWeakPtr(); EXPECT_CALL(*op1, DoCancel()).Times(0); EXPECT_CALL(*op2, DoCancel()).Times(0); - EXPECT_EQ(0U, observer.status().size()); op1->NotifyStart(); - op1->NotifyProgress(0, 100); - EXPECT_THAT(observer.status(), ElementsAre(Progress(0, 100))); op2->NotifyStart(); - op2->NotifyProgress(0, 200); - op1->NotifyProgress(50, 100); - EXPECT_THAT(observer.status(), ElementsAre(Progress(50, 100), - Progress(0, 200))); op1->NotifyFinish(OPERATION_COMPLETED); - EXPECT_THAT(observer.status(), ElementsAre(Progress(50, 100), - Progress(0, 200))); - EXPECT_EQ(1U, registry.GetProgressStatusList().size()); op2->NotifyFinish(OPERATION_COMPLETED); - EXPECT_THAT(observer.status(), ElementsAre(Progress(0, 200))); - EXPECT_EQ(0U, registry.GetProgressStatusList().size()); EXPECT_EQ(NULL, op1.get()); // deleted EXPECT_EQ(NULL, op2.get()); // deleted } -TEST_F(OperationRegistryTest, ThreeCancel) { - TestObserver observer; - OperationRegistry registry; - registry.DisableNotificationFrequencyControlForTest(); - registry.AddObserver(&observer); - - base::WeakPtr<MockOperation> op1 = - (new MockUploadOperation(®istry))->AsWeakPtr(); - base::WeakPtr<MockOperation> op2 = - (new MockDownloadOperation(®istry))->AsWeakPtr(); - base::WeakPtr<MockOperation> op3 = - (new MockOtherOperation(®istry))->AsWeakPtr(); - EXPECT_CALL(*op1, DoCancel()); - EXPECT_CALL(*op2, DoCancel()); - EXPECT_CALL(*op3, DoCancel()); - - EXPECT_EQ(0U, observer.status().size()); - op1->NotifyStart(); - EXPECT_EQ(1U, observer.status().size()); - op2->NotifyStart(); - EXPECT_EQ(2U, observer.status().size()); - op3->NotifyStart(); - EXPECT_EQ(2U, observer.status().size()); // only upload/download is reported. - registry.CancelAll(); - EXPECT_EQ(1U, observer.status().size()); // holds the last one "COMPLETED" - EXPECT_EQ(0U, registry.GetProgressStatusList().size()); - EXPECT_EQ(NULL, op1.get()); // deleted - EXPECT_EQ(NULL, op2.get()); // deleted - EXPECT_EQ(NULL, op3.get()); // deleted. CancelAll cares all operations. -} - TEST_F(OperationRegistryTest, RestartOperation) { - TestObserver observer; OperationRegistry registry; - registry.DisableNotificationFrequencyControlForTest(); - registry.AddObserver(&observer); base::WeakPtr<MockOperation> op1 = - (new MockUploadOperation(®istry))->AsWeakPtr(); + (new MockOperation(®istry))->AsWeakPtr(); EXPECT_CALL(*op1, DoCancel()).Times(0); op1->NotifyStart(); - EXPECT_EQ(1U, registry.GetProgressStatusList().size()); op1->NotifyStart(); // restart - EXPECT_EQ(1U, registry.GetProgressStatusList().size()); - op1->NotifyProgress(0, 200); op1->NotifyFinish(OPERATION_COMPLETED); - EXPECT_EQ(0U, registry.GetProgressStatusList().size()); EXPECT_EQ(NULL, op1.get()); // deleted } - TEST_F(OperationRegistryTest, SuspendCancel) { - TestObserver observer; OperationRegistry registry; - registry.DisableNotificationFrequencyControlForTest(); - registry.AddObserver(&observer); // Suspend-then-resume is a hack in OperationRegistry to tie physically // split but logically single operation (= chunked uploading split into @@ -274,7 +114,7 @@ TEST_F(OperationRegistryTest, SuspendCancel) { // callback must not be called more than once. base::WeakPtr<MockOperation> op1 = - (new MockUploadOperation(®istry))->AsWeakPtr(); + (new MockOperation(®istry))->AsWeakPtr(); EXPECT_CALL(*op1, DoCancel()).Times(0); op1->NotifyStart(); @@ -283,7 +123,7 @@ TEST_F(OperationRegistryTest, SuspendCancel) { EXPECT_EQ(NULL, op1.get()); // deleted base::WeakPtr<MockOperation> op2 = - (new MockUploadOperation(®istry))->AsWeakPtr(); + (new MockOperation(®istry))->AsWeakPtr(); EXPECT_CALL(*op2, DoCancel()).Times(1); op2->NotifyResume(); |