summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/android
diff options
context:
space:
mode:
Diffstat (limited to 'chrome/browser/ui/android')
-rw-r--r--chrome/browser/ui/android/tab_model/tab_model.cc7
-rw-r--r--chrome/browser/ui/android/tab_model/tab_model.h6
-rw-r--r--chrome/browser/ui/android/tab_model/tab_model_unittest.cc3
3 files changed, 4 insertions, 12 deletions
diff --git a/chrome/browser/ui/android/tab_model/tab_model.cc b/chrome/browser/ui/android/tab_model/tab_model.cc
index 4e6bc0e..9eb5f7a 100644
--- a/chrome/browser/ui/android/tab_model/tab_model.cc
+++ b/chrome/browser/ui/android/tab_model/tab_model.cc
@@ -123,10 +123,3 @@ void TabModel::Observe(
NOTREACHED();
}
}
-
-// TODO(kaznacheev) Make these two methods pure as soon as they are
-// implemented in TabModelImpl.
-void TabModel::SetActiveIndex(int index) { }
-
-void TabModel::CloseTabAt(int index) { }
-
diff --git a/chrome/browser/ui/android/tab_model/tab_model.h b/chrome/browser/ui/android/tab_model/tab_model.h
index ea53cc1..129164a 100644
--- a/chrome/browser/ui/android/tab_model/tab_model.h
+++ b/chrome/browser/ui/android/tab_model/tab_model.h
@@ -47,10 +47,8 @@ class TabModel : public content::NotificationObserver,
virtual content::WebContents* GetWebContentsAt(int index) const = 0;
virtual TabAndroid* GetTabAt(int index) const = 0;
- // TODO(kaznacheev) Make these two methods pure as soon as they are
- // implemented in TabModelImpl.
- virtual void SetActiveIndex(int index);
- virtual void CloseTabAt(int index);
+ virtual void SetActiveIndex(int index) = 0;
+ virtual void CloseTabAt(int index) = 0;
// Used for restoring tabs from synced foreign sessions.
virtual void CreateTab(content::WebContents* web_contents) = 0;
diff --git a/chrome/browser/ui/android/tab_model/tab_model_unittest.cc b/chrome/browser/ui/android/tab_model/tab_model_unittest.cc
index 3feaf0f..bcddf79 100644
--- a/chrome/browser/ui/android/tab_model/tab_model_unittest.cc
+++ b/chrome/browser/ui/android/tab_model/tab_model_unittest.cc
@@ -43,7 +43,8 @@ class TestTabModel : public TabModel {
virtual TabAndroid* GetTabAt(int index) const OVERRIDE {
return NULL;
}
-
+ virtual void SetActiveIndex(int index) OVERRIDE {}
+ virtual void CloseTabAt(int index) OVERRIDE {}
};
TEST_F(TabModelTest, TestProfileHandling) {