summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/apps/app_launcher_util.cc2
-rw-r--r--chrome/browser/extensions/updater/extension_updater.cc2
-rw-r--r--chrome/browser/jankometer.cc2
-rw-r--r--chrome/browser/performance_monitor/performance_monitor.cc5
-rw-r--r--chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc4
-rw-r--r--chrome/browser/ui/gtk/browser_titlebar.cc5
-rw-r--r--chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc3
-rw-r--r--chrome/browser/ui/gtk/download/download_started_animation_gtk.cc5
-rw-r--r--chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc3
-rw-r--r--chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc1
-rw-r--r--chrome/browser/ui/gtk/infobars/infobar_gtk.cc3
-rw-r--r--chrome/browser/ui/gtk/location_bar_view_gtk.cc5
-rw-r--r--chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc4
-rw-r--r--chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk_unittest.cc2
-rw-r--r--chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc1
-rw-r--r--chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc3
-rw-r--r--chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc2
-rw-r--r--chrome/browser/ui/webui/options/certificate_manager_handler.cc1
18 files changed, 6 insertions, 47 deletions
diff --git a/chrome/browser/apps/app_launcher_util.cc b/chrome/browser/apps/app_launcher_util.cc
index 8d1be30..ffe444153 100644
--- a/chrome/browser/apps/app_launcher_util.cc
+++ b/chrome/browser/apps/app_launcher_util.cc
@@ -13,6 +13,7 @@
namespace {
+#if defined(ENABLE_APP_LIST)
// The field trial group name that enables showing the promo.
const char kShowLauncherPromoOnceGroupName[] = "ShowPromoUntilDismissed";
@@ -22,6 +23,7 @@ const char kResetShowLauncherPromoPrefGroupName[] = "ResetShowPromoPref";
// The name of the field trial that controls showing the app launcher promo.
const char kLauncherPromoTrialName[] = "ShowAppLauncherPromo";
+#endif // defined(ENABLE_APP_LIST)
} // namespace
diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/browser/extensions/updater/extension_updater.cc
index 8a8e215..aa3fc4b 100644
--- a/chrome/browser/extensions/updater/extension_updater.cc
+++ b/chrome/browser/extensions/updater/extension_updater.cc
@@ -52,7 +52,9 @@ namespace {
const int kStartupWaitSeconds = 60 * 5;
// For sanity checking on update frequency - enforced in release mode only.
+#ifdef NDEBUG
const int kMinUpdateFrequencySeconds = 30;
+#endif
const int kMaxUpdateFrequencySeconds = 60 * 60 * 24 * 7; // 7 days
// Require at least 5 seconds between consecutive non-succesful extension update
diff --git a/chrome/browser/jankometer.cc b/chrome/browser/jankometer.cc
index 4cfbc41..a5d841d 100644
--- a/chrome/browser/jankometer.cc
+++ b/chrome/browser/jankometer.cc
@@ -48,8 +48,10 @@ const int kMaxIOMessageDelayMs = 400;
// considering it delayed.
const int kMaxMessageProcessingMs = 100;
+#if defined(OS_WIN)
// TODO(brettw) Consider making this a pref.
const bool kPlaySounds = false;
+#endif
//------------------------------------------------------------------------------
// Provide a special watchdog to make it easy to set the breakpoint on this
diff --git a/chrome/browser/performance_monitor/performance_monitor.cc b/chrome/browser/performance_monitor/performance_monitor.cc
index 55e5df1..12d7a7c 100644
--- a/chrome/browser/performance_monitor/performance_monitor.cc
+++ b/chrome/browser/performance_monitor/performance_monitor.cc
@@ -50,11 +50,6 @@ namespace performance_monitor {
namespace {
-const uint32 kAccessFlags = base::kProcessAccessDuplicateHandle |
- base::kProcessAccessQueryInformation |
- base::kProcessAccessTerminate |
- base::kProcessAccessWaitForTermination;
-
std::string TimeToString(base::Time time) {
int64 time_int64 = time.ToInternalValue();
return base::Int64ToString(time_int64);
diff --git a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
index 4140b6d..34f300a 100644
--- a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
+++ b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
@@ -64,10 +64,6 @@ const int kButtonPadding = 4;
// and chevron if they are both showing).
const int kButtonChevronPadding = 2;
-// The padding to the left, top and bottom of the browser actions toolbar
-// separator.
-const int kSeparatorPadding = 2;
-
// Width of the invisible gripper for resizing the toolbar.
const int kResizeGripperWidth = 4;
diff --git a/chrome/browser/ui/gtk/browser_titlebar.cc b/chrome/browser/ui/gtk/browser_titlebar.cc
index 42ce7c87..32e9aeb 100644
--- a/chrome/browser/ui/gtk/browser_titlebar.cc
+++ b/chrome/browser/ui/gtk/browser_titlebar.cc
@@ -78,11 +78,6 @@ const int kAvatarBottomSpacing = 1;
// it on the left, and between it and the tabstrip on the right).
const int kAvatarSideSpacing = 2;
-// The thickness of the custom frame border; we need it here to enlarge the
-// close button whent the custom frame border isn't showing but the custom
-// titlebar is showing.
-const int kFrameBorderThickness = 4;
-
// There is a 4px gap between the icon and the title text.
const int kIconTitleSpacing = 4;
diff --git a/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc b/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc
index 92f14b0..c3035cf 100644
--- a/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc
+++ b/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc
@@ -47,9 +47,6 @@ const int kIconPreviewSizePixels = 32;
// Minimum width (in pixels) of the shortcut description label.
const int kDescriptionLabelMinimumWidthPixels = 200;
-// Height (in lines) of the shortcut description label.
-const int kDescriptionLabelHeightLines = 3;
-
} // namespace
namespace chrome {
diff --git a/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc b/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc
index a43e41b..9cb44a0 100644
--- a/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc
+++ b/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc
@@ -32,11 +32,6 @@ const int kMoveTimeMs = 600;
// The animation framerate.
const int kFrameRateHz = 60;
-// What fraction of the frame height to move downward from the frame center.
-// Note that setting this greater than 0.5 will mean moving past the bottom of
-// the frame.
-const double kMoveFraction = 1.0 / 3.0;
-
class DownloadStartedAnimationGtk : public gfx::LinearAnimation,
public content::NotificationObserver {
public:
diff --git a/chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc
index d2f4411..9cd5f93 100644
--- a/chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc
+++ b/chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc
@@ -22,9 +22,6 @@
namespace {
-// Left or right margin.
-const int kPanelHorizMargin = 13;
-
// GTK implementation of the uninstall dialog.
class ExtensionUninstallDialogGtk : public ExtensionUninstallDialog {
public:
diff --git a/chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc b/chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc
index 8415dae..c0e855c 100644
--- a/chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc
+++ b/chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc
@@ -23,7 +23,6 @@ namespace {
const GdkColor kBackgroundColor = GDK_COLOR_RGB(0xff, 0xff, 0xff);
const GdkColor kFrameColor = GDK_COLOR_RGB(0x63, 0x63, 0x63);
-const int kMiddlePaddingPx = 30;
} // namespace
diff --git a/chrome/browser/ui/gtk/infobars/infobar_gtk.cc b/chrome/browser/ui/gtk/infobars/infobar_gtk.cc
index ab2417b..a2bd308 100644
--- a/chrome/browser/ui/gtk/infobars/infobar_gtk.cc
+++ b/chrome/browser/ui/gtk/infobars/infobar_gtk.cc
@@ -33,9 +33,6 @@ const int kElementPadding = 5;
const int kLeftPadding = 5;
const int kRightPadding = 5;
-// Spacing between buttons.
-const int kButtonButtonSpacing = 3;
-
} // namespace
diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk.cc b/chrome/browser/ui/gtk/location_bar_view_gtk.cc
index 660c5d9..3e09ab9 100644
--- a/chrome/browser/ui/gtk/location_bar_view_gtk.cc
+++ b/chrome/browser/ui/gtk/location_bar_view_gtk.cc
@@ -154,11 +154,6 @@ const GdkColor kContentSettingBorderColor = GDK_COLOR_RGB(0xe9, 0xb9, 0x66);
const GdkColor kContentSettingTopColor = GDK_COLOR_RGB(0xff, 0xf8, 0xd4);
const GdkColor kContentSettingBottomColor = GDK_COLOR_RGB(0xff, 0xe6, 0xaf);
-// Styling for gray button.
-const GdkColor kGrayBorderColor = GDK_COLOR_RGB(0xa0, 0xa0, 0xa0);
-const GdkColor kTopColorGray = GDK_COLOR_RGB(0xe5, 0xe5, 0xe5);
-const GdkColor kBottomColorGray = GDK_COLOR_RGB(0xd0, 0xd0, 0xd0);
-
inline int InnerPadding() {
return extensions::FeatureSwitch::script_badges()->IsEnabled() ?
kScriptBadgeInnerPadding : kInnerPadding;
diff --git a/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc b/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc
index 4cd8297..c642ea5 100644
--- a/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc
+++ b/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc
@@ -54,10 +54,6 @@ const int kBottomMargin = 1;
const int kLeftMargin = 1;
const int kRightMargin = 1;
-// How many pixels of overlap there is between the shelf top and the
-// balloon bottom.
-const int kShelfBorderTopOverlap = 0;
-
// Properties of the origin label.
const int kLeftLabelMargin = 8;
diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk_unittest.cc b/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk_unittest.cc
index 4d268f3..2908f93 100644
--- a/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk_unittest.cc
+++ b/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk_unittest.cc
@@ -19,8 +19,6 @@
namespace {
-const float kLargeWidth = 10000;
-
const GdkColor kContentTextColor = GDK_COLOR_RGB(0x00, 0x00, 0x00);
const GdkColor kDimContentTextColor = GDK_COLOR_RGB(0x80, 0x80, 0x80);
const GdkColor kURLTextColor = GDK_COLOR_RGB(0x00, 0x88, 0x00);
diff --git a/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc b/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc
index ed447e2..4835970 100644
--- a/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc
+++ b/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc
@@ -52,7 +52,6 @@ const int kLeftPadding = 16;
const int kTopPadding = 6;
const int kRightPadding = 15;
const int kBottomPadding = 5;
-const int kDropShadowHeight = 2;
const int kFaviconTitleSpacing = 4;
const int kTitleCloseButtonSpacing = 5;
const int kStandardTitleWidth = 175;
diff --git a/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc b/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc
index 7fbdf14..561e387 100644
--- a/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc
+++ b/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc
@@ -58,7 +58,6 @@ namespace {
const int kDefaultAnimationDurationMs = 100;
const int kResizeLayoutAnimationDurationMs = 166;
const int kReorderAnimationDurationMs = 166;
-const int kAnimateToBoundsDurationMs = 150;
const int kMiniTabAnimationDurationMs = 150;
const int kNewTabButtonHOffset = -5;
@@ -76,8 +75,6 @@ const int kLayoutAfterSizeAllocateMs = 10;
// start/stop the resize animation.
const int kTabStripAnimationVSlop = 40;
-const int kHorizontalMoveThreshold = 16; // pixels
-
// The horizontal offset from one tab to the next, which results in overlapping
// tabs.
const int kTabHOffset = -16;
diff --git a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
index 8077127..78d04ff 100644
--- a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
@@ -20,8 +20,6 @@ namespace local_discovery {
namespace {
const char kSampleServiceName[] = "myService._privet._tcp.local";
-const char kSampleDeviceID[] = "MyFakeID";
-const char kSampleDeviceHost[] = "myservice.local";
class TestMessageLoopCondition {
public:
diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
index dbabb00..5c586f4 100644
--- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
@@ -49,7 +49,6 @@ static const char kNameId[] = "name";
static const char kReadOnlyId[] = "readonly";
static const char kUntrustedId[] = "untrusted";
static const char kExtractableId[] = "extractable";
-static const char kSecurityDeviceId[] = "device";
static const char kErrorId[] = "error";
static const char kPolicyTrustedId[] = "policy";