diff options
Diffstat (limited to 'components/nacl/renderer')
-rw-r--r-- | components/nacl/renderer/histogram.cc | 6 | ||||
-rw-r--r-- | components/nacl/renderer/plugin/plugin.cc | 25 | ||||
-rw-r--r-- | components/nacl/renderer/plugin/plugin.h | 4 |
3 files changed, 0 insertions, 35 deletions
diff --git a/components/nacl/renderer/histogram.cc b/components/nacl/renderer/histogram.cc index bffdba0..7f14657 100644 --- a/components/nacl/renderer/histogram.cc +++ b/components/nacl/renderer/histogram.cc @@ -85,8 +85,6 @@ void HistogramEnumerateOsArch(const std::string& sandbox_isa) { } // Records values up to 20 seconds. -// These constants MUST match those in -// components/nacl/renderer/plugin/plugin.cc void HistogramTimeSmall(const std::string& name, int64_t sample) { if (sample < 0) sample = 0; @@ -101,8 +99,6 @@ void HistogramTimeSmall(const std::string& name, int64_t sample) { } // Records values up to 3 minutes, 20 seconds. -// These constants MUST match those in -// components/nacl/renderer/plugin/plugin.cc void HistogramTimeMedium(const std::string& name, int64_t sample) { if (sample < 0) sample = 0; @@ -117,8 +113,6 @@ void HistogramTimeMedium(const std::string& name, int64_t sample) { } // Records values up to 33 minutes. -// These constants MUST match those in -// components/nacl/renderer/plugin/plugin.cc void HistogramTimeLarge(const std::string& name, int64_t sample) { if (sample < 0) sample = 0; diff --git a/components/nacl/renderer/plugin/plugin.cc b/components/nacl/renderer/plugin/plugin.cc index c714040..89c5db7 100644 --- a/components/nacl/renderer/plugin/plugin.cc +++ b/components/nacl/renderer/plugin/plugin.cc @@ -26,15 +26,6 @@ namespace plugin { -namespace { - -// Up to 20 seconds -const int64_t kTimeSmallMin = 1; // in ms -const int64_t kTimeSmallMax = 20000; // in ms -const uint32_t kTimeSmallBuckets = 100; - -} // namespace - void Plugin::ShutDownSubprocesses() { PLUGIN_PRINTF(("Plugin::ShutDownSubprocesses (this=%p)\n", static_cast<void*>(this))); @@ -47,15 +38,6 @@ void Plugin::ShutDownSubprocesses() { static_cast<void*>(this))); } -void Plugin::HistogramTimeSmall(const std::string& name, - int64_t ms) { - if (ms < 0) return; - uma_interface_.HistogramCustomTimes(name, - ms, - kTimeSmallMin, kTimeSmallMax, - kTimeSmallBuckets); -} - bool Plugin::LoadHelperNaClModuleInternal(NaClSubprocess* subprocess, const SelLdrStartParams& params) { CHECK(!pp::Module::Get()->core()->IsMainThread()); @@ -251,8 +233,6 @@ Plugin::Plugin(PP_Instance pp_instance) } Plugin::~Plugin() { - int64_t shutdown_start = NaClGetTimeOfDayMicroseconds(); - // Destroy the coordinator while the rest of the data is still there pnacl_coordinator_.reset(NULL); @@ -285,11 +265,6 @@ Plugin::~Plugin() { ShutDownSubprocesses(); delete wrapper_factory_; - - HistogramTimeSmall( - "NaCl.Perf.ShutdownTime.Total", - (NaClGetTimeOfDayMicroseconds() - shutdown_start) - / NACL_MICROS_PER_MILLI); } bool Plugin::HandleDocumentLoad(const pp::URLLoader& url_loader) { diff --git a/components/nacl/renderer/plugin/plugin.h b/components/nacl/renderer/plugin/plugin.h index cb0e2937..7e9a323 100644 --- a/components/nacl/renderer/plugin/plugin.h +++ b/components/nacl/renderer/plugin/plugin.h @@ -110,10 +110,6 @@ class Plugin : public pp::Instance { // in this order, for the main nacl subprocess. void ShutDownSubprocesses(); - // Histogram helper functions, internal to Plugin so they can use - // uma_interface_ normally. - void HistogramTimeSmall(const std::string& name, int64_t ms); - // Loads and starts a helper (e.g. llc, ld) NaCl module. // Only to be used from a background (non-main) thread for the PNaCl // translator. This will fully initialize the |subprocess| if the load was |