diff options
Diffstat (limited to 'mojo/edk/system/channel.h')
| -rw-r--r-- | mojo/edk/system/channel.h | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/mojo/edk/system/channel.h b/mojo/edk/system/channel.h index 715d1f2..e0ecc3b 100644 --- a/mojo/edk/system/channel.h +++ b/mojo/edk/system/channel.h @@ -196,8 +196,15 @@ class MOJO_SYSTEM_IMPL_EXPORT Channel typedef base::hash_map<ChannelEndpointId, scoped_refptr<MessagePipe>> IdToMessagePipeMap; - // Map from local IDs to pending/incoming endpoints (i.e., those which do not - // yet have a dispatcher attached). + // Map from local IDs to pending/incoming message pipes (i.e., those which do + // not yet have a dispatcher attached). + // TODO(vtl): This is a layering violation, since |Channel| shouldn't know + // about |MessagePipe|. However, we can't just hang on to |ChannelEndpoint|s + // (even if they have a reference to the |MessagePipe|) since their lifetimes + // are tied to the "remote" side. When |ChannelEndpoint::DetachFromChannel()| + // (eventually) results in |ChannelEndpoint::DetachFromClient()| being called. + // We really need to hang on to the "local" side of the message pipe, to which + // dispatchers will be "attached". IdToMessagePipeMap incoming_message_pipes_; // TODO(vtl): We need to keep track of remote IDs (so that we don't collide // if/when we wrap). |