summaryrefslogtreecommitdiffstats
path: root/sync/engine/process_commit_response_command_unittest.cc
diff options
context:
space:
mode:
Diffstat (limited to 'sync/engine/process_commit_response_command_unittest.cc')
-rw-r--r--sync/engine/process_commit_response_command_unittest.cc78
1 files changed, 0 insertions, 78 deletions
diff --git a/sync/engine/process_commit_response_command_unittest.cc b/sync/engine/process_commit_response_command_unittest.cc
index 3fb7017..5c96424 100644
--- a/sync/engine/process_commit_response_command_unittest.cc
+++ b/sync/engine/process_commit_response_command_unittest.cc
@@ -349,82 +349,4 @@ TEST_F(ProcessCommitResponseCommandTest, NewFolderCommitKeepsChildOrder) {
<< "Too few or too many children in parent folder after commit.";
}
-// This test fixture runs across a Cartesian product of per-type fail/success
-// possibilities.
-enum {
- TEST_PARAM_BOOKMARK_ENABLE_BIT,
- TEST_PARAM_AUTOFILL_ENABLE_BIT,
- TEST_PARAM_BIT_COUNT
-};
-class MixedResult :
- public ProcessCommitResponseCommandTest,
- public ::testing::WithParamInterface<int> {
- protected:
- bool ShouldFailBookmarkCommit() {
- return (GetParam() & (1 << TEST_PARAM_BOOKMARK_ENABLE_BIT)) == 0;
- }
- bool ShouldFailAutofillCommit() {
- return (GetParam() & (1 << TEST_PARAM_AUTOFILL_ENABLE_BIT)) == 0;
- }
-};
-INSTANTIATE_TEST_CASE_P(ProcessCommitResponse,
- MixedResult,
- testing::Range(0, 1 << TEST_PARAM_BIT_COUNT));
-
-// This test commits 2 items (one bookmark, one autofill) and validates what
-// happens to the extensions activity records. Commits could fail or succeed,
-// depending on the test parameter.
-TEST_P(MixedResult, ExtensionActivity) {
- sessions::OrderedCommitSet commit_set(session()->context()->routing_info());
- sync_pb::ClientToServerMessage request;
- sync_pb::ClientToServerResponse response;
-
- EXPECT_NE(routing_info().find(BOOKMARKS)->second,
- routing_info().find(AUTOFILL)->second)
- << "To not be lame, this test requires more than one active group.";
-
- // Bookmark item setup.
- CreateUnprocessedCommitResult(
- id_factory_.NewServerId(),
- id_factory_.root(), "Some bookmark", false,
- BOOKMARKS, &commit_set, &request, &response);
- if (ShouldFailBookmarkCommit())
- SetLastErrorCode(CommitResponse::TRANSIENT_ERROR, &response);
- // Autofill item setup.
- CreateUnprocessedCommitResult(
- id_factory_.NewServerId(),
- id_factory_.root(), "Some autofill", false,
- AUTOFILL, &commit_set, &request, &response);
- if (ShouldFailAutofillCommit())
- SetLastErrorCode(CommitResponse::TRANSIENT_ERROR, &response);
-
- // Put some extensions activity in the session.
- {
- ExtensionsActivityMonitor::Records* records =
- session()->mutable_extensions_activity();
- (*records)["ABC"].extension_id = "ABC";
- (*records)["ABC"].bookmark_write_count = 2049U;
- (*records)["xyz"].extension_id = "xyz";
- (*records)["xyz"].bookmark_write_count = 4U;
- }
- ProcessCommitResponseCommand command(commit_set, request, response);
- command.ExecuteImpl(session());
- ExpectGroupsToChange(command, GROUP_UI, GROUP_DB);
-
- ExtensionsActivityMonitor::Records final_monitor_records;
- context()->extensions_monitor()->GetAndClearRecords(&final_monitor_records);
-
- if (ShouldFailBookmarkCommit()) {
- ASSERT_EQ(2U, final_monitor_records.size())
- << "Should restore records after unsuccessful bookmark commit.";
- EXPECT_EQ("ABC", final_monitor_records["ABC"].extension_id);
- EXPECT_EQ("xyz", final_monitor_records["xyz"].extension_id);
- EXPECT_EQ(2049U, final_monitor_records["ABC"].bookmark_write_count);
- EXPECT_EQ(4U, final_monitor_records["xyz"].bookmark_write_count);
- } else {
- EXPECT_TRUE(final_monitor_records.empty())
- << "Should not restore records after successful bookmark commit.";
- }
-}
-
} // namespace syncer