| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=74435
TEST=unit_tests, set the AllowOutdatedPlugins policy and open a page
running an outdated plugin.
Review URL: http://codereview.chromium.org/6676113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was performance warning at 79961.
BUG=none
TEST=none
TBR=pfeldman
Review URL: http://codereview.chromium.org/6737020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6756034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The data file could not be located since it didn't exist at the location where the bots ran the test.
Added a function that returns the relative path of where the data file sits on the bots.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6783008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on corresponding country.
- AutofillTest.testPostalCodeAndStateLabelsBasedOnCountry
- state_zip_labels.txt
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6770023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Doing this also fixes the overlapping icon problem (see bug).
BUG=chromium-os:13194
TEST=manually, tested volume/brightness for an LTR UI and an RTL UI.
Review URL: http://codereview.chromium.org/6777009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add a comment, fix indentation, remove an unused parameter
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6690029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6670104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
prediction quality.
BUG=76945
TEST=unit_tests --gtest_filter=AutofillMetrics.*
Review URL: http://codereview.chromium.org/6708099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
testInstant
testAllowCookies
testClearSiteDataOnExit
testBlockThirdPartyCookies
testDisableSPDY
testIncognitoEnabled
BUG=55480
TEST=none
Review URL: http://codereview.chromium.org/6728017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
MultipleClientLivePasswordsSyncTest.Sanity fails intermittently with
what looks like a sync error. Marking the test as failing.
BUG=77993
TEST=sync_integration_tests
TBR=georgey@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=tfarina@chromium.org
Review URL: http://codereview.chromium.org/6690032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67676
TEST=waterfall.sh match
Review URL: http://codereview.chromium.org/6758026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to run these performance test using local media files and make these data
available on Buildbot.
Review URL: http://codereview.chromium.org/6312171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor ProfileSyncServiceBookmarkTest to not set up a full sync
service anymore.
Move some tests in ProfileSyncServiceBookmarkTest back to ProfileSyncServiceTest.
BUG=77803
TEST=
Review URL: http://codereview.chromium.org/6708123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69508
TEST=Linux, Mac only: Run chrome with flag --enable-print-preview, hit ctrl+p, select Print to PDF from the printer list and hit the print button, select a filename and save. A pdf file should be generated at the specified location.
Review URL: http://codereview.chromium.org/6698074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=77990
TEST=waterfall.sh match
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/6758023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6670103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6740009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=77634
TEST=None
R=avi@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/6778026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6708059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=42958
TEST=None
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6728014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles, unittests
Review URL: http://codereview.chromium.org/6776003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=75296
TEST=none
Review URL: http://codereview.chromium.org/6740008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72973
TEST=Run Chrome in Hebrew, select English from the language list, verify that title displays properly.
Review URL: http://codereview.chromium.org/6670090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
notifications.
BUG=no
TEST=no
TBR=willchan
Review URL: http://codereview.chromium.org/6670097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These tests will verify that the user can't modify any managed preferences through Chrome UI.
BUG=55480
TEST=none
Review URL: http://codereview.chromium.org/5569006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tabstrip. I'ved removed BaseTabStrip::CanDrop so that BrowserRootView
is always targeted for dnd.
BUG=76231
TEST=see bug
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6770015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79902
Review URL: http://codereview.chromium.org/6759041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
---
chroot to /proc instead of /tmp. This gets rid of a lot of unnecessary
complexity and fixes a race condition.
(Original idea from Markus)
The chroot helper will chroot to /proc/self/fdinfo (or /proc/self/fd). This is
pretty safe because access to this directory is protected by the ptrace() check
in the kernel and the helper is privileged.
Moreover, as soon as the helper _exit() and becomes a zombie, the directory
will be empty. Zygote should wait() for us to make everything deterministric.
We also export SBX_HELPER_PID so that Zygote can specifically wait for the
helper.
---
BUG=76542
R=markus,agl
Review URL: http://codereview.chromium.org/6683056
TBR=cevans@chromium.org
Review URL: http://codereview.chromium.org/6675053
TBR=laforge@chromium.org
Review URL: http://codereview.chromium.org/6780010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=73231
TEST=default browser setting should work correctly on recent GNOME, e.g. Ubuntu 11.04
Review URL: http://codereview.chromium.org/6670095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
autocomplete is off for credit card field.
- autofill.testCCInfoNotStoredWhenAutocompleteOff
- cc_autocomplete_off_test.html
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6777003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Info about where the unsortedness happens.
BUG=71832
TEST=I will monitor resulting histograms.
Review URL: http://codereview.chromium.org/6765035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
autofill.AutofillTest.testFillProfileCrazyCharacters tests.
Assigned 77969 to dyu for investigation.
Review URL: http://codereview.chromium.org/6758017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to ask for permissions they don't need.
BUG=77440
TEST=No "permissions" string in http://code.google.com/chrome/extensions/apps.html
Review URL: http://codereview.chromium.org/6670092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sync integration test SetPassphraseAndThenSetupSync is failing on the
chromium waterfall. Marking it as such.
TBR=atwilson@chromium.org
BUG=77956
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6728007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this should have been repaired by several patches last week.
BUG=76932
TEST=mac valgrind stays green
Review URL: http://codereview.chromium.org/6765036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a race at boot where Chrome can attempt to use ALSA
before its kernel modules have been loaded. We previously
wouldn't retry the initialization in this case, resulting in
the volume keys not working until Chrome was restarted.
This change makes the mixer code retry on failure once per
second, up to twenty times. I've typically seen the modules
get loaded 5-6 seconds after we start Chrome (although we
don't make it until this code until a bit later; I see one or
two failures before we succeed).
It would be good to also load the modules earlier, if we can
do so without impacting boot time -- if the volume keys are
pressed before the modules are loaded now, the "muted"
bubble still comes up.
BUG=chromium-os:13162
TEST=booted with my change from issue 13226 and checked that the volume keys start working after a few seconds, and also that this doesn't block the UI (it's happening on its own thread)
Review URL: http://codereview.chromium.org/6760014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, we previously did not reset the SQL statement when trying to import favicons with invalid URLs or with data that we could not decode.
BUG=none
TEST=import Safari bookmarks with a troublesome favicon; don't hit a DCHECK
Review URL: http://codereview.chromium.org/6765024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This lets us look up the request associated with an http transaction and
send event details for the webRequest.onBeforeRequest extension event.
I also hooked up the onBeforeRequest event for HTTP network and cache transactions so that they are separate from other requests. This lets us have the request header information.
BUG=60101
TEST=no
Review URL: http://codereview.chromium.org/6698009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
syncapi-related unit tests
BUG=
TEST=
Review URL: http://codereview.chromium.org/6759041
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6728006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously
when closing the last non-incognito window while an incognito window
was open resulted in clearing out the current session. Now the session
is not cleared out.
BUG=31540
TEST=see bug, also covered by tests
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/6675049
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/6728005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6759041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74619
TEST=Install unpacked extension, go to chrome://extensions, verify that the path is shown.
Review URL: http://codereview.chromium.org/6695031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
root bookmarks folder.
BUG=29190
TEST=chrome.bookmarks.create({parentId:"0", ...}) fails with the message
"Can't modify the root bookmark folders."
Review URL: http://codereview.chromium.org/6659020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=arv@chromium.org,estade@chromium.org,scr@chromium.org
Review URL: http://codereview.chromium.org/6725034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the technique from http://www.cocoadev.com/index.pl?PreventWindowOrdering
Since DownloadItemButton is derived from DraggableButton which already overrides -mouseDown to do something like on that page, and since NSButton already -acceptsFirstMouse, overriding -shouldDelayWindowOrderingForEvent is sufficient.
BUG=77807
TEST=see bug
Review URL: http://codereview.chromium.org/6780002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6778030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79896 0039d316-1c4b-4281-b951-d872f2087c98
|