| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/218633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'll do bindings/{lib,tests} separately.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/218613010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Further changes will remove all the automation and related testing code.
BUG=316203
R=avi@chromium.org
Review URL: https://codereview.chromium.org/220413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes for ARCH_X86 used instead of ARCH_X86_FAMILY. Fixes for
size_t assumed to be unsigned int.
BUG=346626,354405
Review URL: https://codereview.chromium.org/209443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Roll to 2e8d713 to pick up "Fix JNI for jint to jlong conversion".
BUG=
R=mkosiba@chromium.org
Review URL: https://codereview.chromium.org/218393016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=vegorov@chromium.org
BUG=348629
NOTRY=true
Review URL: https://codereview.chromium.org/220883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r260827 cleaned this code up a bit too well; two '!'s were removed which
shouldn't have been removed. The code currently crashes. Oops. :(
BUG=261628
TBR=vabr@chromium.org,markusheintz@chromium.org
Review URL: https://codereview.chromium.org/220723003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid going into prefer smoothness mode when the scrolled layer has a
scroll handler. The presence of a scroll handler suggests that the main
thread wants to animate in response to scrolling. Avoiding smoothness
mode gives it a chance to do that while still having our deadline as a
fallback.
BUG=347366
Review URL: https://codereview.chromium.org/206523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=340424
Review URL: https://codereview.chromium.org/218623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of having DeviceDisplayInfo listening for onConfigurationChange,
this patch changes the update to come from ScreenOrientationListener.
Ideally, we might want to have a DisplayListener that would be used by
ScreenOrientationListener and would update a cached DeviceDisplayInfo.
BUG=354275
Review URL: https://codereview.chromium.org/219963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The switches defined in base_switches.h are used in
nacl_process_host.cc, add dependency is clearly needed for other NaCl
embedder.
This dependency is added in chrome/chrome_common.gypi, thus this issue
is hidden for chrome build.
This is part of an effort to componentize NaCl code.
BUG=244791
Review URL: https://codereview.chromium.org/218763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blink is calling new API createAudioDevice().
It needs to remove.
TODO(crogers): remove deprecated API as soon as WebKit calls new API.
This patch is related with https://codereview.chromium.org/201723003/
BUG=353110
Review URL: https://codereview.chromium.org/201303006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
That causes browser_tests failure on bot that have less than 1GB disk space for profile.
BUG=230779, 354425
Review URL: https://codereview.chromium.org/220713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium base revision: 260773 / e8adffd7
Old Skia revision: 13966
New Skia revision: 14002
Control CL: https://codereview.chromium.org/220553003
This CL was created by Skia's roll_deps.py script.
Bypassing commit queue trybots:
NOTRY=true
R=rmistry@chromium.org
Review URL: https://codereview.chromium.org/220453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CL is a preparation to move SyncEngine's task to worker thread.
BUG=347425
Review URL: https://codereview.chromium.org/218613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarService is now responsible for associating an InfoBarManager to a Tab
and handling the interactions with the rest of chrome (notifications, navigation
events).
InfoBarManager has the core logic for infobar management. It owns the list of infobars.
Eventually InfoBarManager will no longer rely on content/, but for now it still
has a reference to a WebContents instance. This reference was kept for now to
minimize the size of the change, but will be removed in a future CL.
BUG=354379
TBR=jochen
Review URL: https://codereview.chromium.org/211273007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently audio_player_scripts.js is loaded only when the flattener is enabled. So we don't need this double-slash guards anymore.
And the double-slash prevents upreving to Polymer 0.2.1. https://codereview.chromium.org/218583004/ So this patch remove them.
BUG=none
TEST=manually tested
R=fukino@chromium.org
TBR=hirono@chromium.org
Review URL: https://codereview.chromium.org/220473005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a command-line frontend to memory_inspector.
For the moment a few basic ps stats are supported.
More features will follow in the next CLs.
BUG=340294
NOTRY=true
Review URL: https://codereview.chromium.org/196343031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To heat up the file system caches we load the disk cache index
into RAM when starting the browser. To make it more obvious
what we're doing, move that to a method named Preload().
BUG=None
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/206453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=358295
NOTRY=true
Review URL: https://codereview.chromium.org/220113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/220363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If there are no google accounts registered in a device, Chrome Shell crashes when it attempts to sign in.
Because the length of |mAccounts| becomes 0.
So trying to take an account in |mAccounts| leads to an "out of index range" situation.
Review URL: https://codereview.chromium.org/208323009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=170430:170525&mode=html
TBR=rafaelw@chromium.org
BUG=
Review URL: https://codereview.chromium.org/218403005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace 'asd' into 'asdf' since editing/spelling/design-mode-spellcheck-off.html
is using it.
The test was always passing as it expects not to have spelling markers due to
<body spellcheck=false>
BUG=
Review URL: https://codereview.chromium.org/214153005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes an error where the edge key of subclass edges was non-unique causing subclass edge entries to be incorrectly overwritten.
BUG=334149
NOTRY=true
Review URL: https://codereview.chromium.org/219213004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Still to do: more tests.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/220113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does the following:
- Componentizes SigninIdAccountHelper, on which SigninManager depends
- Abstracts SigninManager's (embedder-level) calculation of whether to merge
signin credentials into the cookie jar via SigninClient
- Eliminates the |profile| argument of SigninManagerBase::Initialize() now that
SigninManager no longer needs it
- Componentizes SigninManager
BUG=334209,333998
TBR=thakis
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260636
Review URL: https://codereview.chromium.org/218713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's no particular need for this to be in web_app_ui. It's better
to unify this code into web_app.cc.
This refactor is necessary for http://crrev.com/205563005.
BUG=356889
Review URL: https://codereview.chromium.org/212273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=tasak@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/220593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OLD=http://i.imgur.com/qtE6kil.png
NEW=http://i.imgur.com/XLhYBvA.png
BUG=312956
Review URL: https://codereview.chromium.org/219423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just trying to understand the code; refactoring out some repetitive
ColumnSet declaration, and adding a number of comments to clarify things
for future generations.
BUG=261628
Review URL: https://codereview.chromium.org/213833009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/210083009/)
Reason for revert:
This patch broke 'sizes' by adding a static initializer. Seehttp://build.chromium.org/p/chromium/builders/Linux/builds/48686/steps/sizes/logs/stdio for the detailed dump.
Original issue's description:
> Add a whole-app-list unit test.
>
> This establishes a test harness for doing tests that touch on multiple
> parts of the app launcher UI, or that need coverage for the various app
> launcher configurations: Ash or Desktop; regular or experimental
> "landscape" mode.
>
> It currently just tests displaying and closing the app launcher in its
> default state with a flat (no folders), 2- or 3-page model.
>
> BUG=169114
> TEST=Added unit tests AppListViewTest{Aura,Desktop}.*
>
> Previously committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260762
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260803
TBR=calamity@chromium.org,tapted@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=169114
Review URL: https://codereview.chromium.org/220873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/212833004/)
Reason for revert:
Removing flag for M36.
Original issue's description:
> Rollback option for device reset put behind the flag.
>
> BUG=356728
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259841
TBR=nkostylev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356728
Review URL: https://codereview.chromium.org/220863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a function which installs a bookmark app that is created
from a WebApplicationInfo. This is part of an effort to consolidate
code that deals with bookmark apps and write tests for them and is part of
laying the groundwork for syncing of bookmark apps.
BUG=318607
Review URL: https://codereview.chromium.org/202523011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now I am implementing the leak detector on content_shell. In this
process, I found that there were some sites in top 25 which seemed to
leak DOM objects, which means that DOM objects were increased and not
released after loading those pages. The aim of CL is to watch the memory
usage of those sites at chromeperf.appspot.com and to check if those sites
cause soft or hard leaks.
I refered another CL: https://codereview.chromium.org/170453002
BUG=332630
Review URL: https://codereview.chromium.org/208793007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In GLImageShm, use glTexSub instead of glTex during binding,
as it is more efficient and avoids gpu-workarounds.
BUG=357493
Review URL: https://codereview.chromium.org/216873003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
installed, and will indicate that the service worker failed if it rejects a promise.
BUG=356021
Review URL: https://codereview.chromium.org/212593010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=347709
Review URL: https://codereview.chromium.org/205743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserView::CanActivate() ensures that a browser window cannot be activated for long while a JS alert is visible.
This CL prevents user interaction during the short time that the window is active. This hack is not necessary for Windows Aura
BUG=349970
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/216303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nothing but an internal buildbot relies on this (the internal buildbot is
updated in https://chrome-internal-review.googlesource.com/158855 to
source the file explicitly).
If you use functions in this script, you can source it yourself. If you do this,
please let me know, else I'm going to delete adb_device_functions.sh once
the internal waterfalls are on recipes.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/218733008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can use UINT32_C from <stdint.h>, since we force-define
__STDC_CONSTANT_MACROS.
As a "drive-by", also remove all the other uses of GG_... from
media/cast (since I'll do it later anyway).
R=hclam@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/219723003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the HTML page to return a string in window.returnValue.
In that case, the return value is set to HTML_DLG_EXTRA and
GetExtraResult returns the string.
BUG=341353
NOTRY=true
Review URL: https://codereview.chromium.org/212613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of UI thread).
jar fround in about:profiler, StartupTimeBomb::DeleteStartupWatchdog is
taking long time. We have found we are generating crash dump on UI
thread which could access disk and thus making UI thread janky.
R=jar@chromium.org
Review URL: https://codereview.chromium.org/214713009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was broken recently with a change that assumed the draggable
regions are static.
BUG=358071
Review URL: https://codereview.chromium.org/220363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=139170
Review URL: https://codereview.chromium.org/220463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=139170
Review URL: https://codereview.chromium.org/217793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor hybrid slow start in QUIC to create a simpler interface between
it an TCPCubicSender.
In preparation for BBR.
Merge internal change: 64031462
https://codereview.chromium.org/218993002/
Don't log decryption errors in AeadBaseDecrypter::Decrypt.
Instead, have QuicFramer::DecryptPayload log a warning message if both
trial decryptions fail.
Merge internal change: 63977728
https://codereview.chromium.org/218983002/
QUIC refactor to remove a return value which was always true.
Merge internal change: 63977684
https://codereview.chromium.org/218913003/
Simplify the bytes_consumed computation
in QuicPacketCreator::CreateStreamFrame. Does not change behavior.
Merge internal change: 63900899
https://codereview.chromium.org/218873003/
Fixing a broken test for quic. cr/63542972 added the proxy flag on
outbound packets. Unfortunately, this broke our tests using the magic
header. This CL provides hooks for clearing that bit of data.
Adding a virtual function to quic client so we can fix a test.
Merge internal change: 63898585
https://codereview.chromium.org/218963003/
+ Use QuicServerKey tuple (host, port, is_https) instead of
server_hostname, while creating QuicClientSession,
QuicCryptoClientStream, QuicCryptoClientConfig, QuicClient,
QuicTestClient, etc objects.
+ QuicServerKey is used as the key to access QUIC server
config information from all caches.
+ Added couple of new unit tests for HostPortPair class.
+ Added unit tests for QuicServerId for privacy mode
combination with host, port, is_https.
Merge internal change: 63891842
https://codereview.chromium.org/218923002/
R=rch@chromium.org
Review URL: https://codereview.chromium.org/216713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260810 0039d316-1c4b-4281-b951-d872f2087c98
|