summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add missing dependencies on mojo_system_placeholder.Colin Blundell2015-01-083-0/+8
| | | | | | | | | | | | | | These targets use headers from mojo_system and thus need to obtain the settings that the mojo_system target passes on to its direct dependents. As they cannot depend on mojo_system or mojo_system_impl, they instead are made to depend on mojo_system_placeholder, which is currently empty but will in the near future have settings to pass on to its direct dependents. R=jamesr@chromium.org, ncbray@chromium.org, teravest@chromium.org Review URL: https://codereview.chromium.org/840543004 Cr-Commit-Position: refs/heads/master@{#310463}
* Revert of [Extensions Toolbar] Cleanup browser_action_test_util (patchset #2 ↵henrika2015-01-088-39/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:80001 of https://codereview.chromium.org/835173002/) Reason for revert: Several tab_capture_end2end_tests were reported failing and I could only suspect this CL. See e.g. https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.8%20Release%20%28Intel%29/builds/33421 and https://build.chromium.org/p/chromium.gpu/builders/Win8%20Release%20%28NVIDIA%29/builds/10298 Original issue's description: > [Extensions Toolbar] Cleanup browser_action_test_util > > Remove BrowserActionTestUtil::[Disable|Enable]Animations() and > BrowserActionTestUtil::SetIconVisibilityCount(). These just performed > single-line actions that were already platform-independent, and so the callers > can just inline it. > > Committed: https://crrev.com/26d59a62cda9684c058676e187bdf4481bcc055c > Cr-Commit-Position: refs/heads/master@{#310428} TBR=finnur@chromium.org,avi@chromium.org,rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/822803004 Cr-Commit-Position: refs/heads/master@{#310462}
* Mixed Content: Create a strict-mode Setting. [2/3]mkwst2015-01-0811-0/+23
| | | | | | | | | | | | | | | | | | This is the Chromium-side of a patch introducing a strict-mode setting. It creates a new pref, wires the pref's value up to the setting from the first patch in the series, and creates LayoutTest hooks which the next patch will use to test the implementation. Patch 1: https://codereview.chromium.org/821383008/ Patch 2: [THIS PATCH] Patch 3: https://codereview.chromium.org/841693002 BUG=442662 NOTRY=true Review URL: https://codereview.chromium.org/842643002 Cr-Commit-Position: refs/heads/master@{#310461}
* Automated Commit: Committing new LKGM version 6664.0.0 for chromeos.chromeos-commit-bot2015-01-081-1/+1
| | | | Cr-Commit-Position: refs/heads/master@{#310460}
* [MacViews] Fix BrowserActionApiTest.DynamicBrowserAction.jackhou2015-01-081-1/+1
| | | | | | | | | | | When toolkit-views becomes available on Mac, the browser will still use the Cocoa UI. BUG=404979 Review URL: https://codereview.chromium.org/821753004 Cr-Commit-Position: refs/heads/master@{#310459}
* Remove the "Access your input devices" permission message.reillyg2015-01-083-5/+2
| | | | | | | | | | | | | | | | | | | As with the "Access your USB devices" permission message that was removed in 400b26297782e70ed15e40d83b876e3abde7b9cc this permission message duplicates the messages generated by the "usbDevices" permission. I also consider it "overly alarmist" as the use case for the chrome.hid API is often unrelated to input devices. For example, the blink(1) sample app* has following single permission string after this change, "Access any blink(1) from ThingM via USB." * https://chrome.google.com/webstore/detail/kcpjgiicabigbjejdjnkflkdkjknkdch BUG= Review URL: https://codereview.chromium.org/840983002 Cr-Commit-Position: refs/heads/master@{#310458}
* [chromedriver] Disable broken tests.samuong2015-01-081-0/+4
| | | | | | | | | | BUG= TBR=stgao@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/814233004 Cr-Commit-Position: refs/heads/master@{#310457}
* Draw center first in NineImagePainterqiankun.miao2015-01-081-2/+2
| | | | | | | | | | | Draw center first in NineImagePainter to match the documentation. This is regression caused in r308440. BUG=None Review URL: https://codereview.chromium.org/833313002 Cr-Commit-Position: refs/heads/master@{#310456}
* Create initial settings UI for wallet integration.estade2015-01-084-0/+62
| | | | | | | | | | Due to lack of mocks, this is the simplest and ugliest UI imaginable. BUG=446698 Review URL: https://codereview.chromium.org/839683002 Cr-Commit-Position: refs/heads/master@{#310455}
* Fix embedder URL in ProtectedMediaIdentifierInfoBarDelegate::SetPermission().xhwang2015-01-081-1/+1
| | | | | | | | | BUG=446987 TEST=Manually tested with repro steps in the bug. Review URL: https://codereview.chromium.org/838683003 Cr-Commit-Position: refs/heads/master@{#310454}
* Revert of Partial revert of "Enable 3rd party support for Security Keys." ↵arnarb2015-01-081-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/814103003/) Reason for revert: Re-reverting, as original bug (crbug.com/443400) has been identifed as a bug in Hangouts, and this is a blocker for M41 beta release. Original issue's description: > Partial revert of "Enable 3rd party support for Security Keys." > > Enabling access to Security Keys from all urls broke the Hangout Services > component extension, so this CL limits externally_connectable to the > original whitelist. > > BUG=443400,426358 > > Committed: https://crrev.com/18c0f3662d7716a045a601fcc0c8bd856fe1f5db > Cr-Commit-Position: refs/heads/master@{#309237} TBR=xiyuan@chromium.org,juanlang@chromium.org,kalman@chromium.org,vrk@chromium.org NOTREECHECKS=true NOTRY=true BUG=443400,426358 Review URL: https://codereview.chromium.org/825273003 Cr-Commit-Position: refs/heads/master@{#310453}
* Rename CreateSession() to CreateSessionAndGenerateRequest()jrummell2015-01-0819-116/+108
| | | | | | | | | | | Also reorders the parameters so that |session_type| comes first. BUG=428384 TEST=existing EME tests pass Review URL: https://codereview.chromium.org/825533003 Cr-Commit-Position: refs/heads/master@{#310452}
* VideoToolbox only supports 4:2:0 chroma.sandersd2015-01-081-3/+7
| | | | | | | | | | | This change removes support for profiles that allow 4:2:2 or 4:4:4 chroma, allowing for regular fallback for such videos. BUG=446631 Review URL: https://codereview.chromium.org/839893003 Cr-Commit-Position: refs/heads/master@{#310451}
* DriveAPI: Add two request classes inheriting MultipartUploadRequestBase for ↵hirono2015-01-083-4/+173
| | | | | | | | | | | | | | multipart uploading. * MultipartUploadNewFileRequest * MultipartUploadExistingFileRequest BUG=269922 TEST=None Review URL: https://codereview.chromium.org/811453003 Cr-Commit-Position: refs/heads/master@{#310450}
* Roll src/third_party/WebKit 55c433b:db844cf (svn 188007:188016)blink-deps-roller2015-01-081-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/55c433b..db844cf TBR=falken@chromium.org,jsbell@chromium.org Review URL: https://codereview.chromium.org/827423005 Cr-Commit-Position: refs/heads/master@{#310449}
* ozone: xkb: Load keymaps on worker thread & cache themfengyuan2015-01-084-22/+174
| | | | | | | | | | | | 1. Free xkb keymaps in the destructor. 2. Moves kemap load into another worker thread. 3. Adds keymap caching. BUG=430194 Review URL: https://codereview.chromium.org/842603002 Cr-Commit-Position: refs/heads/master@{#310448}
* Cleanup: Remove if (!CurrentlyOn()) PostTask() pattern in EmbeddedWorkerInstancekinuko2015-01-082-73/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | Per discussion on chromium-dev (https://groups.google.com/a/chromium.org/d/msg/chromium-dev/uWGNk-hVlGc/M92wu3izhGEJ) I'm removing following code pattern from non-thread-safe code. void DoSomething() { if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) { BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, base::Bind(DoSomething); return; } ... } This pattern is handy, but this could mislead readers to think that the method can be called from any threads, while it's not. (We use similar patterns a lot in ServiceWorkerContextWrapper, but the class is intended to be thread-safe so I think the usage there should be ok) BUG=N/A TEST=existing tests Review URL: https://codereview.chromium.org/796393005 Cr-Commit-Position: refs/heads/master@{#310447}
* cc: Move tiling raster tile iterator to be a tiling set queue class.vmpstr2015-01-088-472/+424
| | | | | | | | | | | | This patch moves tiling raster tile iterator and makes it a private class of the tiling set raster queue. This reduces the public interface for accessing tiles. R=danakj, reveman Review URL: https://codereview.chromium.org/800853007 Cr-Commit-Position: refs/heads/master@{#310446}
* Fix the wrong relative coordinates from EventDispatchmyid.shin2015-01-084-15/+53
| | | | | | | | | | | | | | | | | | The problem is that the event's coordrinates are moved to the negative location when testing MouseLeaveTest.MouseDownOnBrowserCaption in interactive_ui_tests. Becasue it tries to calculate the relative coordinates one more in WindowEventDispatcher::DispatchMouseEnterOrExit if target window is null. We should use the target window from PreDispatchMouseEvent to prevent that window is null. BUG=409601 R=sky@chromium.org TEST=WindowEventDispatcherTest.MouseEventWithoutTargetWindow Review URL: https://codereview.chromium.org/754013007 Cr-Commit-Position: refs/heads/master@{#310445}
* Fix for PDF menu should not come when mouse pointer is on the scroll bar.deepak.m12015-01-082-8/+23
| | | | | | | | | | | PDF menu comes when mouse came in the PDF menu rect. Changes done to stop call to handle event by toolbar when mouse pointer is on any of the scroll bar. BUG=80214 Review URL: https://codereview.chromium.org/811083004 Cr-Commit-Position: refs/heads/master@{#310444}
* ash: Use skia::RefPtr instead of manually calling unref().tfarina2015-01-081-9/+9
| | | | | | | | | | | | | | | | According to https://chromium.googlesource.com/chromium/src/+/master/skia/ext/refptr.h#40, we should never call unref() on the underlying ref-counted pointer. By using AdoptRef(), skia::RefPtr will take care of that for us automatically. BUG=None R=sky@chromium.org Review URL: https://codereview.chromium.org/812333003 Cr-Commit-Position: refs/heads/master@{#310443}
* Clean up RenderWidgetHostImpl::WaitForSurfaceccameron2015-01-081-33/+19
| | | | | | | | | | | | | | | | | | | | | | Remove comments talking about backing stores, because they are no longer a thing. Don't break if WaitForSingleTaskToRun returns false, because that function only promises to wait "at most" the timeout specified -- it could return immediately, with no task having ran. Change the return on success to a break, since the return will miss the UMA statistics. Use Now() for the UMA statistics, because the path where a surface is found will not update the time to reflect the time it took to wait for the message, and to put the frame on screen. BUG= Review URL: https://codereview.chromium.org/844493002 Cr-Commit-Position: refs/heads/master@{#310442}
* [Cleanup] Add CreateWebContentsWithID helper to TabStripModelTestjohnme2015-01-081-27/+18
| | | | | | | | | Since SetID is usually called immediately after CreateWebContents, this lets you do both at once to improve legibility/conciseness. Review URL: https://codereview.chromium.org/800193006 Cr-Commit-Position: refs/heads/master@{#310441}
* Add some debugging checks to help find repro for crash during child frame ↵nasko2015-01-081-3/+5
| | | | | | | | | | creation. BUG=397744 Review URL: https://codereview.chromium.org/841853002 Cr-Commit-Position: refs/heads/master@{#310440}
* Show progress bar as soon as task starts.smckay2015-01-081-6/+15
| | | | | | | | | BUG=420680 TEST=browser_test: FileManagerJsTest.* Review URL: https://codereview.chromium.org/844603002 Cr-Commit-Position: refs/heads/master@{#310439}
* Remove chrome/browser/chromeos/login/screens/kiosk_autostart_screen_actor.hsatorux2015-01-081-39/+0
| | | | | | | | | | The code is no longer used. BUG=none Review URL: https://codereview.chromium.org/838713003 Cr-Commit-Position: refs/heads/master@{#310438}
* Fix weird includes of extension_prefs_unittest.hsatorux2015-01-085-5/+5
| | | | | | | | | | | Having /./ in #includes paths is weird and not necessary. BUG=313284 TEST=everything builds as before Review URL: https://codereview.chromium.org/827843005 Cr-Commit-Position: refs/heads/master@{#310437}
* link in stub impl for new porting-layer apireed2015-01-082-0/+4
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/820493005 Cr-Commit-Position: refs/heads/master@{#310436}
* Revert of Set PAGE_TRANSITION_RELOAD in ↵dtrainor2015-01-082-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NavigationControllerImpl::LoadIfNecessary (patchset #5 id:80001 of https://chromiumcodereview.appspot.com/817213002/) Reason for revert: It looks like this broke a downstream test. The CHECK_NE is being hit and it's crashing. The test is called TabUmaTest#testTabBackgroundLoadStatus. Reverting it to be safe. Original issue's description: > Set PAGE_TRANSITION_RELOAD in NavigationControllerImpl::LoadIfNecessary > > For now, page transition type isn't updated in > NavigationControllerImpl::LoadIfNecessary even though the navigation is actually > reloading. > So we need to change page transition type to PAGE_TRANSITION_RELOAD to handle > this navigation properly. > > BUG=443132 > > Committed: https://crrev.com/ccf6cd8426cba738164cf73e5a8f7a677a2be9ed > Cr-Commit-Position: refs/heads/master@{#310391} TBR=mkosiba@chromium.org,thakis@chromium.org,sadrul@chromium.org,jochen@chromium.org,creis@chromium.org,jaekyun@chromium.org NOTREECHECKS=true NOTRY=true BUG=443132 Review URL: https://codereview.chromium.org/823683006 Cr-Commit-Position: refs/heads/master@{#310435}
* Use Xvfb in isolated testing only if use_x11 is setspang2015-01-0815-213/+209
| | | | | | | | | | | | | | | We don't need a virtual X server for ozone testing, and it is causing problems running the tests with swarming. This changes all isolate files to only run Xvfb if use_x11==1 is set in GYP_DEFINES, and merges ozone with Windows & Mac (none of which need to run their own display server). BUG=440882 TEST=isolate.py run -s out_ozone/Debug/<various> TBR=maruel@chromium.org Review URL: https://codereview.chromium.org/813363003 Cr-Commit-Position: refs/heads/master@{#310434}
* IndexedDB: Added histogram description: OpenCleanupBlobJournalFailed.cmumford2015-01-081-0/+3
| | | | | | | | | Adding histogram value description for IDBLevelDBBackingStoreOpenResult#15. This should have been part of r273048. Review URL: https://codereview.chromium.org/841693004 Cr-Commit-Position: refs/heads/master@{#310433}
* Breakdown ClientLoadedTime histograms into buckets based on number of ↵aiolos2015-01-082-19/+62
| | | | | | | | | | | | clients. Fix RequestTimeThrottled histogram. BUG=424387 The current RequestThrottlingAndCoalescing finch trial data makes me want a break down for the number of tabs we're loading. Keeping the totals for each type of Clients, and adding in new histograms for a few interesting buckets (instead of breaking it down for each number of tabs like the SessionRestore histograms do.) Review URL: https://codereview.chromium.org/782903002 Cr-Commit-Position: refs/heads/master@{#310432}
* Prepare for libc++ clang build on Androidjdduke2015-01-082-2/+8
| | | | | | | | | | | Satisfy the clang/libc++ combination on Android by moving non-trivial constructors out of headers. BUG=427718 Review URL: https://codereview.chromium.org/838033003 Cr-Commit-Position: refs/heads/master@{#310431}
* Roll src/third_party/WebKit e91de1a:55c433b (svn 187992:188007)blink-deps-roller2015-01-081-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/e91de1a..55c433b TBR=falken@chromium.org,jsbell@chromium.org Review URL: https://codereview.chromium.org/824823004 Cr-Commit-Position: refs/heads/master@{#310430}
* Use json file to determine sdk packages to download.navabi2015-01-083-14/+23
| | | | | | | | BUG=350151 Review URL: https://codereview.chromium.org/842753002 Cr-Commit-Position: refs/heads/master@{#310429}
* [Extensions Toolbar] Cleanup browser_action_test_utilrdevlin.cronin2015-01-088-89/+39
| | | | | | | | | | | Remove BrowserActionTestUtil::[Disable|Enable]Animations() and BrowserActionTestUtil::SetIconVisibilityCount(). These just performed single-line actions that were already platform-independent, and so the callers can just inline it. Review URL: https://codereview.chromium.org/835173002 Cr-Commit-Position: refs/heads/master@{#310428}
* skia: Do not include a source file in another source file.tfarina2015-01-082-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | That can can a duplication of definition of symbols. This was exposed by https://chromium.googlesource.com/chromium/src/+/c87c3d2d949f9ba4f17627dc023b303c75b7635f in the Mac GN builder with errors like: duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in: obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o obj/skia/ext/skia.skia_utils_mac.o (and more similar issues). Entries were found with the following command line: $ g grep include skia/ext | grep mm\" BUG=444058 TEST=unit_tests R=thakis@chromium.org Review URL: https://codereview.chromium.org/832053004 Cr-Commit-Position: refs/heads/master@{#310427}
* Fixed GPU tracing so the categories do not get mixed.dyen2015-01-085-58/+62
| | | | | | | | | | | | | | | | | | | | | | | Because of how the chromium tracing macros work, it is not possible to use the same line for multiple tracing categories. I have moved the GPU categories to a separate trace arg "gl_categories" instead, and changed the trace categories back to gpu.device and gpu.service. GroupPushMarkerEXT calls can no longer be disabled by their category. We currently use these to trace top level GPU traces which are constructed before the tracing categories are initialized. There were also some other issues related to having multiple channels in the GPU Tracer. Now functions that query the current trace take in a channel argument as well to differentiate the channels. R=vmiura@chromium.org BUG=None TEST=trybots Review URL: https://codereview.chromium.org/813573003 Cr-Commit-Position: refs/heads/master@{#310426}
* [autofill] Use default country code in settings when none selected.rouslan2015-01-081-1/+1
| | | | | | | | | | | | | If you do not select a country when adding an address in autofill settings, then the default country code is used. This enables preserving the address format (field positions and labels) the next time you edit this address. BUG=445709 Review URL: https://codereview.chromium.org/794433004 Cr-Commit-Position: refs/heads/master@{#310425}
* Add cmumford to third_party/leveldatabase/OWNERSdgrogan2015-01-081-0/+1
| | | | | | | | NOTRY=true Review URL: https://codereview.chromium.org/839953002 Cr-Commit-Position: refs/heads/master@{#310424}
* [GCM] Add the dummy app handler when there is at least one handler.jianli2015-01-082-1/+8
| | | | | | | | | | | | | | | | The dummy app handler used to be added when there is only one handler in order to prevent GCM from being unloaded during the time the extension is being unloaded for update. Since now we have a built-in app handler GCMAccountMapper which makes the handler count be greater than one, we need to take this into account. BUG=447008 TEST=tests updated to expose this bug TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/841773004 Cr-Commit-Position: refs/heads/master@{#310423}
* Use DeviceMonitorWin to observe "UsbDevice" class devices.reillyg2015-01-081-1/+68
| | | | | | | | | | | | | | The version of libusb embedded in Chrome does not support hotplug events on Windows. As a workaround this patch sets up a class to observer a DeviceMonitorWin instance that is registered to receive events related to devices in the "UsbDevice" interface class. It then triggers a full re-enumeration of connected devices. BUG=411715 Review URL: https://codereview.chromium.org/837273003 Cr-Commit-Position: refs/heads/master@{#310422}
* Early error out if the 'msvs' is specified in GYP_GENERATORSscottmg2015-01-081-0/+7
| | | | | | | | | | | | This generator hasn't worked for a long time, but it's not obvious that it doesn't work which can be confusing. R=thakis@chromium.org BUG=446912 Review URL: https://codereview.chromium.org/797373004 Cr-Commit-Position: refs/heads/master@{#310421}
* Use server cards from database in Autofill dropdown.estade2015-01-0810-59/+211
| | | | | | | | BUG=437116 Review URL: https://codereview.chromium.org/834203002 Cr-Commit-Position: refs/heads/master@{#310420}
* Roll src/third_party/skia f4e5995:23d4320skia-deps-roller2015-01-081-1/+1
| | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/skia/+log/f4e5995..23d4320 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=caryclark@google.com Review URL: https://codereview.chromium.org/800963004 Cr-Commit-Position: refs/heads/master@{#310419}
* [Hotword] Don't show audio history setting if web history cannot be reached.rlp2015-01-081-3/+2
| | | | | | | | BUG=444918 Review URL: https://codereview.chromium.org/840883002 Cr-Commit-Position: refs/heads/master@{#310418}
* IndexedDB: Deprecated use of INDEXED_DB_BACKING_STORE_OPEN_FAILED_UNKNOWN_ERRcmumford2015-01-081-8/+2
| | | | | | | | This value cannot be recorded - verified by UMA. Review URL: https://codereview.chromium.org/835383005 Cr-Commit-Position: refs/heads/master@{#310417}
* Instrumenting URLRequestFileJob::ReadRawData internals for jank.vadimt2015-01-083-0/+16
| | | | | | | | | | | | | Prior instrumentations showed: URLRequestFileJob::ReadRawData = 16 jph Instrumenting further. BUG=423948 Review URL: https://codereview.chromium.org/792953004 Cr-Commit-Position: refs/heads/master@{#310416}
* [Telemetry] Move DismissCrashDialogIfNeeded call to android_platform.slamm2015-01-082-1/+1
| | | | | | | | | | | This is a follow-up to https://codereview.chromium.org/837073002. In that CL, access to platform_backend was removed from shared_app_state. BUG= Review URL: https://codereview.chromium.org/813963003 Cr-Commit-Position: refs/heads/master@{#310415}
* Instrumenting QuicStreamFactory::Job internals for jank.vadimt2015-01-082-0/+44
| | | | | | | | | | | | Prior instrumentations showed: 422516 QuicStreamFactory::Job::DoConnect = 36 jph 422516 QuicStreamFactory::Job::DoConnect2 = 4.3 jph BUG=422516 Review URL: https://codereview.chromium.org/830183002 Cr-Commit-Position: refs/heads/master@{#310414}
generated by cgit v1.1 at 2025-02-19 06:10:16 +0000