| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=479353
TBR=jochen for DEPS
Review URL: https://codereview.chromium.org/1099303002
Cr-Commit-Position: refs/heads/master@{#326369}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous only a single sad and lonely html file (main.html) from the
Chromoting webapp build was converted to GN. With this cl, then entirety
of the Chromoting webapp has been converted to GN and produces results
identical to the GYP build.
BUG=
Review URL: https://codereview.chromium.org/1087693003
Cr-Commit-Position: refs/heads/master@{#326368}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Interrupted downloads expose a "Learn more" URL which aims to help users
with resolving problems with their downloads. Add a context parameter so
that the browser can indicate the interrupt reason when opening the
page.
R=rdsmith@chromium.org
BUG=477418
Review URL: https://codereview.chromium.org/1084123004
Cr-Commit-Position: refs/heads/master@{#326367}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1081923003/)
Reason for revert:
Sorry for the delay! We are seeing these failures again: http://build.chromium.org/p/chromium.perf/builders/Win%20XP%20Perf%20%285%29?numbuilds=200
Original issue's description:
> Roll wpr to 13560f74b4f40f12108de7fc43f20b873471d48d.
>
> For a full list of changes, see
> https://github.com/chromium/web-page-replay/compare/4e4d540...13560f7
>
> BUG=478178
> TBR=nednguyen@google.com
>
> Committed: https://crrev.com/b3e3792583ffae2764e29f07fb279101281bc4d0
> Cr-Commit-Position: refs/heads/master@{#325954}
TBR=erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478178
Review URL: https://codereview.chromium.org/1098413002
Cr-Commit-Position: refs/heads/master@{#326366}
|
|
|
|
|
|
|
|
|
|
| |
Fix a recent use of MessageLoopProxy in test.
BUG=
Review URL: https://codereview.chromium.org/1063823007
Cr-Commit-Position: refs/heads/master@{#326365}
|
|
|
|
|
|
|
|
|
|
| |
TBR=tbreisacher@chromium.org
BUG=none
TEST=actually works
Review URL: https://codereview.chromium.org/1067853006
Cr-Commit-Position: refs/heads/master@{#326364}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/87cbcf3..bae6f6c
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com
Review URL: https://codereview.chromium.org/1087033005
Cr-Commit-Position: refs/heads/master@{#326363}
|
|
|
|
|
|
|
|
|
|
|
| |
To allow this helper function to also be used for writing to
discardable memory region.
BUG=
Review URL: https://codereview.chromium.org/1100463002
Cr-Commit-Position: refs/heads/master@{#326362}
|
|
|
|
|
|
|
|
| |
This better matches real usage and avoids asserts.
Review URL: https://codereview.chromium.org/1052233006
Cr-Commit-Position: refs/heads/master@{#326361}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using COM marshalling to share necessary worker thread pointers
with the render and capture threads.
BUG=422522
TEST=all unit tests pass, audio input and output work.
Review URL: https://codereview.chromium.org/1097553003
Cr-Commit-Position: refs/heads/master@{#326360}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements a minimal, in-memory version of WebBlobRegistry for
html_viewer based on the MockWebBlobRegistryImpl from content. The mock
only allowed adding and removing blobs. This implementation also adds
registering these blobs to URLs, and hacking the WebURLLoaderImpl to
serve these blob: urls.
With this patch, you can now navigate to individual Github project
pages without crashing. (Github uses WebBlobs to implement issue/pull
request counts on the right sidebar.)
BUG=none
Review URL: https://codereview.chromium.org/1072273004
Cr-Commit-Position: refs/heads/master@{#326359}
|
|
|
|
|
|
|
|
| |
BUG=446883
Review URL: https://codereview.chromium.org/1102603002
Cr-Commit-Position: refs/heads/master@{#326358}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:40001 of https://codereview.chromium.org/1100473004/)
Reason for revert:
all perf bots are purple
Original issue's description:
> [Android] Convert RestartAdbd to DeviceUtils.
>
> BUG=267773
>
> Committed: https://crrev.com/598af7c6bd830d6da9182d485842f7ca4e51a6b4
> Cr-Commit-Position: refs/heads/master@{#326304}
TBR=perezju@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=267773
Review URL: https://codereview.chromium.org/1104543003
Cr-Commit-Position: refs/heads/master@{#326357}
|
|
|
|
|
|
|
|
|
|
| |
It appears the onServerStarted function was not virtual
on Lollipop as it was very staticy and this caused JNI
to refuse to call it. Simple fix was to make it static.
Review URL: https://codereview.chromium.org/1065983009
Cr-Commit-Position: refs/heads/master@{#326356}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5a99872..ad9e2c5
TBR=aboxhall@chromium.org,rjwright@chromium.org
Review URL: https://codereview.chromium.org/1101673004
Cr-Commit-Position: refs/heads/master@{#326355}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No intended behavior change. This CL moves logic from
FastNavigationProfileExtender into ProfileExtender, and changes ProfileExtender
to take the variable |finder_options| as a parameter to the initializer, rather
than the Run() method.
BUG=
Review URL: https://codereview.chromium.org/1097493002
Cr-Commit-Position: refs/heads/master@{#326354}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added DefaultSessionStartContext for coordinating sending default
session back to PresentationDispatcher.
When ListenForDefaultSessionStart is called, DefaultSessionStartContext
will be installed on PresentationServiceImpl. When both the default
session and PresentationDispatcher's callback are available, the
callback will be invoked with the session.
On Reset(), if a callback is available, it will be invoked with null.
Changed PresentationDispatcher to not update Blink in that case.
Also, PSImpl now keeps track of the corresponding RFH's ID instead of
RFH* since most of the time we only need to use the ID.
Changed PresentationServiceDelegate's Add/RemoveObserver interface,
since the PresentationServiceDelegate need to be able to correlate
an Observer with a RFH. (at most 1 per RFH, as it stands today).
Added OnDefaultPresentationStarted to
PresentationServiceDelegate::Observer interface and implemented it
in PresentationServiceImpl.
Added tests in PresentationServiceImpl.
BUG=459001
Review URL: https://codereview.chromium.org/1073893003
Cr-Commit-Position: refs/heads/master@{#326353}
|
|
|
|
|
|
|
|
|
|
| |
- use of pointer after being freed.
BUG=
Review URL: https://codereview.chromium.org/1037023002
Cr-Commit-Position: refs/heads/master@{#326352}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It should not be necessary anymore.
We fixed the code that was making this necessary in WebRTC and Chromium.
Chromium: https://chromium.googlesource.com/chromium/src/+/3891bacf18a0fc5dfec32afc67c741728f8f1398
WebRTC: https://chromium.googlesource.com/external/webrtc/+/91543731c3a850dcc52ae63be8cc257e507fb72d
chromium-dev discussion: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/UXCHnX7pV44/discussion
BUG=169844
R=thakis@chromium.org
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/1086753005
Cr-Commit-Position: refs/heads/master@{#326351}
|
|
|
|
|
|
|
|
| |
BUG=474590
Review URL: https://codereview.chromium.org/1067593005
Cr-Commit-Position: refs/heads/master@{#326350}
|
|
|
|
|
|
|
|
|
|
| |
Local testing indicates these tests are 100% stable.
BUG=475940,474808, 392620
Review URL: https://codereview.chromium.org/1080393005
Cr-Commit-Position: refs/heads/master@{#326349}
|
|
|
|
|
|
|
|
| |
BUG=476496
Review URL: https://codereview.chromium.org/1056133006
Cr-Commit-Position: refs/heads/master@{#326348}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
live until DeleteProcThreadAttributeList is called.
An optimization in clang exposed this bug
(https://llvm.org/bugs/show_bug.cgi?id=23220).
Covered by existing tests: ProcessMitigationsTest.CheckDep
BUG=476316
Review URL: https://codereview.chromium.org/1077893005
Cr-Commit-Position: refs/heads/master@{#326347}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These two tests were converted to Robolectric junit tests. The
converted tests can be found in content/public/android/junit/ and
chrome/android/junit respectively. The converted tests are running
on the bots so these tests can be removed.
BUG=472151
Review URL: https://codereview.chromium.org/1096163004
Cr-Commit-Position: refs/heads/master@{#326346}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- AS::Read/AS::ReadMetadata/AS::ReadMetadataById only returns
attachments with model type reference.
- AS::ReadMetadataforSync only returns attachments with sync reference.
- AttachmentServiceImpl calls SetModelTypeReference in GetOrDownload.
- Renamed ReadMetadata/ReadAllMetadata to ReadMetadataById/ReadMetadata,
in hopes it makes more sense.
R=maniscalco@chromium.org
BUG=457735
TEST=Change is covered by sync_unit_tests. No observable external behavior.
Review URL: https://codereview.chromium.org/1095423003
Cr-Commit-Position: refs/heads/master@{#326345}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1087993003
Cr-Commit-Position: refs/heads/master@{#326344}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1065743003/)
Reason for revert:
Very sorry to have to revert this after so much work, but midi_unittests has been consistently broken on Android Tests bot e.g. https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/25597
Original issue's description:
> Web MIDI: split build rules for media/midi
>
> Split MIDI related stuffs from media as a component in build files.
> Also, MIDI related unit tests are split into midi_unittests.
>
> BUG=475869
> TEST=git cl try
>
> Committed: https://crrev.com/31624cad1a3b5cf26950b864837ba44b3aa38331
> Cr-Commit-Position: refs/heads/master@{#326247}
TBR=phajdan.jr@chromium.org,dalecurtis@chromium.org,dpranke@chromium.org,boliu@chromium.org,damienv@chromium.org,jam@chromium.org,thestig@chromium.org,lcwu@chromium.org,gunsch@chromium.org,toyoshim@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475869
Review URL: https://codereview.chromium.org/1085843003
Cr-Commit-Position: refs/heads/master@{#326343}
|
|
|
|
|
|
|
|
|
| |
BUG=456397
TEST=media_unittests and EME layout tests pass
Review URL: https://codereview.chromium.org/1096203004
Cr-Commit-Position: refs/heads/master@{#326342}
|
|
|
|
|
|
|
|
|
|
| |
BUG=474029
TEST=PartialCircularBufferTest.WrapTwiceWithSingleWrite
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1061053002
Cr-Commit-Position: refs/heads/master@{#326341}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing so can cause kernel panics on certain LGE devices, so collection of that
data will be skipped. Android kernel versions and seccomp prctl support will
still be collected.
BUG=478478,468455
R=jln@chromium.org
Review URL: https://codereview.chromium.org/1100933002
Cr-Commit-Position: refs/heads/master@{#326340}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The origin GURL needs to be stored along with the registration for
looking up service worker registrations (to start the necessary service worker and
fire its events).
BUG=479665
Review URL: https://codereview.chromium.org/1084043003
Cr-Commit-Position: refs/heads/master@{#326339}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following tests were affected:
unit_tests:
AttestationPolicyObserverTest.*
CryptohomeAuthenticatorTest.*
ExtensionCacheTest.*
EPKPChallengeMachineKeyTest.DevicePolicyDisabled
EPKPChallengeUserKeyTest.DevicePolicyDisabled
HeartbeatSchedulerTest.*
NetworkConfigurationUpdaterTest.*
PlatformVerificationFlowTest.*
StatusUploaderTest.*
ShutdownPolicyHandlerTest.*
UserManagerTest.*
browser_tests:
DeviceStatusCollectorTest.*
KioskAppManagerTest.*
KioskEnterpriseTest.*
KioskTest.*
KioskUpdateTest.*
BUG=433840
Review URL: https://codereview.chromium.org/1019283004
Cr-Commit-Position: refs/heads/master@{#326338}
|
|
|
|
|
|
|
|
|
|
| |
New discovery is used in content shell, extensions and chromecast. Once all embedders migrate to devtools_discovery, DevToolsTarget will be removed from content.
BUG=476496
Review URL: https://codereview.chromium.org/1056343004
Cr-Commit-Position: refs/heads/master@{#326337}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds new jni interface for java.lang.Runtime object for using
the functions totalMemory() and freeMemory(). This is first step
towards dumping java heap size on android to tracing. These will be
used by dump provider in base/trace_event (for overview the code will
look like this : crrev.com/1050233004).
BUG=477464
Review URL: https://codereview.chromium.org/1086943003
Cr-Commit-Position: refs/heads/master@{#326336}
|
|
|
|
|
|
|
|
|
|
|
| |
We're passing many tests that are marked as failing. We should increase
our coverage to test newly fixed tests.
BUG=479244
Review URL: https://codereview.chromium.org/1101483003
Cr-Commit-Position: refs/heads/master@{#326335}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b75f810..87cbcf3
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com
Review URL: https://codereview.chromium.org/1080673003
Cr-Commit-Position: refs/heads/master@{#326334}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since NavigatorHost interface doesn't take extra parameters yet, don't use a new blink instance when a request has the referrer set.
Also, update the user agent version so that Gmail doesn't give a warning.
BUG=479407
Review URL: https://codereview.chromium.org/1051273012
Cr-Commit-Position: refs/heads/master@{#326333}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome remembers decisions by the user to proceed through SSL errors.
However, it remembers this even after a good certificate has been seen
for the given host. This change removes all previous exceptions for a
given host after a good certificate is seen on a regular request,
but not on redirects.
In the SSLPolicy, this adds a call to RevokeUserAllowExceptions() on the
SSLHostStateDelegate when a request response begins. This removes all
prior exceptions for the specified host. However, there is currently no
similar plumbing for redirects, so until that plumbing is built,
revocation will not occur when a valid cert for a host is seen on
redirect.
BUG=473390
Review URL: https://codereview.chromium.org/1058003004
Cr-Commit-Position: refs/heads/master@{#326332}
|
|
|
|
|
|
|
|
|
|
| |
R=fukino@chromium.org
BUG=none
TEST=new compiler has less errors
Review URL: https://codereview.chromium.org/1061713006
Cr-Commit-Position: refs/heads/master@{#326331}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new key combo is Ctrl+Alt+Shift+L, and it only works at the network
screen. Also, it now displays a notification whether the new flow is
enabled or not.
BUG=462824
Review URL: https://codereview.chromium.org/1105523002
Cr-Commit-Position: refs/heads/master@{#326330}
|
|
|
|
|
|
|
|
| |
Install by placing in your <data_path>/Packages/User directory.
Review URL: https://codereview.chromium.org/1046933004
Cr-Commit-Position: refs/heads/master@{#326329}
|
|
|
|
|
|
|
|
|
|
| |
wasn't being cleared.
BUG=477188
Review URL: https://codereview.chromium.org/1101713002
Cr-Commit-Position: refs/heads/master@{#326328}
|
|
|
|
|
|
|
|
|
|
|
| |
from accessibility API in content_shell.
BUG=
R=dmazzoni
Review URL: https://codereview.chromium.org/1089503002
Cr-Commit-Position: refs/heads/master@{#326327}
|
|
|
|
|
|
|
|
|
|
|
|
| |
PhishingClassifierDelegateTest.NoScorer.
BUG=479757
TBR=hirono@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1095403006
Cr-Commit-Position: refs/heads/master@{#326326}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
desktop and Android to a new large_icon_service.
This is required since the Android implementation of the icon-based NTP will rely on custom Java code to render the fallback. As a result we want to share the logic needed to retrieve large icons and to compute the fallback style without needing them to go through the full-featured chrome://large-icon that performs the rendering of fallback icons. The Java code will hook directly into the large_icon_service.
This CL also fixes a bug, making sure only non-square icons can be returned as large icons.
Besides this, this CL doesn't change the behavior but will make it possible to add the large icon selection logic to large_icon_service where it can be shared with the Android code.
BUG=467712
Review URL: https://codereview.chromium.org/1092873002
Cr-Commit-Position: refs/heads/master@{#326325}
|
|
|
|
|
|
|
|
| |
quota.
Review URL: https://codereview.chromium.org/1068833003
Cr-Commit-Position: refs/heads/master@{#326324}
|
|
|
|
|
|
|
|
|
| |
BUG=476063
R=haraken@chromium.org
Review URL: https://codereview.chromium.org/1077793004
Cr-Commit-Position: refs/heads/master@{#326323}
|
|
|
|
|
|
|
|
|
|
| |
This will make it easier to debug what's going on when the test fails.
BUG=477653
Review URL: https://codereview.chromium.org/1054553004
Cr-Commit-Position: refs/heads/master@{#326322}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Launcher_SwitchTask user action records when a user activates an existing
window using an icon in the shelf.
TEST=ShelfViewTest.Launcher_ButtonPressedUserActionsRecordedWhenItemSelected
TEST=ShelfViewTest.Launcher_TaskUserActionsRecordedWhenItemSelected
TEST=ShelfViewTest.Launcher_ButtonPressed_MouseIsRecordedWhenIconActivatedByMouse
TEST=ShelfViewTest.Launcher_ButtonPressed_MouseIsRecordedWhenIconActivatedByTouch
TEST=ShelfViewTest.Launcher_LaunchTaskIsRecordedWhenNewWindowIsCreated
TEST=ShelfViewTest.Launcher_SwitchTaskIsRecordedWhenExistingWindowIsActivated
BUG=471354
Review URL: https://codereview.chromium.org/1097393002
Cr-Commit-Position: refs/heads/master@{#326321}
|
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org,skyostil@chromium.org,rmcilroy@chromium.org
BUG=477690
Review URL: https://codereview.chromium.org/1058873010
Cr-Commit-Position: refs/heads/master@{#326320}
|