| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1180001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1130008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
That way it is easier to keep track of those constants in reporting tools.
TEST=Covered with standard ui tests
Patch by Frank Mantek <fmantek@google.com>.
Review URL: http://codereview.chromium.org/811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31292
TEST=bookmark_bar_view_test and I also ran the test case. NTP and Bookmark manager also works.
Review URL: http://codereview.chromium.org/1084014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Although this doesn't change anything that we know of (and it's possible that no current plugin requires it), this makes our plugin loading more like it is in other Mac browsers, thus reducing the chances of weird, hard-to-track-down bugs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1141009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/1150007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=39057
Review URL: http://codereview.chromium.org/1074010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/1088007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes our Mac wmode hack--which prevents Flash from using "accelerated" QuickDraw mode, which is incredibly slow for us, but also prevents Flash 10.1 from using Core Animation in the same cases--conditional based on having both support for Core Animation mode in both Flash and Chromium, and on having a flag.
Once we are confident that there are no regressions preventing us from allowing Core Animation by default, the flag will be removed.
BUG=38932
TEST=Run with --enable-flash-core-animation and the current Flash 10.1 beta on 10.6; sites like YouTube should have negligable CPU usage.
Review URL: http://codereview.chromium.org/1115010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ajwong
Review URL: http://codereview.chromium.org/1082010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this in a
callback so that I can identify where the image is coming from.
[Reverter's note: There is nothing wrong with this CL per se, except that I'm going to
make it obsolete in my next checkin, so since noone is relying on this change yet, it
is better to revert it than to have a painful merge]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1167004
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1077011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
empty.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1155008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
adds a browser_main watch for me.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1153009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Disables the redraw timer for Core Animation plugins that aren't visibile; even though the timer isn't intended to be a long-term solution, this is a simple optimization for the short term.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1159003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL better maps C++ UITestSuite to python suite and C++ UITestBase
to python testcase. All one-time initializations go in the suite while
testcases are re-entrant now -- this is what fixes the crash.
Also:
- Cmdline flags to pyauto script (verbose, wait for attaching to debugger)
- Establish the setup of sys.path, so that it's setup correctly and tests
don't have to worry about it
- Create facitlites for PYAUTO_TESTS files inside script dirs (say
chrome/test/functional) which defines the tests to run.
- Restructure such that pyauto scripts can be run standalone as well as
using the pyauto.py script (like unittest.py). For example, a test could be
fired in any of the below ways:
# Run tests in a module ('bookmarks')
python pyauto_functional.py bookmarks
# Run tests in a test case ('bookmarks.BookmarksTest')
python pyauto_functional.py bookmarks.BookmarksTest
# Run a test ('bookmarks.BookmarksTest.testBasics')
python pyauto_functional.py bookmarks.BookmarksTest.testBasics
# Run directly from the test script
python bookmarks.py
python bookmarks.py bookmarks
python bookmarks.py bookmarks.BookmarksTest
python bookmarks.py bookmarks.BookmarksTest.testBasics
BUG=32292
TEST=python chrome/test/functional/bookmarks.py
Review URL: http://codereview.chromium.org/1126003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons in the top right corner of the Window.
BUG=9614
TEST=TEST=open AccExplorer, open the main chrome window, point it to one of the three buttons in the top-right corner, see if it shows the correct accessible names for each one.
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1076009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=maruel@chromium.org
Review URL: http://codereview.chromium.org/1173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1146007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38522
TBR=maruel
Review URL: http://codereview.chromium.org/1081015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1092008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/1175002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11246
TEST=browser_tests.exe --gtest_filter=Geol*
Review URL: http://codereview.chromium.org/1127001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this is the follow up to http://codereview.chromium.org/1037006 which added it on windows, and http://codereview.chromium.org/1127001 which added it to Mac.
BUG=11246
TEST=run browser with --enable-geolocation, open maps.google.com and click my location.
Review URL: http://codereview.chromium.org/1081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppress the leak in WifiDataProviderCommon::DoWifiScanTask (bug 38206)
Suppress the leak in browser_sync::SyncBackendHost::Core::NotifyFrontend (bug
38490)
BUG=39021,38206,38490
TBR=timurrrr
Review URL: http://codereview.chromium.org/1088010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
function names
(e.g. "0xdeadbeef void Foobar")
TBR=timurrrr
Review URL: http://codereview.chromium.org/1164006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed the bug ID for the IPC::ChannelProxy::Context::OnAddFilter suppression
(bug 39014)
Fixed the bug ID for the RenderThreadTest suppression (bug 39016)
BUG=38487,39014,39016
TBR=timurrrr
Review URL: http://codereview.chromium.org/1138008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Revert "Update fast/workers/worker-script-error.html expectations in Chromium. Expected results of this test need update due to WebKit change http://trac.webkit.org/changeset/56329 and reenanle WorkerTest.WorkerScriptError"
TBR=pfeldman
Review URL: http://codereview.chromium.org/1174001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38889
TBR=timurrrr
Review URL: http://codereview.chromium.org/1148008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Suppressed leaks in RenderViewTest::TearDown (bug 39007)
Suppressed leaks in TestingProfile::CreateBookmarkModel (bug 39009)
BUG=26920,39007,39009
Review URL: http://codereview.chromium.org/1073006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expected results of this test need update due to WebKit change http://trac.webkit.org/changeset/56329 and reenanle WorkerTest.WorkerScriptError
Nate, I found your name on WebKit Sheriff calendar so please update the expectations on the next WebKit roll.
BUG=38918
Review URL: http://codereview.chromium.org/1163001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It doesn't make sense to make this open the "Language Settings" preferenes windows (like on other platforms), since that panel
isn't implemented yet - http://crbug.com/23828.
Once that bug is fixed we can decide whether it make sense to
re-enable this item or change the context menu on OS X.
BUG=34512
TEST=Right click on a text input field on OS X, Spell Checking->Language settings menu item should be disabled. On Windows the item should be enabled.
Review URL: http://codereview.chromium.org/1161003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1084015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I landed a change that includes a typo. Sorry for your inconveniences.
TBR=ben
BUG=none
TEST=build fix
Review URL: http://codereview.chromium.org/1105013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 29631. This change adds a bool flag |need_elevation_| to notify when a button needs elevation to the NativeButton class and add shield icons to the following buttons.
- on the "Start Chromium" button on the first-run dialog when the "Make Chromium the default browser" checkbox is enabled.
- on the "Set as Default" button on the default browser infobar.
- on the "Make Google Chrome my default browser" button on the Basics tab of options.
BUG=29631
TEST=Launch Chrome when it is not set as a default browser and see the "Set as Default" button has a shield icon.
TEST=Launch Chrome when it is not set as a default browser and open the "Options" dialog, and see its "Make Google Chrome my default browser" button has a shield icon.
TEST=Launch Chrome with a '--first-run' option when it is not set as a default browser, and see its "Launch Chrome" button has a shield icon.
Review URL: http://codereview.chromium.org/661165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The proposal for the API is documented at:
http://dev.chromium.org/developers/design-documents/extensions/context-menu-api
Notable limitations in this initial implementation:
-No reliable way to get at the unique, actual node clicked on in contexts like
IMAGE/LINK/etc. We'll need to fix this in the long run - see the API proposal
page for some notes on this.
-No update or deleteAll methods ; the only way you can change items is to delete
by id and re-add.
-We aren't yet matching the UI goal of having the extension items at the
top level include the extension icon on the left. This will require a
refactoring of RenderViewContextMenu to steal some of the code from the
bookmarks bar context menus, which can display favicons.
-The only kind of parent->child menu that currently works is if you have
a single top-level parent, and only one level of children. (This is because
of how RenderViewContextMenu currently works)
-No browser tests that the menu items actually get drawn (will wait on those
until the above mentioned refactor is complete), or API tests (the API may
change a bit based on feedback, at which point I'll write more tests).
-Unit tests need to cover some more cases.
BUG=32363
TEST=Should be able to create context menus with this API.
Review URL: http://codereview.chromium.org/1042003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some websoket layout tests became flaky from r41818.
This is because it adds websocket throttling in WebSocketJob.
Make sure Close() will call OnClose() even if it is waiting resolving or waiting
in throttling queue, so that WebSocketJob is removed from throttling queue
and wake up next WebSocketJob.
r42074 was reverted because failure in SocketStreamMetrics::OnClose
on Linux Builder (Views dbg).
Ignore UMA record if the connection has not been established.
TBR=tyoshino
BUG=38397
TEST=layout tests websocket/tests passes
Review URL: http://codereview.chromium.org/1134004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=cpu@chromium.org, nsylvain@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1105012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38321
TEST=make a wmapro using windows media encoder, and play it with chromeos
Review URL: http://codereview.chromium.org/1107014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38595
TEST=trybots, manual
Review URL: http://codereview.chromium.org/1110007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1132006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This forces us to ignore dpi sizes > 96., like we do in other
places. It does allow smaller DPIs to work since that mostly
just makes fonts smaller.
BUG=26354
Review URL: http://codereview.chromium.org/1095004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Switches tests to default PatchProtocols=2.
BUG=none
TBR=amit
Review URL: http://codereview.chromium.org/1147008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the relevant Extension*.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/1117008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This hooks up all the chrome side plumbing, but there are a couple
webkit changes that need to happen for this to fully work.
BUG=14654
Review URL: http://codereview.chromium.org/1084003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Broke access-control-basic-whitelist-request-headers.html layout test.
BUG=22588
Review URL: http://codereview.chromium.org/1110012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38681
TEST=none
Review URL: http://codereview.chromium.org/1124005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/1097005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42303 0039d316-1c4b-4281-b951-d872f2087c98
|