| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
| |
R=tommycli@chromium.org
BUG=597880
Review URL: https://codereview.chromium.org/1837623002
Cr-Commit-Position: refs/heads/master@{#383402}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CreateRenderFrameFlags enum currently has only one value, which can
easily be replaced by a boolean. This CL is removing this enum in favor
of a bool value.
BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1833243002
Cr-Commit-Position: refs/heads/master@{#383401}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Initialize KioskAppData with existing cached crx;
- Extract meta data when the cached crx file is changed to ensure
meta data is always up-to-date with the crx;
Other changes:
- Use vector<scoped_ptr<>> instead of deprecated ScopedVector;
- Break down UpdateAppData into smaller chunks;
BUG=585143
Review URL: https://codereview.chromium.org/1833293002
Cr-Commit-Position: refs/heads/master@{#383400}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
/fastfail and /maxilksize:0x7ff00000 were added to the wrong place in
crrev.com/1816333002 and need to be moved/merged. Also, the
mini_installer link command removes executable_config (which suppresses
LNK4199 warnings) and then triggers those warnings so that suppression
needs to be added back in.
The /maxilksize argument is also changed to be consistent and to avoid
duplication.
This doesn't change build behavior at all, it just suppresses some
warnings and tidies up the configuration.
Review URL: https://codereview.chromium.org/1835603002
Cr-Commit-Position: refs/heads/master@{#383399}
|
|
|
|
|
|
|
|
|
|
|
| |
Since swapped out state on RenderFrameHost has been removed, there is
no longer usage of kSwappedOutURL and the code can safely be removed.
BUG=357747
Review URL: https://codereview.chromium.org/1833933002
Cr-Commit-Position: refs/heads/master@{#383398}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=GPU FYI linux bots
TBR=kbr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1834023002
Cr-Commit-Position: refs/heads/master@{#383397}
|
|
|
|
|
|
|
|
| |
R=dgozman@chromium.org,pfeldman@chromium.org
Review URL: https://codereview.chromium.org/1818533003
Cr-Commit-Position: refs/heads/master@{#383396}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we used on-click for user click events, which made touch screen interactions inconsistent. This change switches all on-click listeners to on-tap, which listens for a event that fires consistently on touch/click platforms.
Tested with the --simulate-touch-screen-with-mouse and enabling touch events in Chrome DevTools.
BUG=596844
Review URL: https://codereview.chromium.org/1839433002
Cr-Commit-Position: refs/heads/master@{#383395}
|
|
|
|
|
|
|
|
|
| |
BUG=598060
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/1837563003
Cr-Commit-Position: refs/heads/master@{#383394}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1832203002/ )
Reason for revert:
Reverting on behalf of svaldez. It's breaking something.
Original issue's description:
> Adding nist-pkits data files for iOS OpenSSL
>
> BUG=
>
> Committed: https://crrev.com/d4495227c6df738b6361994e984f84fa9adc802f
> Cr-Commit-Position: refs/heads/master@{#383391}
TBR=svaldez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1839493002
Cr-Commit-Position: refs/heads/master@{#383393}
|
|
|
|
|
|
|
|
|
| |
BUG=591884
R=mdempsky@chromium.org
Review URL: https://codereview.chromium.org/1840483002
Cr-Commit-Position: refs/heads/master@{#383392}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1832203002
Cr-Commit-Position: refs/heads/master@{#383391}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fec6b7295b30..72d786bdb93d
$ git log fec6b7295..72d786bdb --date=short --no-merges --format='%ad %ae %s'
CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org
Review URL: https://codereview.chromium.org/1835613003
Cr-Commit-Position: refs/heads/master@{#383390}
|
|
|
|
|
|
|
|
| |
BUG=597066
Review URL: https://codereview.chromium.org/1818273002
Cr-Commit-Position: refs/heads/master@{#383389}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When a menu option is selected, dispatching a CertificateActionEvent.
- Listening for that event from certificate_manager_page.js and opening
appropriate dialog.
- Also listening for the certificates-error event, such that the error dialog can
be shown.
BUG=547073
Review URL: https://codereview.chromium.org/1815733004
Cr-Commit-Position: refs/heads/master@{#383388}
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/chromium/src/+/5fc1fc6ee
BUG=581963
TBR=pdr@chromium.org
Review URL: https://codereview.chromium.org/1833993002 .
Cr-Commit-Position: refs/heads/master@{#383387}
|
|
|
|
|
|
|
|
|
|
|
| |
- Use WebState::GetView() instead of -[CRWWebController view]
- Use web::NavigationManager for navigation
BUG=597997
Review URL: https://codereview.chromium.org/1833983002
Cr-Commit-Position: refs/heads/master@{#383386}
|
|
|
|
|
|
|
|
|
|
|
| |
Eliminates a race condition in CustomTabActivityTest#testPrecreatedRenderer
by waiting for the new custom tab to open before asserting
BUG=597741
Review URL: https://codereview.chromium.org/1834783002
Cr-Commit-Position: refs/heads/master@{#383385}
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) remove "open in app" buttons
2) fix some two line control icons
R=dschuyler@chromium.org
BUG=597871
Review URL: https://codereview.chromium.org/1831243002
Cr-Commit-Position: refs/heads/master@{#383384}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since swapped out state on RenderFrameHost has been removed, there is
no longer usage of RenderFrameProxyHost transfering ownership and the
code can safely be removed.
BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1831233004
Cr-Commit-Position: refs/heads/master@{#383383}
|
|
|
|
|
|
|
|
|
| |
BUG=596650
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1832213002
Cr-Commit-Position: refs/heads/master@{#383382}
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure that |windowDidExitFullscreen| gets called after the fullscreen
transition is completed. Slightly speed up the animations on Yosemite.
BUG=593419
Review URL: https://codereview.chromium.org/1813693003
Cr-Commit-Position: refs/heads/master@{#383381}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/skia.git/+log/397536cabe12..2176f75b066d
$ git log 397536cab..2176f75b0 --date=short --no-merges --format='%ad %ae %s'
2016-03-25 benjaminwagner Remove Sk48Dot16. No longer used.
2016-03-25 brianosman Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago. However, the CPU builder fails when it sees Index8 (among other things), so change the code to fallback to GPU in that case. Additionally, if we're going to be mipping an sRGB image, don't use the CPU code (which is not yet gamma correct). Unfortunately, this means that we will often be using the GPU path, still - with recent codec changes, most images are coming in tagged as sRGB.
2016-03-25 benjaminwagner Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not overflow.
2016-03-25 brianosman SkMipMap::Build supports 1xN and Nx1 inputs, so remove the special case from the test harness. Update a no-longer-correct comment.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/1835683002
Cr-Commit-Position: refs/heads/master@{#383380}
|
|
|
|
|
|
|
|
|
|
| |
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
BUG=597636,597625
Review URL: https://codereview.chromium.org/1836603002
Cr-Commit-Position: refs/heads/master@{#383379}
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a script to run the Closure Compile for Chrome resources. It also updates the wiki to reflect this.
BUG=596944
Review URL: https://codereview.chromium.org/1829553002
Cr-Commit-Position: refs/heads/master@{#383378}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PepperWebPluginImpl seems to be double-destroyed in some renderer
crashes. However, I have not been able to track it down, since the
destruction occurs in a DeleteSoon queue.
This adds an explicit boolean to the destroy() method that should
trigger a CHECK if it is indeed double-destroyed.
BUG=588624
Review URL: https://codereview.chromium.org/1838613002
Cr-Commit-Position: refs/heads/master@{#383377}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the code would only force restart the timer in some cases,
this change causes the timer to be restarted in all cases where a
DoIOTask() is manually invoked.
It also changes ManageTimer() to ensure it's not basing the idle
timeout on a null/uninitialized |most_recent_work_| value.
BUG=594246
TEST=no more playback failures.
Review URL: https://codereview.chromium.org/1834683003
Cr-Commit-Position: refs/heads/master@{#383376}
|
|
|
|
|
|
|
|
|
|
| |
This unblocks removal of SkGLContext and its subclasses from the Skia lib. Using the null GrGLInterface here used to be problematic because its implementation stored its state globally, assuming there was only one instance. This is no longer the case.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1829363003
Cr-Commit-Position: refs/heads/master@{#383375}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.
On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.
More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD. This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.
Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.
BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on startup), set startup page to a non-EV HTTPS site. Start Chrome in Material Design mode. The infobar arrow should not intersect the lock icon.
Review URL: https://codereview.chromium.org/1832023002
Cr-Commit-Position: refs/heads/master@{#383374}
|
|
|
|
|
|
|
|
|
|
|
| |
It's not clear why Mojo runner disabled these, and I think
the mash runner just copied whatever the Mojo runner was doing.
BUG=None
Review URL: https://codereview.chromium.org/1835653002
Cr-Commit-Position: refs/heads/master@{#383373}
|
|
|
|
|
|
|
|
| |
BUG=579697
Review URL: https://codereview.chromium.org/1791443003
Cr-Commit-Position: refs/heads/master@{#383372}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split this out from:
https://codereview.chromium.org/1817693002/
BUG=540528
R=ojan@chromium.org,chrishtr@chromium.org
Review URL: https://codereview.chromium.org/1826323002
Cr-Commit-Position: refs/heads/master@{#383371}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a caller to extend the lifetime of a blob until the
downloads / resource loader subsystems take over. Without this, an
unfortunately timed revokeObjectURL() call from the originating page may
invalidate the URL before the download has a chance to start the
associated download request.
BUG=595305
Review URL: https://codereview.chromium.org/1829413002
Cr-Commit-Position: refs/heads/master@{#383370}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we are nearing the home stretch, switch to default again. It
was disabled so that we can control it via a server side experiment. But
now we are switching it back so that we get waterfall coverage.
BUG=7648
Review URL: https://codereview.chromium.org/1833153003
Cr-Commit-Position: refs/heads/master@{#383369}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch added keyboard accessibility to ConstrainedWindowButton.
ConstrainedWindowButton is used by WebUSB chooser bubble,
Geolocation permission bubble, etc. Previously, when trying to only
interact with these bubbles with the keyboard, there are no focus
styles. User should be able to press tab to navigate to buttons, and
see a visible focus state. It will allow the user to only use keyboard
to control the bubble, which improves the accessibility of the UI
that uses it.
BUG=596671
Review URL: https://codereview.chromium.org/1829393002
Cr-Commit-Position: refs/heads/master@{#383368}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now we collect the dialog latency data for the first time, that means it starts Chrome with MR extension, waits for 5s, and open MR dialog in each run. But we found a big variation on Windows for MR dialog latency, sometimes it takes less than 1s, sometimes it takes more than 4s. Moreover we believe this is not the normal use case.
In this change, we will not restart Chrome for each run, just open MR dialog and close it in each run, but discard the first result, since it will have big variation with the results from other runs. This is closer to the normal user case and hope we can get more stable performance results.
BUG=
Review URL: https://codereview.chromium.org/1817313002
Cr-Commit-Position: refs/heads/master@{#383367}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows them to be used with the idiomatic mojo::ConvertTo<Foo>() template.
(In particular, ConvertTo<Foo>(my_vector) matches my_vector to "const U&" to
determine which TypeConverter to call. If my_vector is either a "std::vector"
or a "const std::vector" it ends up looking for TypeConverter<Foo, std::vector>.
Since the second TypeConverter template parameter isn't const, the compiler
can't find our existing TypeConverter<Foo, const std::vector> functions. These
functions don't need their template parameter to be const std::vector, as they
use "const std::vector&" for their inputs regardless.)
BUG=none
TEST=compiles
Review URL: https://codereview.chromium.org/1832133002
Cr-Commit-Position: refs/heads/master@{#383366}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ShutdownWatcherHelper is only needed if we don't early return,
additionally the early return triggers a DCHECK because
ShutdownWatcherHelper gets destroyed on the UI thread, triggering a
threading assertion because it ends up calling Join().
Also add ScopedAllowIO, in case Terminate fails. If SessionEnding returns we're going to be destroyed by the OS anyway, so we don't really care about any additional IO.
BUG=none
TEST=none
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1839453002
Cr-Commit-Position: refs/heads/master@{#383365}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes the downloads input into a
secondary label and adds the secondary action
class to the change button.
BUG=597883
Review URL: https://codereview.chromium.org/1836583002
Cr-Commit-Position: refs/heads/master@{#383364}
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark..
One branch of control flow fails to destroy it, leaking native memory.
BUG=NONE
Review URL: https://codereview.chromium.org/1831183002
Cr-Commit-Position: refs/heads/master@{#383363}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=597794
TEST=deqp/texturefiltering_cube_*
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/1831833006
Cr-Commit-Position: refs/heads/master@{#383362}
|
|
|
|
|
|
|
|
|
|
|
|
| |
An absolute-positioned candidate should be considered only if it would
actually scroll with the scroller (otherwise the anchoring scroll will have no
effect on it).
BUG=594873
Review URL: https://codereview.chromium.org/1831993002
Cr-Commit-Position: refs/heads/master@{#383361}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.
Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}
Review URL: https://codereview.chromium.org/1805363002
Cr-Commit-Position: refs/heads/master@{#383360}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
turned off
A new class NoUnderlineClickableSpan which shows a
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/
This patch modified code which can re-use this class.
BUG=593547
Review URL: https://codereview.chromium.org/1774243003
Cr-Commit-Position: refs/heads/master@{#383359}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make content/gpu and content/plugin pass GN check. Significant work for most of content/test
Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve.
The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn
Renames the ui/events/ipc according to GN style.
Annotates all content and gpu visibility declarations with why the're there, and fixes some incorrect ones that people added without understanding.
Reland of https://codereview.chromium.org/1828483002/ with significant changes.
TBR=jschuh (non-security-sensitive ipc build changes)
Review URL: https://codereview.chromium.org/1833193002
Cr-Commit-Position: refs/heads/master@{#383358}
|
|
|
|
|
|
|
|
|
|
|
|
| |
of ModelTypeController.
Only change the place where to create, still need to figure
out where to trigger.
BUG=547087
Review URL: https://codereview.chromium.org/1763953002
Cr-Commit-Position: refs/heads/master@{#383357}
|
|
|
|
|
|
|
|
|
|
| |
This DEPS file temporary whitelists current includes.
BUG=597997
Review URL: https://codereview.chromium.org/1832153002
Cr-Commit-Position: refs/heads/master@{#383356}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the LoadNavigationErrorPage call from DidFinishDocumentLoad to
RunScriptsAtDocumentReady, because the former is in a
ScriptForbiddenScope and caused an assertion to be triggered in
blink::beforeCallEnteredCallback when the beforeunload listeners were
ran as a part of the navigation.
BUG=590634
Review URL: https://codereview.chromium.org/1837483002
Cr-Commit-Position: refs/heads/master@{#383355}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/skia.git/+log/d442d32335a1..397536cabe12
$ git log d442d3233..397536cab --date=short --no-merges --format='%ad %ae %s'
2016-03-25 cdalton Consolidate GPU buffer implementations
2016-03-25 msarett Compile default SkMovie on cmake
2016-03-25 scroggo Move SkRWBuffer.h to include/ and add SK_API
2016-03-25 halcanary SkPDF: draw{Image,Bitmap} always serializes early
2016-03-25 brianosman Revert of Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago. However, the CPU bu… (patchset #1 id:1 of https://codereview.chromium.org/1835003002/ )
2016-03-25 halcanary experimental/fiddle: update to work again
2016-03-25 brianosman Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago. However, the CPU builder fails when it sees Index8 (among other things), so change the code to fallback to GPU in that case. Additionally, if we're going to be mipping an sRGB image, don't use the CPU code (which is not yet gamma correct). Unfortunately, this means that we will often be using the GPU path, still - with recent codec changes, most images are coming in tagged as sRGB.
2016-03-25 benjaminwagner Don't convert to Sk48Dot16 in DrawOneGlyph.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/1835573003
Cr-Commit-Position: refs/heads/master@{#383354}
|
|
|
|
|
|
|
|
| |
TBR=szager@chromium.org
Review URL: https://codereview.chromium.org/1836593002 .
Cr-Commit-Position: refs/heads/master@{#383353}
|