summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Move use of ShutdownWatcherHelper after early returnsky2016-03-251-0/+1
| | | | | | | | | | | | | | | | | The ShutdownWatcherHelper is only needed if we don't early return, additionally the early return triggers a DCHECK because ShutdownWatcherHelper gets destroyed on the UI thread, triggering a threading assertion because it ends up calling Join(). Also add ScopedAllowIO, in case Terminate fails. If SessionEnding returns we're going to be destroyed by the OS anyway, so we don't really care about any additional IO. BUG=none TEST=none R=jam@chromium.org Review URL: https://codereview.chromium.org/1839453002 Cr-Commit-Position: refs/heads/master@{#383365}
* Include isolate.py in data for Android unit testsagrieve2016-03-241-0/+105
| | | | | | | | | | | This is required for any test that uses an .isolate to push files to the device (e.g. base_unittests). BUG=589318 Review URL: https://codereview.chromium.org/1784373002 Cr-Commit-Position: refs/heads/master@{#383127}
* Add documentation link to deprecated GYP warningmichaelpg2016-02-241-1/+3
| | | | | | | | BUG=585553 Review URL: https://codereview.chromium.org/1707533003 Cr-Commit-Position: refs/heads/master@{#377339}
* Move TestInfoExtractor to content_shelljochen2016-02-231-0/+2
| | | | | | | | | | | | it's only used from layout_test_browser_main.cc and has no other dependencies on the test_runner BUG=none R=avi@chromium.org Review URL: https://codereview.chromium.org/1724663003 Cr-Commit-Position: refs/heads/master@{#377011}
* Componentize IDR_NET_ERROR_HTML for sharing it with iOS.sdefresne2016-02-151-0/+1
| | | | | | | | | | | | | | | Componentize IDR_NET_ERROR_HTML and all the dependent resources to allow sharing them with iOS (this includes IDR_ERROR_NETWORK_GENERIC and IDR_OMNIBOX_SEARCH_BUTTON_LOUPE). Copy OWNERS from chrome/renderer/net/ for the new component. TBR=jochen@chromium.org BUG=568486 Review URL: https://codereview.chromium.org/1668963002 Cr-Commit-Position: refs/heads/master@{#375432}
* Add presubmit warning about deprecated compiled_resources.gypdbeam2016-02-101-0/+19
| | | | | | | | | | | Just use v2 instead ;) (compiled_resources2.gyp) R=maruel@chromium.org,cpu@chromium.org BUG=585553 Review URL: https://codereview.chromium.org/1686663002 Cr-Commit-Position: refs/heads/master@{#374762}
* Moving Gnubby* files to a new directory.joedow2016-02-081-1/+2
| | | | | | | | | | | | | | | | This CL moves the existing Gnubby files into a new security_key directory. Since I will be refactoring this and expanding the number of files, I thought it would be better to keep them orgainzed in a sub-directory vs. adding all of th files to the host root directory. Also needed to update the Presubmit file for the AllowScopedIO exception. BUG=584463 Review URL: https://codereview.chromium.org/1668393002 Cr-Commit-Position: refs/heads/master@{#374177}
* Centralize all gbm ozone host IPCrjkroege2016-02-041-1/+1
| | | | | | | | | | | | | Introduce a GpuThreadAdapter and implement it in the DrmGpuPlatformSupportHost to complete making host to GPU communication be pluggable and hence easily support traditional IPC, operation in MUS or Mojo IPC. BUG=558602 Review URL: https://codereview.chromium.org/1661783002 Cr-Commit-Position: refs/heads/master@{#373593}
* Restructure contents of blimp/engine.kmarshall2016-01-291-1/+1
| | | | | | | | | | | | | | | Restructure contents of blimp/engine folder. See crbug.com/581506 for more information on the eventual directory structure. Modify paths and ifdef guards as needed. Resolve various linter errors encountered along the way. Update PRESUBMIT.py banned function exemption with the new path. BUG=581506 R=haibinlu@chromium.org,phadjan.jr@chromium.org Review URL: https://codereview.chromium.org/1632803004 Cr-Commit-Position: refs/heads/master@{#372424}
* Don't check blink DEPS files for target LGTMjochen2016-01-291-1/+5
| | | | | | | | | | | | They're a mix of third_party/WebKit and src relative path names. Skipping them is still better than everybody using NOPRESUBMIT. BUG=545323 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1646873002 Cr-Commit-Position: refs/heads/master@{#372289}
* Exempt Cast ozone from log spam presubmit checkhalliwell2016-01-281-0/+1
| | | | | | | | | | | | ui/ozone/platform/cast is only built in chromecast builds, should be treated the same way as chromecast/ (it's only under ui/ozone as a convenience to ozone platform build logic). BUG= Review URL: https://codereview.chromium.org/1645573003 Cr-Commit-Position: refs/heads/master@{#372114}
* src/PRESUBMIT.py: do not trigger experimental or triggered buildersPaweł Hajdan, Jr2016-01-221-27/+0
| | | | | | | | | | | Depends on https://codereview.chromium.org/1587893003/ BUG=580556 R=tandrii@chromium.org Review URL: https://codereview.chromium.org/1620343003 . Cr-Commit-Position: refs/heads/master@{#370969}
* Add BlimpEngineConfig to verify command line switches and store configmarcinjb2016-01-151-0/+1
| | | | | | | | | | Initially this has the shared secret between the client and the engine. BUG=575421 Review URL: https://codereview.chromium.org/1489413005 Cr-Commit-Position: refs/heads/master@{#369861}
* Refactor ozone DrmDisplayHostManager for pluggable messagingrjkroege2016-01-141-1/+1
| | | | | | | | | | | | Modify DrmDisplayHostManager in Ozone so that messaging can be be dynamically configured as IPC or thread-hop as will be needed by MUS. BUG=558602 Review URL: https://codereview.chromium.org/1587503002 Cr-Commit-Position: refs/heads/master@{#369568}
* Add PRESUBMIT check to catch new usages of Pass().dcheng2015-12-181-6/+6
| | | | | | | | | | std::move() should be used instead of Pass(). BUG=557422 Review URL: https://codereview.chromium.org/1538783002 Cr-Commit-Position: refs/heads/master@{#366051}
* base: Introduce Process::GetPidInNamespace().nya2015-12-091-0/+1
| | | | | | | | | | | | On Chrome OS, we run several daemons as separate PID namespaces. This function converts system PID to namespace PID. BUG=567632 TEST=GetPidInNamespace() returns correct PID for proc in ns Review URL: https://codereview.chromium.org/1487273004 Cr-Commit-Position: refs/heads/master@{#363963}
* Rename MOVE_ONLY_TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03danakj2015-12-081-26/+0
| | | | | | | | | | | | | | | | This renames the macro to be more standard and express its intent and relationship to DISALLOW_COPY_AND_ASSIGN. It renames the macro to DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND, as it does what the old DISALLOW_COPY_AND_ASSIGN does, but also whitelists the type for Bind/Callback to try move it. R=Nico TBR=sky BUG=561749 Review URL: https://codereview.chromium.org/1501793003 Cr-Commit-Position: refs/heads/master@{#363712}
* Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.sdefresne2015-12-071-0/+1
| | | | | | | | | | | | Put iOS chrome://flags & chrome://ui-alternatives resources and strings to components/flags_ui so that they live close to the corresponding shared resources. BUG=554966 Review URL: https://codereview.chromium.org/1500533002 Cr-Commit-Position: refs/heads/master@{#363527}
* Update style guide URL.avi2015-11-241-2/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1473393002 Cr-Commit-Position: refs/heads/master@{#361431}
* Add additional hosts to hard-coded service URL presubmit checkreillyi2015-11-161-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | This adds additional domains to the root PRESUBMIT check, "_CheckHardcodedGoogleHostsInLowerLayers", based on hostnames currently used in Chromium. Previously, this check only validated that "google.com" was not hard-coded, but did not catch other common hostnames: - gstatic.com - googleapis.com - googlezip.net - googledrive.com - appspot.com Note that this check is non-blocking, only prompting the user with a warning before continuing the submit operation. BUG=164568 TEST=PRESUBMIT_test.py Review URL: https://codereview.chromium.org/1403673003 Cr-Commit-Position: refs/heads/master@{#359869}
* Remove an old, disabled presubmit check.thestig2015-11-131-3/+0
| | | | | | Review URL: https://codereview.chromium.org/1444453003 Cr-Commit-Position: refs/heads/master@{#359664}
* Remove unused OS_ANDROID_HOST GYP definepkotwicz2015-11-101-1/+0
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/1434543002 Cr-Commit-Position: refs/heads/master@{#358938}
* Presubmit enforce that DCHECK_IS_ON() does not forget the braces.danakj2015-10-261-1/+19
| | | | | | | | | | | | | If you forget the braces, then it will just ignore what was inside the #if, which is not what you wanted. Long awaited followup to https://codereview.chromium.org/842523002/ R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1407033004 Cr-Commit-Position: refs/heads/master@{#356099}
* Changed the CheckBaseMacrosInHeaders presubmit to pass over C++ commentsoysteine2015-10-221-1/+3
| | | | | | | | | R=dbeam@chromium.org,maruel@chromium.org BUG=545272 Review URL: https://codereview.chromium.org/1413263002 Cr-Commit-Position: refs/heads/master@{#355639}
* Add logging statements to track down why notifications may not respondpeter2015-10-201-0/+3
| | | | | | | | | | | | | | | | | | We've seen a number of reports where clicking on a notification does not actually result in the associated Service Worker event being executed. In an attampt to track down why this is happening, I'm adding some log statements to make Android logcat output more useful. These logs will add four messages to the Android logcat output for every notification that the user explicitly clicks on. (In addition to the hundreds displayed for other reasons.) We'll take them out when the issue has been resolved. BUG=534537 Review URL: https://codereview.chromium.org/1408983003 Cr-Commit-Position: refs/heads/master@{#355034}
* PRESUBMIT: Bark about DISALLOW_* macros without #include "base/macros.h"dbeam2015-10-161-0/+24
| | | | | | | | | | | | | I'm sick of enforcing this in like every code review. R=cpu@chromium.org,maruel@chromium.org TBR=phajdan.jr@chromium.org BUG=none TEST=PRESUBMIT_test.py Review URL: https://codereview.chromium.org/1411553003 Cr-Commit-Position: refs/heads/master@{#354607}
* Improve error messages from checkperms PRESUBMIT checkphajdan.jr2015-10-141-7/+7
| | | | | | | | BUG=423697 Review URL: https://codereview.chromium.org/1395493002 Cr-Commit-Position: refs/heads/master@{#353993}
* Upstream presubmit check for Android mdpi assets.agrieve2015-10-071-0/+21
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1386213002 Cr-Commit-Position: refs/heads/master@{#352831}
* Exclude third_party/WebKit from root presubmits.primiano2015-10-061-1/+2
| | | | | | | | | | | | | | | This avoids running the chromium's src/PRESUBMIT.py for third_party/WebKit. This is required after crrev.com/1382993004 which has un-blacklisted third_party/WebKit from the depot_tools blacklist. The final effect of this CL + crrev.com/1382993004 (depot_tools) should bring back to the original pre-merge state. BUG=539835,539768 Review URL: https://codereview.chromium.org/1391593002 Cr-Commit-Position: refs/heads/master@{#352584}
* [android] Change the recommended log tag format to "cr_foo"dgn2015-09-181-9/+16
| | | | | | | | | | | | | | | | | This is to ensure that log tags are not elided when retrieving logcat output from crash reports. The log function has been modified to make the transition easier and avoid specifying the prefix everywhere. This patch also moves some eliding testing from instrumentation tests to junit tests, and adds a test to ensure that the new tag format is not elided. BUG=533072 Review URL: https://codereview.chromium.org/1354723004 Cr-Commit-Position: refs/heads/master@{#349733}
* Add ScopedAllowIO in GnubbyAuthHandlerPosix::CreateAuthorizationSocket().sergeyu2015-09-161-2/+3
| | | | | | | | | | | | | | GnubbyAuthHandlerPosix listens to a unix socket on the IO the remoting host. It needs to be able to unlink() previously created socket. Deletion of a unix socket is a blocking operation because it may require disk IO, but moving GnubbyAuthHandlerPosix on a different thread would be overkill. BUG=509807 Review URL: https://codereview.chromium.org/1324763007 Cr-Commit-Position: refs/heads/master@{#349038}
* Update PRESUBMIT.py reference to android logging doc.Vincent Scheib2015-09-151-1/+1
| | | | | | | | | | | Doc was moved in https://codereview.chromium.org/1324943003 BUG= R=brettw@chromium.org Review URL: https://codereview.chromium.org/1310333005 . Cr-Commit-Position: refs/heads/master@{#348933}
* Don't trigger HW acceleration from Toasts on low-end devices.dskiba2015-08-141-0/+38
| | | | | | | | BUG=520600 Review URL: https://codereview.chromium.org/1276523003 Cr-Commit-Position: refs/heads/master@{#343518}
* Also blacklist functions ending in ForTests for production codejochen2015-07-271-1/+1
| | | | | | | | | R=mkwst@chromium.org BUG=none Review URL: https://codereview.chromium.org/1257863003 Cr-Commit-Position: refs/heads/master@{#340443}
* Fix encoding problem with json validation in PRESUBMIT.py.plundblad2015-07-231-9/+10
| | | | | | | | | | | | | | | | | The presubmit script was calling out to a subprocess to discard comments in json files. https://codereview.chromium.org/1253453002 exposed some encoding issue when sending the Unicode content back and forth. Rather than trying to figure out how to get that right, just import and use the json_comment_eater python module directly. BUG=513181 TESTED=git cl presubmit passed for the above-mentioned CL . Review URL: https://codereview.chromium.org/1248323002 Cr-Commit-Position: refs/heads/master@{#340071}
* Hook up test runner to new layout_test_html_viewerjochen2015-07-101-0/+2
| | | | | | | | | | | Use --content-handlers=text/html,mojo:layout_test_html_viewer to test BUG=478250 R=sky@chromium.org Review URL: https://codereview.chromium.org/1218323002 Cr-Commit-Position: refs/heads/master@{#338260}
* Improve the diagnostics for include order presubmit checksbrucedawson2015-06-301-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The information given by the presubmit checks when an include error violation is found is not always the clearest, especially to a new Chrome developer. The rules for determining which group a header file goes into are not immediately obvious and the warnings don't say whether the problem is a sort order or a group order. This change adds that information. It also puts the URL on a separate line for easier selection, especially important on Windows. The old output looks like this: ** Presubmit Messages ** Your #include order seems to be broken. Remember to use the right collation (LC_COLLATE=C) and check https://google-styleguide.googlecode.com m/svn/trunk/cppguide.html#Names_and_Order_of_Includes chrome\browser\task_manager\task_manager.cc:10 \ chrome\browser\task_manager\task_manager.cc:11 The new output looks like this: ** Presubmit Messages ** Your #include order seems to be broken. Remember to use the right collation (LC_COLLATE=C) and check https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes chrome\browser\task_manager\task_manager.cc:10: - c++ system include file in wrong block \ chrome\browser\task_manager\task_manager.cc:11: - line belongs before previous line Notice the explanations for why a line is highlighted, and the non-wordwrapped URL. R=maruel@chromium.org Review URL: https://codereview.chromium.org/1213113004 Cr-Commit-Position: refs/heads/master@{#336813}
* Support both list and dict format for builder configsergiyb2015-06-161-10/+7
| | | | | | | | | R=akuegel@chromium.org BUG=497243 Review URL: https://codereview.chromium.org/1186323002 Cr-Commit-Position: refs/heads/master@{#334569}
* Move copyright scanner script to tools/mnaganov2015-06-121-2/+2
| | | | | | | | | | | | | The script is used project-wide in Chromium. It used to be in android_webview/ because it was created as WebView-specific tool, but the kind of check it does is not actually specific to WebView. And for a long time already it also runs as part of global presubmit. BUG=486158 Review URL: https://codereview.chromium.org/1167093004 Cr-Commit-Position: refs/heads/master@{#334196}
* [Android log] Fix presubmit check reports in base packagedgn2015-06-121-35/+23
| | | | | | | | | | | | | The presubmit check stop warning about Log calls from classes in the org.chromium.base package. Also does some refactoring to simplify logging related checks BUG=498171 Review URL: https://codereview.chromium.org/1183493002 Cr-Commit-Position: refs/heads/master@{#334135}
* HTML exit reader view buttonmdjones2015-06-101-1/+3
| | | | | | | | | | | | | | | This change removes the 'view original' link and replaces it with a button that currently navigates to the original article but will eventually slide the view out of focus. The feedback form and close button now span the full width of a page while content is limited to 800px wide. BUG=428533 Review URL: https://codereview.chromium.org/1160113004 Cr-Commit-Position: refs/heads/master@{#333759}
* [Android log] Promote using hardcoded string tagsdgn2015-06-101-1/+80
| | | | | | | | | | | | | | | This is to avoid static initializers that would make the code slower. See the linked bug for discussion. This patch deprecates Log#makeTag(String) and adds presubmit checks to enforce at submit time what makeTag was trying to do: length and naming rules BUG=485772 Review URL: https://codereview.chromium.org/1131903007 Cr-Commit-Position: refs/heads/master@{#333710}
* Re-land: Use script in depot_tools to retrieve builders from new cq.cfgsergiyb2015-06-031-25/+26
| | | | | | | | | | | | | | | | | This was already landed twice before: - https://codereview.chromium.org/1152823005/ - https://codereview.chromium.org/1148303006/ This CL is idential to the previous one, but a fix was landed to depot_tools: - https://codereview.chromium.org/1162993005/ TBR=phajdan.jr@chromium.org, jochen@chromium.org TEST=ran git-cl-try on this CL on Win, Mac and Linux and also tested with devs for which it failed last time Review URL: https://codereview.chromium.org/1148813006 Cr-Commit-Position: refs/heads/master@{#332654}
* Revert of Re-land: Use script in depot_tools to retrieve builders from new ↵peter2015-06-021-26/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cq.cfg (patchset #2 id:20001 of https://codereview.chromium.org/1148303006/) Reason for revert: Breaks the "git cl try" command, see chromium-dev@ and crbug.com/495219. Traceback (most recent call last): File "/b/depot_tools/commit_queue.py", line 28, in <module> from cq_client import cq_pb2 File "/b/depot_tools/third_party/cq_client/cq_pb2.py", line 9, in <module> from google.protobuf import symbol_database as _symbol_database ImportError: cannot import name symbol_database BUG=495219 Original issue's description: > Re-land: Use script in depot_tools to retrieve builders from new cq.cfg > > TBR=akuegel@chromium.org, jochen@chromium.org > TEST=ran git-cl-try on this CL on Win, Mac and Linux > > Committed: https://crrev.com/2c7fb79b2aad9d924dcbcd663e09f3022884f502 > Cr-Commit-Position: refs/heads/master@{#332369} TBR=akuegel@chromium.org,jochen@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1160783004 Cr-Commit-Position: refs/heads/master@{#332384}
* Re-land: Use script in depot_tools to retrieve builders from new cq.cfgsergiyb2015-06-021-25/+26
| | | | | | | | | TBR=akuegel@chromium.org, jochen@chromium.org TEST=ran git-cl-try on this CL on Win, Mac and Linux Review URL: https://codereview.chromium.org/1148303006 Cr-Commit-Position: refs/heads/master@{#332369}
* Exclude .md files from version control conflict detection.dbeam2015-06-021-0/+4
| | | | | | | | | | | | Turns out top-level headers basically look exactly like a merge conflict marker. R=jlklein@chromium.org BUG=495338 Review URL: https://codereview.chromium.org/1153013005 Cr-Commit-Position: refs/heads/master@{#332313}
* Revert of Use script in depot_tools to retrieve builders from new cq.cfg ↵thakis2015-06-011-24/+25
| | | | | | | | | | | | | | | | | | | | | | | | | (patchset #10 id:180001 of https://codereview.chromium.org/1152823005/) Reason for revert: Speculative, looks like this broke `git cl try` for me (crbug.com/495219) Original issue's description: > Use script in depot_tools to retrieve builders from new cq.cfg > > R=pgervais@chromium.org > TEST=ran git-cl-try on this CL > > Committed: https://crrev.com/87e80c7a628381644013e3b96b437276d9b19bcd > Cr-Commit-Position: refs/heads/master@{#332200} TBR=jochen@chromium.org,brettw@chromium.org,cpu@chromium.org,jam@chromium.org,pgervais@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1147003007 Cr-Commit-Position: refs/heads/master@{#332232}
* Use script in depot_tools to retrieve builders from new cq.cfgsergiyb2015-06-011-25/+24
| | | | | | | | | R=pgervais@chromium.org TEST=ran git-cl-try on this CL Review URL: https://codereview.chromium.org/1152823005 Cr-Commit-Position: refs/heads/master@{#332200}
* [Android Log] Move Presubmit checks to upload time onlydgn2015-05-211-1/+1
| | | | | | | | | | | They are intended to be FYI checks. If they are ignored at upload time, submitting should still work. BUG= Review URL: https://codereview.chromium.org/1147103002 Cr-Commit-Position: refs/heads/master@{#330922}
* Subject .mm files to the header sorting presubmittapted2015-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | The presubmit is already robust to handle Objective-C .h files. Not checking .mm files just adds extra review burden. Plus I can't just press F5 in Sublime to sort lines in .mm files due to import vs include, so it actually needs some brainpower when adding something and I keep forgetting to do that. This adds .mm to the list of file extensions the header sorting presubmit checks for, and fixes the current mistakes to avoid annoying people on presubmit with this change. BUG=None TBR=keybuk@chromium.org,jamescook@chromium.org,stuartmorgan@chromium.org,xhwang@chromium.org,rsesek@chromium.org,zea@chromium.org R=thakis@chromium.org,jochen@chromium.org Review URL: https://codereview.chromium.org/1133713009 Cr-Commit-Position: refs/heads/master@{#330509}
generated by cgit v1.1 at 2024-06-03 17:33:23 +0000