summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Revert of Start building ui_base_unittests targets. (patchset #1 id:1 of ↵perkj2014-09-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/600833002/) Reason for revert: Breaks Android waterfall. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Original issue's description: > Start building ui_base_unittests targets. > > This is in preparation for updating the buildbot code. First we need to > make sure we build those targets, otherwise buildbot will fail. > > BUG=331829,373148,299841,103304 > TEST=None > R=sky@chromium.org,maruel@chromium.org > > Committed: https://crrev.com/430fc906824927713d5a318afb50654e95b699b0 > Cr-Commit-Position: refs/heads/master@{#296877} TBR=cjhopman@chromium.org,sky@chromium.org,maruel@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=331829,373148,299841,103304 Review URL: https://codereview.chromium.org/603413002 Cr-Commit-Position: refs/heads/master@{#296903}
* Start building ui_base_unittests targets.tfarina2014-09-261-0/+1
| | | | | | | | | | | | | This is in preparation for updating the buildbot code. First we need to make sure we build those targets, otherwise buildbot will fail. BUG=331829,373148,299841,103304 TEST=None R=sky@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/600833002 Cr-Commit-Position: refs/heads/master@{#296877}
* Remove presubmit exception for the test runner libraryjochen2014-09-251-3/+3
| | | | | | | | | | | It should be all chromium style now. BUG=324658 R=mkwst@chromium.org Review URL: https://codereview.chromium.org/606563004 Cr-Commit-Position: refs/heads/master@{#296704}
* Added PRESUBMIT check running gclient VERIFY.tandrii2014-09-231-0/+16
| | | | | | | | BUG=371012 Review URL: https://codereview.chromium.org/578423002 Cr-Commit-Position: refs/heads/master@{#296184}
* Try to make `git cl try` match the CQ more closelyscottmg2014-09-201-0/+10
| | | | | | | | | | | Two lists ftw! R=maruel@chromium.org BUG=416120 Review URL: https://codereview.chromium.org/589703002 Cr-Commit-Position: refs/heads/master@{#295830}
* Add PRESUBMIT check for deprecated IPC_ENUM_TRAITS().mlamouri2014-09-161-0/+29
| | | | | | | | BUG=414725 Review URL: https://codereview.chromium.org/577643003 Cr-Commit-Position: refs/heads/master@{#295112}
* Add win8_chromium_rel to the default set of try jobs.danakj2014-09-161-0/+3
| | | | | | | | | | Since the CQ runs this bot, git cl try should too. BUG=413904 Review URL: https://codereview.chromium.org/565393002 Cr-Commit-Position: refs/heads/master@{#294964}
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in [c-n]*/thestig2014-09-131-0/+1
| | | | | | | | | TBR=cpu@chromium.org,jochen@chromium.org,piman@chromium.org,rockot@chromium.org,rsleevi@chromium.org,vrk@chromium.org ,zea@chromium.org Review URL: https://codereview.chromium.org/563173002 Cr-Commit-Position: refs/heads/master@{#294712}
* Add an 'Idle Wake Ups' metric to the Linux task manager, implement backend.thestig2014-09-091-0/+1
| | | | | | | | BUG=120488 Review URL: https://codereview.chromium.org/546193002 Cr-Commit-Position: refs/heads/master@{#293991}
* Change base/file_utils.h includes to base/files/file_utils.h in gin, ↵thestig2014-09-051-1/+3
| | | | | | | | | | google_apis, printing, sql, ui, and webkit. TBR=jochen@chromium.org,rogerta@chromium.org,shess@chromium.org,ben@chromium.org,jamesr@chromium.org Review URL: https://codereview.chromium.org/529273002 Cr-Commit-Position: refs/heads/master@{#293479}
* Support both \ and / as path separators in regexes.joaodasilva2014-08-301-17/+17
| | | | | | | | | | Also cleanup src/PRESUBMIT.py to use a common pattern for this. BUG=409029 Review URL: https://codereview.chromium.org/518863002 Cr-Commit-Position: refs/heads/master@{#292784}
* Update some paths from components/breakpad/ to components/crash/philipj2014-08-281-1/+1
| | | | | | | | | | | | | | It was moved in https://crrev.com/55b8563 Found by git grep 'components.*breakpad' BUG=406410 R=rsesek@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/511223002 Cr-Commit-Position: refs/heads/master@{#292376}
* Remove SVN Config PRESUBMIT check.iannucci2014-08-241-45/+0
| | | | | | | | | | TBR=maruel@chromium.org R=szager@chromium.org BUG=362394 Review URL: https://codereview.chromium.org/484393003 Cr-Commit-Position: refs/heads/master@{#291613}
* Use android_dbg_tests_recipe for manual try jobs instead of android_dbg & ↵jam@chromium.org2014-08-221-3/+3
| | | | | | | | | | | | android_dbg_triggered_tests since that's what the CQ uses now. BUG=403411 NOTRY=true Review URL: https://codereview.chromium.org/496873002 Cr-Commit-Position: refs/heads/master@{#291520} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291520 0039d316-1c4b-4281-b951-d872f2087c98
* Switch tryjobs to use swarming version of win_chromium_x64_rel now that CQ ↵jam@chromium.org2014-08-151-2/+2
| | | | | | | | | | | changed as well. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/482433002 Cr-Commit-Position: refs/heads/master@{#290051} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290051 0039d316-1c4b-4281-b951-d872f2087c98
* Do not run header include order checks on blacklisted filesdominik.rottsches@intel.com2014-08-151-1/+4
| | | | | | | | | | | | | | The header include order checks were running on all affected files, including third_party for example, this causes issues when rolling harfbuzz-ng. BUG=404105 NOTRY=true Review URL: https://codereview.chromium.org/462323003 Cr-Commit-Position: refs/heads/master@{#289968} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289968 0039d316-1c4b-4281-b951-d872f2087c98
* Update presubmit files to send windows tryjobs to swarming bots, now that ↵jam@chromium.org2014-08-131-3/+6
| | | | | | | | | | | the CQ has switched over. R=avi@chromium.org Review URL: https://codereview.chromium.org/461313002 Cr-Commit-Position: refs/heads/master@{#289157} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289157 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo from r288440thakis@chromium.org2014-08-081-1/+1
| | | | | | | | | | BUG= TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/452313003 Cr-Commit-Position: refs/heads/master@{#288447} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288447 0039d316-1c4b-4281-b951-d872f2087c98
* Add diagnostics_writer.cc to the list of files allowed to printf.thakis@chromium.org2014-08-081-0/+2
| | | | | | | | | | BUG= TBR=maruel Review URL: https://codereview.chromium.org/458503002 Cr-Commit-Position: refs/heads/master@{#288440} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288440 0039d316-1c4b-4281-b951-d872f2087c98
* Fix git cl try failure.jam@chromium.org2014-08-071-3/+3
| | | | | | Review URL: https://codereview.chromium.org/448013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288086 0039d316-1c4b-4281-b951-d872f2087c98
* Update manually triggered try jobs to use swarming for ChromeOS and Mac ↵jam@chromium.org2014-08-071-2/+2
| | | | | | | | | | since they're switched by CQ already. TBR=ben Review URL: https://codereview.chromium.org/450583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288050 0039d316-1c4b-4281-b951-d872f2087c98
* Exempts chromecast/ directory from spam-logging presubmit check.gunsch@chromium.org2014-08-071-3/+4
| | | | | | | | | | | | None of chromecast/ is part of chrome binary. R=lcwu@chromium.org,maruel@chromium.org BUG=None NOTRY=true Review URL: https://codereview.chromium.org/448903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287946 0039d316-1c4b-4281-b951-d872f2087c98
* Update masters after the tryserver split.sergeyberezin@chromium.org2014-07-261-5/+21
| | | | | | | | | | | Also replace deprecated linux_chromium_rel with linux_chromium_rel_swarming, while I'm at it. R=agable@chromium.org, maruel@chromium.org BUG=395196 Review URL: https://codereview.chromium.org/415323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285752 0039d316-1c4b-4281-b951-d872f2087c98
* URL have moved for this error message.uekawa@chromium.org2014-06-281-1/+1
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/360563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280529 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Add PRESUBMIT.py warning for contradictory NOTREACHED() use. ↵miguelg@chromium.org2014-06-251-89/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/344563003/) Reason for revert: It seems to be checking code that is not part of the diff. I also think there are some legitimate cases for not reached in the middle of a block but that is something that can be discussed on the bug. Filed https://code.google.com/p/chromium/issues/detail?id=388731 to track. Original issue's description: > Add PRESUBMIT.py warning for contradictory NOTREACHED() use. > > As recently discussed on chromium-dev [1] and subsequently incorporated into the > Chromium Coding Style [2], NOTREACHED() followed by code is an anti-pattern. > This CL lets PRESUBMIT.py detect most of these cases and print a warning to the > developer. > [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/c2X0D1Z6X2o/ddkFLqQP0P0J > [2] http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED- > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279681 TBR=maruel@chromium.org,tnagel@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/357693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279710 0039d316-1c4b-4281-b951-d872f2087c98
* Add PRESUBMIT.py warning for contradictory NOTREACHED() use.tnagel@chromium.org2014-06-251-0/+89
| | | | | | | | | | | | | | | As recently discussed on chromium-dev [1] and subsequently incorporated into the Chromium Coding Style [2], NOTREACHED() followed by code is an anti-pattern. This CL lets PRESUBMIT.py detect most of these cases and print a warning to the developer. [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/c2X0D1Z6X2o/ddkFLqQP0P0J [2] http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED- BUG=none Review URL: https://codereview.chromium.org/344563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279681 0039d316-1c4b-4281-b951-d872f2087c98
* Get iossim to compile with Xcode 6.lliabraa@chromium.org2014-06-201-0/+2
| | | | | | | | | | | | | | | | | Xcode 6 moved the location of the frameworks that iossim depends on and added a few new dependecies so new header files need to be generated by the gyp target. Note that this CL gets iossim to compile but iossim will not launch the Xcode 6 simulator. BUG=381213 NOTRY=true TBR=rohitrao@chromium.org Review URL: https://codereview.chromium.org/336773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278786 0039d316-1c4b-4281-b951-d872f2087c98
* Remove from PRESUBMIT.py builders that will get removed from the tryserverphajdan.jr@chromium.org2014-06-091-53/+0
| | | | | | | | | | | See https://codereview.chromium.org/323483002/ BUG=380709 R=kjellander@chromium.org Review URL: https://codereview.chromium.org/320823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275798 0039d316-1c4b-4281-b951-d872f2087c98
* Write "logout-started" event on next boot.alemate@chromium.org2014-06-031-0/+1
| | | | | | | | | | | | Writing logout-started on process exit is unstable. So moving it to next boot. BUG=352130 TEST=manual Review URL: https://codereview.chromium.org/303233004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274649 0039d316-1c4b-4281-b951-d872f2087c98
* Add global presubmit that JSON and IDL files can be parsed.yoz@chromium.org2014-06-031-0/+101
| | | | | | | | | | | | | Sometimes, changes to JSON/IDL files make them invalid. It's easier to check these at presubmit time than discovering they can't be parsed at runtime. This just moves the check from chrome/common/extensions/api to top-level. This presubmit check excludes files in test/data directories. BUG=366395 Review URL: https://codereview.chromium.org/239283008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274432 0039d316-1c4b-4281-b951-d872f2087c98
* Delete old mini_installer_test.grt@chromium.org2014-06-021-1/+1
| | | | | | | | | | And run the new Python-driven test_mini_installer on win_rel trybot. BUG=277655 Review URL: https://codereview.chromium.org/301223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274260 0039d316-1c4b-4281-b951-d872f2087c98
* Update path of checkdeps to buildtools checkoutjochen@chromium.org2014-05-291-1/+1
| | | | | | | | | BUG=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/305633007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273587 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist some file for the CSS deprecation hookjchaffraix@chromium.org2014-05-221-2/+12
| | | | | | | | | | | There are some documentation in the Chromium tree that is meant for external consumption (which includes WebKit) so it can't use the unprefixed CSS properties / values or functions. Review URL: https://codereview.chromium.org/294893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272027 0039d316-1c4b-4281-b951-d872f2087c98
* Add check to make sure to make surethe production code is not calling a ↵oshima@chromium.org2014-05-141-2/+2
| | | | | | | | | | | function in test namespace BUG=None NOTRY=true Review URL: https://codereview.chromium.org/285623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270300 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser test for CustomizationWallpaperDownloader.alemate@chromium.org2014-05-121-0/+1
| | | | | | | | | | | | | | | Also implements TestURLFetcher::SaveResponseToTemporaryFile(), and explicitly allows ScopedIO in TestURLFetcher, as it doesn't support asynchronous IO by design. Note to tree sheriffs: this CL can break tests using FakeURLFetcherFactory. BUG=366614 TEST=none Review URL: https://codereview.chromium.org/253833006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269907 0039d316-1c4b-4281-b951-d872f2087c98
* Added mac_gpu to the default set of try servers.kbr@chromium.org2014-05-091-0/+3
| | | | | | | | | | | | | | mac_gpu is already experimentally receiving a percentage of the Chromium and Blink CQs' load, and the hardware has just been fully built out. Expand its testing to cover manually submitted try jobs. BUG=327170 R=phajdan.jr@chromium.org,maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/269313009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269410 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit hook for deprecated CSSjchaffraix@chromium.org2014-05-091-0/+39
| | | | | | | | | | | | | | | | | Chromium's resources are using a gazillion deprecated CSS properties, functions or values. This is bothering as Blink's UseCounter doesn't discriminate between chrome:// pages and web pages so they get counted. But more conceptually, Chromium's developers should be leading the way and not use some CSS that was deprecated 2+ years ago. The initial list only contains items with an unprefixed counterpart. Review URL: https://codereview.chromium.org/261773009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269149 0039d316-1c4b-4281-b951-d872f2087c98
* Add GN bots to default try set to match the CQ.dpranke@chromium.org2014-05-071-0/+4
| | | | | | | | | R=brettw@chromium.org, phajdan.jr@chromium.org BUG=353690 Review URL: https://codereview.chromium.org/263293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268748 0039d316-1c4b-4281-b951-d872f2087c98
* Added win_gpu to the default set of try servers.kbr@chromium.org2014-04-301-0/+3
| | | | | | | | | | | | | | win_gpu is already experimentally receiving a percentage of the Chromium and Blink CQs' load. Expand its testing to cover manually submitted try jobs. BUG=327170 R=phajdan.jr@chromium.org,maruel@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/258233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267023 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 265881 - "Add simple PRESUBMIT check to ensure that all files ending ↵yoz@chromium.org2014-04-251-16/+0
| | | | | | | | | | | | | | | with .json can" Revert 266019 - "Add detail to 'invalid JSON' message in PRESUBMIT.py." This presubmit check is invalid - it fails on existing .json files in the tree that contain comments. (Other JSON-reading tools strip out these comments.) Any changes to these .json files are incorrectly rejected by this check. BUG=366395 TBR=iannucci@chromium.org,tnagel@chromium.org Review URL: https://codereview.chromium.org/252713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266191 0039d316-1c4b-4281-b951-d872f2087c98
* Add detail to 'invalid JSON' message in PRESUBMIT.py.tnagel@chromium.org2014-04-241-2/+3
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/255613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266019 0039d316-1c4b-4281-b951-d872f2087c98
* Add simple PRESUBMIT check to ensure that all files ending with .json caniannucci@chromium.org2014-04-241-0/+15
| | | | | | | | | | | be loaded as json. R=jochen@chromium.org, maruel@chromium.org BUG=366395 Review URL: https://codereview.chromium.org/258473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265881 0039d316-1c4b-4281-b951-d872f2087c98
* Added linux_gpu to the default set of try servers.kbr@chromium.org2014-04-231-9/+23
| | | | | | | | | | | | | | | This configuration is already experimentally receiving 100% of the Chromium and Blink CQs' load. Expand its testing to cover manually submitted try jobs as well. As a side-effect, added multi-master support to GetDefaultTryConfigs. Tested manually. BUG=327170 Review URL: https://codereview.chromium.org/242963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265455 0039d316-1c4b-4281-b951-d872f2087c98
* Move extensions bindings code out of //chromerockot@chromium.org2014-04-171-2/+1
| | | | | | | | | | | | | | | | | | | | This moves several native handlers out of //chrome/renderer/extensions and into //extensions/renderer. Many of the changes are mechanical. Where applicable, ChromeV8Extension has been wiped out. BUG=359836 R=yoz@chromium.org TBR=reed@google.com for skia +DEPS TBR=ericu@chromium.org for fileapi +DEPS TBR=eseidel@chromium.org for WebKit/public/platform +DEPS TBR=sky@chromium.org for chrome/test TBR=maruel@chromium.org for PRESUBMIT.py Review URL: https://codereview.chromium.org/235943018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264413 0039d316-1c4b-4281-b951-d872f2087c98
* Enable use of regular expressions in banned obj-c function list.leng@chromium.org2014-04-161-2/+9
| | | | | | | | | | | Uses the regex to allow use of NSTrackingAreaOptions, while still banning NSTrackingArea. BUG=None Review URL: https://codereview.chromium.org/237463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264109 0039d316-1c4b-4281-b951-d872f2087c98
* Sync PRESUBMIT with CQ: win_x64_rel -> win_chromium_x64_relphajdan.jr@chromium.org2014-04-151-1/+2
| | | | | | | | | BUG=358130 R=maruel@chromium.org Review URL: https://codereview.chromium.org/239223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263891 0039d316-1c4b-4281-b951-d872f2087c98
* Sync PRESUBMIT files with latest CQ changesphajdan.jr@chromium.org2014-04-151-2/+4
| | | | | | | | | BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/237383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263810 0039d316-1c4b-4281-b951-d872f2087c98
* Move most of ChromeV8Context to a base ScriptContextrockot@chromium.org2014-04-121-1/+3
| | | | | | | | | | | | | | | | | | This also moves ModuleSystem, RequestSender, ObjectBackedNativeHandler, and SafeBuiltins over to //extensions. Other renderer code is updated minimally to support these changes. BUG=359836 TBR=sky@chromium.org for chrome/test TBR=jamescook@chromium.org for apps/shell TBR=maruel@chromium.org for PRESUBMIT.py Review URL: https://codereview.chromium.org/234413005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263429 0039d316-1c4b-4281-b951-d872f2087c98
* Update content/shell/common/test_runner to chromium coding stylejochen@chromium.org2014-04-041-1/+0
| | | | | | | | | | BUG=331299 TBR=maruel@chromium.org R=marja@chromium.org Review URL: https://codereview.chromium.org/225543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261881 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure no new v8::Extensions are added.jochen@chromium.org2014-04-041-0/+9
| | | | | | | | | | | New code should use gin::Wrappable<> instead BUG=334679 R=maruel@chromium.org Review URL: https://codereview.chromium.org/225863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261804 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 09:01:05 +0000